From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-arm-kernel@lists.infradead.org
Cc: alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] coresight: etb10: Refactor etb_drvdata::mode handling
Date: Thu, 16 Aug 2018 16:13:03 +0100 [thread overview]
Message-ID: <5cd6b8a8-2370-517d-deb1-378bff6e362b@arm.com> (raw)
In-Reply-To: <1534284866-2523-1-git-send-email-mathieu.poirier@linaro.org>
Hi Mathieu,
The patch looks good to me. One minor nit below.
On 14/08/18 23:14, Mathieu Poirier wrote:
> This patch moves the etb_drvdata::mode from a locat_t to a simple u32,
> as it is for the ETF and ETR drivers. This streamlines the code and adds
> commonality with the other drivers when dealing with similar operations.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-etb10.c | 62 +++++++++++++++------------
> 1 file changed, 34 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
> index 9fd77fdc1244..69287163ce4e 100644
> --- a/drivers/hwtracing/coresight/coresight-etb10.c
> +++ b/drivers/hwtracing/coresight/coresight-etb10.c
> @@ -488,7 +494,7 @@ static void etb_dump(struct etb_drvdata *drvdata)
> unsigned long flags;
>
> spin_lock_irqsave(&drvdata->spinlock, flags);
> - if (local_read(&drvdata->mode) == CS_MODE_SYSFS) {
> + if (drvdata->mode == CS_MODE_SYSFS) {
> etb_disable_hw(drvdata);
> etb_dump_hw(drvdata);
> etb_enable_hw(drvdata);
Looks good to me.
Reviewed-by : Suzuki K Poulose <suzuki.poulose@arm.com>
next prev parent reply other threads:[~2018-08-16 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 22:14 Mathieu Poirier
2018-08-14 22:14 ` [PATCH 2/2] coresight: etb10: Splitting function etb_enable() Mathieu Poirier
2018-08-16 15:44 ` Suzuki K Poulose
2018-08-16 15:13 ` Suzuki K Poulose [this message]
2018-08-16 15:48 ` [PATCH 1/2] coresight: etb10: Refactor etb_drvdata::mode handling Mathieu Poirier
2018-08-16 15:50 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cd6b8a8-2370-517d-deb1-378bff6e362b@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®