mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denis Efremov <efremov@linux.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Emil Velikov <emil.l.velikov@gmail.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lz4: make LZ4HC_setExternalDict as non-static
Date: Fri, 6 Sep 2019 19:21:49 +0300	[thread overview]
Message-ID: <5ce4f4c7-f764-8937-75bf-83a4d4c57fa7@linux.com> (raw)
In-Reply-To: <20190906153700.2061625-1-arnd@arndb.de>

Hi,

> kbuild warns for exported static symbols. This one seems to
> be meant as an external API but does not have any in-kernel
> users:
> 
> WARNING: "LZ4HC_setExternalDict" [vmlinux] is a static EXPORT_SYMBOL
> 
> I suppose the function should not just get removed since it would
> be nice to stay close to the upstream version of lz4hc, so just
> make it global.

I'm not sure what is better here. But just in case, I sent a different
patch that removes EXPORT_SYMBOL from this function some time ago:
https://lkml.org/lkml/2019/7/8/842

I checked first that this functions is indeed static in the original lib[1]
and this symbol is not used in kernel.

[1] https://github.com/lz4/lz4/blob/dev/lib/lz4hc.c#L1054

Thanks,
Denis

  reply	other threads:[~2019-09-06 16:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 15:36 Arnd Bergmann
2019-09-06 16:21 ` Denis Efremov [this message]
2019-09-06 18:43   ` Arnd Bergmann
2019-09-07  2:14     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ce4f4c7-f764-8937-75bf-83a4d4c57fa7@linux.com \
    --to=efremov@linux.com \
    --cc=arnd@arndb.de \
    --cc=emil.l.velikov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®