mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wadim Egorov <w.egorov@phytec.de>
To: Daniel Schultz <d.schultz@phytec.de>, lee.jones@linaro.org
Cc: zhangqing@rock-chips.com, xsf@rock-chips.com,
	tony.xie@rock-chips.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: rk808: Add restart functionality
Date: Fri, 16 Mar 2018 12:49:08 +0100	[thread overview]
Message-ID: <5cec78da-9b76-12fa-703a-bbaa90a6d58c@phytec.de> (raw)
In-Reply-To: <1521188783-14985-1-git-send-email-d.schultz@phytec.de>

Hi Daniel,

Am 16.03.2018 um 09:26 schrieb Daniel Schultz:
> When using Rockchip SoCs with rk805/808/818 PMICs, restarts are realized by
> setting the reset registers in the "Clock and Reset Unit".
>
> Since all three shutdown functions have almost the same code, all logic
> from the shutdown functions can be refactored to a new function
> "rk808_update_bits", which can update a register by a given address and
> bitmask.
>
> After that, notifier blocks and the restart functions were added to the
> driver. Like the shutdown function, the restart is bound to the
> "rockchip,system-power-controller" device tree property and can easily
> revoked to the software restart by removing the property.
can you please split the changes into separate patches? One patch for
the refactoring of the shutdown functions and one for the new
system-reset-controller binding.

Regards,
Wadim

      reply	other threads:[~2018-03-16 11:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16  8:26 Daniel Schultz
2018-03-16 11:49 ` Wadim Egorov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cec78da-9b76-12fa-703a-bbaa90a6d58c@phytec.de \
    --to=w.egorov@phytec.de \
    --cc=d.schultz@phytec.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.xie@rock-chips.com \
    --cc=xsf@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome