From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7399CC433EF for ; Tue, 10 May 2022 08:10:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237837AbiEJIOo (ORCPT ); Tue, 10 May 2022 04:14:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232591AbiEJIOk (ORCPT ); Tue, 10 May 2022 04:14:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41A2FF51; Tue, 10 May 2022 01:10:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D0FD561187; Tue, 10 May 2022 08:10:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13DE1C385C8; Tue, 10 May 2022 08:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652170242; bh=f21nPmGeD4XcBz7OWRi3kw2WYaSEg8ChapSGdkrXTuo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WFIci6vIp2cSMmVsxaI3hyUn0AP+IIbE11w504bRJ1xWzSmnPR1heOFzizdjbZ8MN hi0csyWyyGf158VY+6xN2T6nqdRRvKQOSVPmPjgcT78aq62BfxpvnSddAV2gjf8k0z xCSjNIv4EmyhiqWZsA26P6iWW9Kw6fnIcq2h2WMuA5CGYNnUhj3mbhbyrH4VGKSGK/ fXbjljz3EfCvxlqd4EdNa3tAYe32zZnQhWMuQfu2CbKGzlk/Xdz5Vp/fzz4USV8u0I ZNalmgoad6In51RCc79F9+TQZMCof8UFgRxiXREcBcZ6QM7y/ohnQt7Sg5t0e5q7bs gNyWxN5lTXudw== Message-ID: <5cec89ab-76f7-65d5-0b1d-fdd768234f0e@kernel.org> Date: Tue, 10 May 2022 11:10:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] memory: OMAP_GPMC should depend on ARCH_OMAP2PLUS || ARCH_K3 Content-Language: en-US To: Geert Uytterhoeven Cc: Krzysztof Kozlowski , Tony Lindgren , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" , Linux Kernel Mailing List References: <2b7d411b4a7913335082c858cb0d63b9e4bf7c5b.1652103920.git.geert+renesas@glider.be> <20fd1a74-c0f5-d8e9-4903-b74c185d5aa3@kernel.org> <22ed864d-8d71-7042-4d55-2b0b65d4d281@kernel.org> From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Geert, On 10/05/2022 11:06, Geert Uytterhoeven wrote: > Hi Roger, > > On Tue, May 10, 2022 at 9:40 AM Roger Quadros wrote: >> On 10/05/2022 10:30, Geert Uytterhoeven wrote: >>> On Tue, May 10, 2022 at 9:22 AM Roger Quadros wrote: >>>> On 09/05/2022 16:48, Geert Uytterhoeven wrote: >>>>> The Texas Instruments OMAP General Purpose Memory Controller (GPMC) is >>>>> only present on TI OMAP2/3/4/5, AM33xx, AM43x, DRA7xx, TI81xx, and K3 >>>>> SoCs. Hence add a dependency on ARCH_OMAP2PLUS || ARCH_K3, to prevent >>>>> asking the user about this driver when configuring a kernel without >>>>> OMAP2+ or K3 SoC family support. >>>>> >>>>> Fixes: be34f45f0d4aa91c ("memory: omap-gpmc: Make OMAP_GPMC config visible and selectable") >>>>> Signed-off-by: Geert Uytterhoeven > >> Could you please also add ARCH_KEYSTONE in the 'depends on' list >> as some SoCs in that architecture do have the GPMC block. > > Are you sure? AFAICS, none of the Keystone DTS files have device > nodes that are compatible with the match list in the omap-gpmc driver. Yes, the 66AK2G12 SoC contains the GPMC module. [1] > > Or perhaps the GPMC support still has to be added to the Keystone > DTS files (and or driver)? That's most likely the case. cheers, -roger [1] 66AK2G12 datasheet: https://www.ti.com/lit/ds/symlink/66ak2g12.pdf?ts=1652170122865&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252F66AK2G12