From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BB6FC43613 for ; Mon, 24 Jun 2019 08:34:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7133F2089F for ; Mon, 24 Jun 2019 08:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728148AbfFXIeq (ORCPT ); Mon, 24 Jun 2019 04:34:46 -0400 Received: from foss.arm.com ([217.140.110.172]:43688 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbfFXIep (ORCPT ); Mon, 24 Jun 2019 04:34:45 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E42722B; Mon, 24 Jun 2019 01:34:44 -0700 (PDT) Received: from [10.1.196.93] (en101.cambridge.arm.com [10.1.196.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3B41B3F71E; Mon, 24 Jun 2019 01:34:43 -0700 (PDT) Subject: Re: [PATCH v2 13/28] drivers: Introduce class_find_device_by_of_node() helper To: peda@axentia.se, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, rafael@kernel.org, atull@kernel.org, mdf@kernel.org, linux-fpga@vger.kernel.org, broonie@kernel.org, f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net, andrew@lunn.ch, lgirdwood@gmail.com, jslaby@suse.com References: <1560534863-15115-1-git-send-email-suzuki.poulose@arm.com> <1560534863-15115-14-git-send-email-suzuki.poulose@arm.com> <325e46fd-a480-78ed-81fd-55e993fbc06f@axentia.se> From: Suzuki K Poulose Message-ID: <5cf1a8e2-bb1e-b6bc-32fe-93db0a6b5efd@arm.com> Date: Mon, 24 Jun 2019 09:34:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <325e46fd-a480-78ed-81fd-55e993fbc06f@axentia.se> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 22/06/2019 06:25, Peter Rosin wrote: > On 2019-06-14 19:54, Suzuki K Poulose wrote: >> Add a wrapper to class_find_device() to search for a device >> by the of_node pointer, reusing the generic match function. >> Also convert the existing users to make use of the new helper. >> >> Cc: Alan Tull >> Cc: Moritz Fischer >> Cc: linux-fpga@vger.kernel.org >> Cc: Peter Rosin >> Cc: Mark Brown >> Cc: Florian Fainelli >> Cc: Heiner Kallweit >> Cc: "David S. Miller" >> Cc: Andrew Lunn >> Cc: Liam Girdwood >> Cc: Greg Kroah-Hartman >> Cc: "Rafael J. Wysocki" >> Cc: Jiri Slaby >> Acked-by: Mark Brown >> Reviewed-by: Andrew Lunn >> Reviewed-by: Peter Rosin > > Whoooa! I reviewed only the drivers/mux/core.c changes when this was done > in a series of much smaller patches. This tag makes it seem as if I have > reviewed the whole thing, which I had not done when you added this tag out > of the blue. Apologies for the surprise. The patch was simply squashed with the change that introduced the "helper" to better aid the reviewers, based on suggestions on the list. I kept your tags, only because there were no changes, but some additional context on the core driver. > > Now, this stuff is trivial and by now I have looked at the other files > and it all seems simple enough. So, you can keep the tag, but it is NOT > ok to handle tags like you have done here. Sure, I will keep that in mind. Cheers Suzuki