From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E434E3A8751 for ; Mon, 30 Mar 2026 07:59:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774857563; cv=none; b=VoNZHSyO99cBaR/+ROyoHHlf8yfN0v43Zv4gJEbdQD810U6XaH+925NvqjnaxVzqXH8jNwJ4VqRhxcc24BY/5tP76xV8xmdPJ30SsuD0F14fcibRXl7ICaaP4ZMB5hSV33gROHZJfXWjprG1P4OTZMFvnVKwqQjECf7aSuFxOl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774857563; c=relaxed/simple; bh=k6JUuhq42SSwIgVxyv7fWCOM8fhm0hvAp+G2ZzzZ9Ko=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZdukylnOYlKLwoTllXh91dTdKzPzfnmzrvTsf63hk77+5CZjzMLzzFN5jzGb8FLBvwYaIT5VeoWmpEf4rRxqhKuxgB4LgYsUZx0g8CBs5vZHpp/nKiu7iBIjp4u6/QswLt9xkB3GMTwc1VwfnRmWwam8pQ6WDdqcSufOXgNEilU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com; spf=pass smtp.mailfrom=cogentembedded.com; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b=0mCZxl4Z; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b="0mCZxl4Z" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43b8982c2f4so2052578f8f.2 for ; Mon, 30 Mar 2026 00:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20230601.gappssmtp.com; s=20230601; t=1774857560; x=1775462360; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y35FqnBB++fiJjPiIxMgwhz88Bst+PlLvtoiYEI+bUs=; b=0mCZxl4ZaqKtIpnZGqEQ/DTXTNdGzumdnUuwy4ECpbYFzp79oePxMBMjhfMZKON8K1 uH6ncjMNkKFKWZ40QBrVeud9U1BdtRiMTBUWrobZ20WkG6aErtq/PK4LbsGoF3wurl89 ZAceDXXBU03MAvQ3+6aUJ2zyeVQ7N+BrbV1MxW2W4fIHIPi+kbmb+PXVDtWHot9yx1ts cjqypIYuJu585odUccCwFOPEgyCuSYObisUY6oGM7bNI10a4dnR8ytNjuzJuqKWpPDBE CL9wBUHkfeIH0uuKitwnZYBOP6iC6zickBdd2HiepwXDjo6JLMooAvlnNIMtHiTzqdKJ jokg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774857560; x=1775462360; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y35FqnBB++fiJjPiIxMgwhz88Bst+PlLvtoiYEI+bUs=; b=BppQDmvOzwHaGTrzy7wB0+eLS0Tl12mwzNgkH1hSix82E0k6KFsAIq1JjvvqDDFrUk /TmkAeC6huhFGjNfqKxMfgMaYlPMAsXU4ktHu1zwLwjvg8Ec7AjrPPS4bVd3u3ea2Jn5 tA4hFksDmf4ilhMsWifTlF8nSS3kyIRAYsXYwi0HjOPgoAeCso8z5JjhUDvWN4i/7H8M kP3tay7OqXzao4d+DH5m2wViUv5KIU2+DwYmO9VXKI7epBW5IyEnvetEuHm5je9c4BZr NAK/Pieynfk9d7023zGdj62vhNq/gksXNUELK2yWYcAmvSh4qeA0WPFKghkzgA8mz2s3 5ZsQ== X-Forwarded-Encrypted: i=1; AJvYcCWOAHbBBK1OiC7NQ/LBo1jhAxxxMyXDijyVL7H92Ijv1oNadYT6CPPLqx2xDiZ30zKwdYOZsB68q4RSx2Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwXIjwPu3SgcaeeqJmatr2vXNkSvDhgCuv0Bnf4w1uvCDHj+LQB gn1NDRU7RRanDP/mwCM2bkEzavE3kOWQCsIUN/fKKLEDrdvyZFlYG99Tlhu8NTtQ+PiuldicF5f UVmjw X-Gm-Gg: ATEYQzxQptfvdr1affrAZ4zxeD5unUHPb8XRqxWdAQFHrzArv3V+HyO26Yb+uZD/z2n Ec/sLMABZCj7jJ1gyRCNJgOZOzP9gohA7ErnrD+MHFdbwXnqGYH/Tuz9jDWR5tRv6mNWtVpvobm GLQ9kbsu9x/vZ42gt2o/jaOYLm/GAJzDZhrFVJhh6h4NPkMg1MtYoQLIxbNUnMPNlyHpbi4EQ54 RWgsLiQJzKPCwrrEUM8oRAT7O7jSpoulOHga3oh4SmIqCZdIaXgAtNXsgDT3hD2OMSsIzL/fw11 mDhhUuc6LS7IJzeaWnWiXDDlou4qYYKcbmA5dOANqYQqBSZtZsp59xDaljeiKNPe//0emKiG7Dk vEnBcHz7Ejoq0dxXqHDw9gA6MOLIoBtOM9BFeyUsXXQD9CuwD0T1EKLZVpVJjqZCQJFZ+VYvv1+ mrR8hFufO07XDnWrv5nptT0LWsx878Gvb7IhZLQih7+RAVaXR3 X-Received: by 2002:a05:6000:2f8a:b0:43b:47ee:4586 with SMTP id ffacd0b85a97d-43b9ea4aac1mr18960326f8f.29.1774857560274; Mon, 30 Mar 2026 00:59:20 -0700 (PDT) Received: from ?IPV6:2a02:810a:b98:a000::ae46? ([2a02:810a:b98:a000::ae46]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21eb95fsm18840598f8f.12.2026.03.30.00.59.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 00:59:19 -0700 (PDT) Message-ID: <5cf41f14-e694-4b06-8b82-1d98238758d4@cogentembedded.com> Date: Mon, 30 Mar 2026 09:59:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: renesas: rswitch: Fix memory leak in rswitch_phy_device_init() To: Ma Ke , yoshihiro.shimoda.uh@renesas.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, niklas.soderlund+renesas@ragnatech.se, michael.dege@renesas.com, yury.norov@gmail.com, geert+renesas@glider.be Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260330073541.2871414-1-make24@iscas.ac.cn> Content-Language: en-US, ru-RU From: Nikita Yushchenko In-Reply-To: <20260330073541.2871414-1-make24@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > - phydev = of_phy_find_device(phy); > - if (!phydev) > + tmp_phydev = of_phy_find_device(phy); > + if (!tmp_phydev) > goto out; > - __set_bit(rdev->etha->phy_interface, phydev->host_interfaces); > + __set_bit(rdev->etha->phy_interface, tmp_phydev->host_interfaces); > phydev->mac_managed_pm = true; shall be tmp_phydev ?