mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonas Karlman <jonas@kwiboo.se>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/8] ARM: dts: rockchip: Add support for RK3506
Date: Sun, 22 Nov 2026 17:01:08 +0100	[thread overview]
Message-ID: <5cf52e28-110a-4fc2-acfb-eb264e8c31e2@kwiboo.se> (raw)
In-Reply-To: <86007bdd-6c10-46ba-aac6-197939934c73@lunn.ch>

Hi Andrew,

On 11/22/2026 4:46 PM, Andrew Lunn wrote:
>> diff --git a/arch/arm/boot/dts/rockchip/rk3506.dtsi b/arch/arm/boot/dts/rockchip/rk3506.dtsi
> 
>> +		gmac0: ethernet@ff4c8000 {
>> +			compatible = "rockchip,rk3506-gmac", "snps,dwmac-4.20a";
>> +			reg = <0xff4c8000 0x2000>;
>> +			clocks = <&cru CLK_MAC0>, <&cru CLK_MAC0_PTP>,
>> +				 <&cru PCLK_MAC0>, <&cru ACLK_MAC0>;
>> +			clock-names = "stmmaceth", "ptp_ref",
>> +				      "pclk_mac", "aclk_mac";
>> +			interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
>> +			interrupt-names = "macirq", "eth_wake_irq";
>> +			phy-mode = "rmii";
> 
> Sorry, missed this on the first pass of the patchset.
> 
> phy-mode is generally a board/PCB property, not a SoC property. It
> would only be a SoC property when the SoC cannot do anything other
> than RMII. But given this is snps,dwmac, i expect it can do other phy
> modes.

This SoC only support RMII mode, so I put the phy-mode at SoC level.

Datasheet for this SoC lists following:

  RMII 10/100 Ethernet Controller
  - Support two Ethernet Controllers
  - Supports 10/100-Mbps data transfer rates with the RMII interfaces
  - Supports both full-duplex and half-duplex operation

The Technical Reference Manual also only mention RMII:

  38.2 Block Diagram
  ...
  The MAC only supports the PHY interfaces of reduced MII (RMII).
  ...
  MAC Supports 10/100-Mbps data transfer rates with the RMII interfaces.

Regards,
Jonas

> 
> 	Andrew


  reply	other threads:[~2026-11-22 16:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22  6:01 [PATCH v2 0/8] ARM: dts: rockchip: Add Luckfox Lyra boards Jonas Karlman
2026-11-22  6:01 ` [PATCH v2 1/8] dt-bindings: soc: rockchip: grf: Add RK3506 compatibles Jonas Karlman
2026-11-22  6:01 ` [PATCH v2 2/8] ARM: dts: rockchip: Add support for RK3506 Jonas Karlman
2026-11-22 15:46   ` Andrew Lunn
2026-11-22 16:01     ` Jonas Karlman [this message]
2026-11-22  6:01 ` [PATCH v2 3/8] dt-bindings: arm: rockchip: Add Luckfox Lyra and Lyra Plus Jonas Karlman
2026-11-22  6:01 ` [PATCH v2 4/8] ARM: dts: rockchip: Add Luckfox Lyra and Lyra Plus boards Jonas Karlman
2026-11-22 15:34   ` Andrew Lunn
2026-11-22  6:01 ` [PATCH v2 5/8] dt-bindings: arm: rockchip: Add Luckfox Lyra Ultra Jonas Karlman
2026-11-22  6:01 ` [PATCH v2 6/8] ARM: dts: rockchip: Add Luckfox Lyra Ultra board Jonas Karlman
2026-11-22  6:01 ` [PATCH v2 7/8] dt-bindings: arm: rockchip: Add Luckfox Lyra Zero W Jonas Karlman
2026-11-22  6:01 ` [PATCH v2 8/8] ARM: dts: rockchip: Add Luckfox Lyra Zero W board Jonas Karlman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cf52e28-110a-4fc2-acfb-eb264e8c31e2@kwiboo.se \
    --to=jonas@kwiboo.se \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®