From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE72638910E for ; Wed, 8 Jul 2026 07:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496123; cv=none; b=GV6iwzB3yEY5YhBjQk7Wj1Hn83CxEq1ZyosuQiwD6ONchjtgGPFLfQ2pa+I8OAX6YYFMN/WdxvL2+SY931iH9XwcDPlu3iJOGYey/DjzUSetIS+e1bAX2ApfJkcdI/F7OvdgkWDkY9GldBePnA78J2MpXf9ocwi1bk1h4qL+RW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496123; c=relaxed/simple; bh=bmyLypJ4CyJtELPnoR5vlTsV9uyh+3EsheliTLhID+w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lR3LugTb8ATOxXV8g4A+fjczUgJO0nw4hM3Erqpf46ve0joCBfUCUsKDBXWPH0mOOXGfQgaeeS+3rpZjL5RkxeThZDulE+i9gt6bsh4c4fh3tPU5zsgttOW129RXjJLt0Utui/qRtmmGk3BeT8Dn3fy6vL9ZWr5CObsV6cd1cFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IGYc6HUI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KkRWLu2Q; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IGYc6HUI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KkRWLu2Q" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6686rQqI2028804 for ; Wed, 8 Jul 2026 07:35:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oETM6ml01wzq58WtJgDwwWqT8UsCDrD5tXaExKvIQJA=; b=IGYc6HUI+AgTxMWR AJ3s9WTaE5GC1W/wcz5qD051LWqxXBxrceqIaPtpUWG0k5tWgIt/Qfkq7Ocbxc6D IeTGzPuHTEedKrXMgkVJHiWEqaFdITXnf4PmlLRSw8xp41cjpq+0AbNEgZW+z2n4 HuQLCQkz8GLo0CvdQyg7pMWrDdpVh5TQ285ziqzgcybtucnmTvVajR3GrLBz3Chm NqIPPVR5YBS+ALWKUyj4J0BDXCgNPrBPuxxSftIRBfogLRIrQ/YsK9WSiEKDTdyl Qj2C2mGvaHkuCg+MegmNCwljLfJLmwucFvcDc+RPFCOXr47wJWC9/Wc7Az4RszMf 7Tp3Wg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9hnv05n6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 07:35:13 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cca5e0a0c9so9074045ad.1 for ; Wed, 08 Jul 2026 00:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783496113; x=1784100913; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oETM6ml01wzq58WtJgDwwWqT8UsCDrD5tXaExKvIQJA=; b=KkRWLu2QHYbqRKQUWpF6kjsnHSo2RGxFFQK8uiLX57RZOM2uZLsYlewtCNnsrQgJKw 4/Mexl4NhvSiePmOXvNMNCXIDLgdLSZktqLrh9OSoNogNzBCd7f0X0slFWx0r+bW0dEr bc6uuPvHcBab8h980ua2pl4G3emnByjJcGk41vyr/LAhABrTkJ74K/EyPZGlsbTLaoFf iBLWL5blCtPGjkNgYc11zwwjnYNRtY2WPb2ApdlptQJopBJiSMeQHqJL6pXONrLd81FS gAcXA6TH/+pRs205crbqI/fVL9ayg2/2anjaFEPARY0v9aJFoPOUwSL+vEoE80W906wo 4HOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783496113; x=1784100913; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oETM6ml01wzq58WtJgDwwWqT8UsCDrD5tXaExKvIQJA=; b=LRthYTVFY1DMmGjMHLnAP9K0wlU3B0nxmmcWASPvB63gP8BxZZ6vSmPmGL3mz65hl+ KezQZR/97HLDEJsnwaFnyKDoZjk+S81sj3fIljK045ujepmdAK26dkPM1B4ABKH6glMv hZ7XBXioaXA5oSi9zlVBphG7mloxYFSGgpbqOUWsA4c5TDxhuyHe7U9Zloz6dXxt+zZx 7EZ/XAn/8qu2YdO73Ve7c1+qp4EXVddrpYxLyQlsFVhjgA2ZhbQiuhY2zj0Iaa+56X88 fc72chRMueBD/E1xBFR6xTagkI1AexyAGeWECoDdjEPj+9BuTlQoih9DFIWQMk2mUnZ4 +DZQ== X-Forwarded-Encrypted: i=1; AHgh+RrfhN0O5dNtK27s6eATn0C8m1jVtFFXU7U7D51OvZQ2asSoijgYdJolhMDl6FwLOxgldJhPaLDR5Th4sJg=@vger.kernel.org X-Gm-Message-State: AOJu0YxAdw3xHozf9lzhmvgzFe+VpbN1lKbcqsvpToeaQNa7UCTe2bha UrCzeQd7Axag15ImMaBd8nUwbd9A0eO0cFQsk/UjTbZG9PclZhqJ+8l8U1hA69os0AMK9cUD1aF E1Lvz7n+3CmLpTOhHXsewa4VS/Tbi0/wc3a7iXbivq4ENJo5hP59rd9FxiEicz7WPrD49+Qy5FE 0= X-Gm-Gg: AfdE7cmir704C4wqkHook0LikSRIyUwLEwalJjloHAd05FPWBoUvwOUqw6yMtAiHOca ouyCV+rBbaa73NKyMlSSVKgmpFpiieNsm5EtxDpdS3DvsQ9Z6fYP2ExJXu7w0YdrVIG7p1XDTuM FfVTFJmd41KgVvVHa3alEmiBVvwDj2V9Bnlwtwpcy746iZ/2uPYK/t25kd0LKLrwYtJO64Sr8OK eOD8uwmkJ0LpLD9VR3Kugb3DMJ9eE3PUIA08IsPauvV6e7aWNEP7/gtb/qz5XFuRTZW8nWQtcKa O8U79OGLHpDJxTFmhiu5tzvoMRqGeTmuG6iLmHSJFlVyR0MXAUBfZ1ZUOo3O8v0APlPsjyaU5WL uOh/zoy5raksGPN8f19aZaKb5j3TmhbGk4Q26e7xHlsVD X-Received: by 2002:a05:6a21:4902:b0:3b4:8717:1c21 with SMTP id adf61e73a8af0-3c0bcbcadf5mr1714164637.35.1783496112792; Wed, 08 Jul 2026 00:35:12 -0700 (PDT) X-Received: by 2002:a05:6a21:4902:b0:3b4:8717:1c21 with SMTP id adf61e73a8af0-3c0bcbcadf5mr1714136637.35.1783496112386; Wed, 08 Jul 2026 00:35:12 -0700 (PDT) Received: from [10.217.219.87] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5b3643399sm2067251a12.22.2026.07.08.00.35.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 00:35:11 -0700 (PDT) Message-ID: <5cf8bf42-8293-4672-b6b2-226ec1acdb56@oss.qualcomm.com> Date: Wed, 8 Jul 2026 13:05:03 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] i2c: qcom-geni: improve transfer error recovery and synchronization To: Praveen Talari , Viken Dadhaniya , Andi Shyti Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Naresh Maramaina References: <20260708-fix_cancel_sequence_on_failure_for_i2c-v1-0-dd8f841f36a2@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260708-fix_cancel_sequence_on_failure_for_i2c-v1-0-dd8f841f36a2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=KNNqylFo c=1 sm=1 tr=0 ts=6a4dfdb1 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=6jiF5cv_vgskca90EcIA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDA3MSBTYWx0ZWRfXz89/L64maogw kUpj0GNgUYi0BGzFSdICHoF97HjZ1jcH5w39BaxnIfq1ZpmBNcWZHVC2SguDwGS3n1wkDfKcc2Y kT5zq5U6c2fC1U/OWz5RGm/DosKtOgI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDA3MSBTYWx0ZWRfX+2Fdl0zm+L/3 z1Tn8TUs9n/mkwZLUXsrfyh1t0o+p9i2O8UbdFP7QNctpfplRHN3bKdBb/u+nlHY13QSj95uOJr p3fD5kUE6+hFtttotR1HI0FlyhmWjvs/RJsDXCayesWjeQFpuoutZ02WJ3txMco1PnKi1SgQRLS /zszwRUd4eKfsRG/Prj2cZpGxaPFNBG2O7smxDFIg0vjPgbjQdqDRj5cuuvLqQM5AXKxgxQaLKM PdFiAODiPKv6zUMLW18qroDj2xQmmCw4cRNpRC5iCaDwEglIXKQfvUABlnHpIiShMB6JkoLZCqD zDmjuXKkbTSopmIAKPc9WzrHKIzZrQf438MMAtbp7/fRmb35sIz6Dvku4KhxYIagk9FiWyVuWgT jx5R3dRo4jLhkdVdhN1sdLsyNcNc+DOL4iDeoWgAFZcSydNkFOLYrkgx3ROdGGJJI47GFq+utLW WiLWy72U8ttS2Ry6V3A== X-Proofpoint-ORIG-GUID: IXHoShI8xSxDKTppArYoOIpaDjaPwvdm X-Proofpoint-GUID: IXHoShI8xSxDKTppArYoOIpaDjaPwvdm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_06,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080071 On 7/8/2026 11:45 AM, Praveen Talari wrote: > The GENI I2C driver currently has a few issues in its transfer recovery has few issues > and completion handling paths. > > The timeout recovery flow directly aborts outstanding commands, while > GENI hardware requires command cancellation to be attempted before > issuing an abort. In addition, multiple operations share a common > completion object, which can allow unrelated events to wake waiters > prematurely and lead to incorrect synchronization. > > Address NACK handling can also trigger unnecessary cancel and reset cancellation and reset operations > operations even though the transfer has already terminated during the > address phase. > > Signed-off-by: Praveen Talari > --- > Praveen Talari (3): > i2c: qcom-geni: use cancel command before abort on transfer timeout > i2c: qcom-geni: use dedicated completions for abort and reset events > i2c: qcom-geni: Avoid unnecessary transfer cancel on address NACK > > drivers/i2c/busses/i2c-qcom-geni.c | 100 ++++++++++++++++++++++++------------- > 1 file changed, 66 insertions(+), 34 deletions(-) > --- > base-commit: 2b763db0c2763d6bf73d7d3e69665222d1f377cf > change-id: 20260703-fix_cancel_sequence_on_failure_for_i2c-a868571f77e0 > > Best regards, > -- > Praveen Talari >