From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753963AbcLLBvx (ORCPT ); Sun, 11 Dec 2016 20:51:53 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:61170 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753805AbcLLBvv (ORCPT ); Sun, 11 Dec 2016 20:51:51 -0500 Subject: Re: [PATCH] firmware: dmi_scan: Always show system identification string To: Ard Biesheuvel References: <1481266447-51471-1-git-send-email-wangkefeng.wang@huawei.com> CC: Jean Delvare , Mark Rutland , "linux-kernel@vger.kernel.org" From: Kefeng Wang Message-ID: <5d02bf23-fe10-53d3-f6b8-d7dc0400637e@huawei.com> Date: Mon, 12 Dec 2016 09:51:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/12/9 22:55, Ard Biesheuvel wrote: > On 9 December 2016 at 06:54, Kefeng Wang wrote: >> Let's keep consistent when print dmi_ids_string between SMBIOS 2.x >> and SMBIOS 3.x, and always show the system identification string, >> like Vendor, Product/Board name and BIOS infos. >> > > Are you saying the printk(KERN_DEBUG) was inconsistent with the > pr_debug() before? Yes, found it when check the boot dmesg on qemu, there is no print using pr_debug with defconfig on ARM64( smbios3 present), but could shown with printk(KERN_DEBUG. > > >> Signed-off-by: Kefeng Wang >> --- >> drivers/firmware/dmi_scan.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c >> index 88bebe1..54be60e 100644 >> --- a/drivers/firmware/dmi_scan.c >> +++ b/drivers/firmware/dmi_scan.c >> @@ -560,7 +560,7 @@ static int __init dmi_present(const u8 *buf) >> dmi_ver >> 16, (dmi_ver >> 8) & 0xFF); >> } >> dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string)); >> - printk(KERN_DEBUG "DMI: %s\n", dmi_ids_string); >> + pr_info("DMI: %s\n", dmi_ids_string); >> return 0; >> } >> } >> @@ -588,7 +588,7 @@ static int __init dmi_smbios3_present(const u8 *buf) >> dmi_ver >> 16, (dmi_ver >> 8) & 0xFF, >> dmi_ver & 0xFF); >> dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string)); >> - pr_debug("DMI: %s\n", dmi_ids_string); >> + pr_info("DMI: %s\n", dmi_ids_string); >> return 0; >> } >> } >> -- >> 1.7.12.4 >> > > . >