From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A1F343D64 for ; Wed, 12 Nov 2025 17:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762968361; cv=none; b=YvuT5WjPi3zMzQwzDgsTFPEYzy7XQNqOt+MpSdWmFeHKM/IlR0E+0uKGdoK7fBDjZVdwG0g9i3Jnak/Zf+b4JkYcXmqKP+ENC6xMQW98ldUfOTgLcvYAY6turSPSCcoD3A2jk+bFxd52EVm20N6hWdMLRD7m3DuvcohCdAe2Gdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762968361; c=relaxed/simple; bh=XNGMKOXdST8ZhXMZ1XSg6lZvEmwXGS/pKQzGBgYFx70=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rW9UbRmcIstx8w+AUxxFImbFwz9I6z3bX5bmAIc/LA49YH5+vrI9ngms9ZUW/7sKvpQsQ1fTvkF26m7OsgQlyWMdNkvRsvmAAmp2Gb44mbwyYH+Zzpq/nBZNttWMtfnHi9Fd/kvWFq6Nr4/Y2PEIBG6DjYFSytR44o+gLdSqhmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Asi0ZCev; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VPr+XK0u; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Asi0ZCev"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VPr+XK0u" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ACGU1PL1001753 for ; Wed, 12 Nov 2025 17:25:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UNBYYgKYBAN8KJ+cgQyzq0Cqs/83MYIWHYqLx/z3jiU=; b=Asi0ZCevWHa5vpUq wydrPJdR5WLStOV9/DGr3VxUXBZoWqa/zgCg8bnQzNA9P0JK7UM6bgsHvINAq854 zqyZM0phZQsfIx6xpL9c1I4p4US+sPxmy/0LcPzRNz9D2woOfqAE8a1U3FutS2mP RSjHFghPfCdr7dcmWvQAi9fP7Ypnxm6uNKEXYRd73cmbxmuQaAo69Ydiy0SH9v76 NqxKeS/lvKq1bbs4S4rTIKuTbicFhnAnjDsLE8ovl9cRz8W1G/30ppmUHADbdWLf HNty7VP9ltQnvlYP2xrXREZ3xHnosdp2Z7YvNYoTWHluPLcq866qz3nVukaBj5zp gc/y5A== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4acqq21g5a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Nov 2025 17:25:58 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-bc0de474d4eso1320064a12.0 for ; Wed, 12 Nov 2025 09:25:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762968357; x=1763573157; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UNBYYgKYBAN8KJ+cgQyzq0Cqs/83MYIWHYqLx/z3jiU=; b=VPr+XK0uTf5TfcbZlZxU4bGPxtQM+zOuCykpoawK/4CvGvxCmJ73VtbEL1tVRaCMbO 0CQC4sBswK1x4f9mK1uRxJn2D8adNRupQhKiyBk+YsU3H6yaD/1X/zSknoGLzJ3rUDtZ jh7/SV8c/EXZHYycBVH6yqO/98j6Jvc+Fnni6HtXg/9xJsniAkqzAh5hJ5VixwHi3KTZ k6c7/nzRwKTMWlzmAog3DZz2W+uWI+APzq6hCkLiGa6Plnkd6FkY1OlzTJ1b2KkL9aUT 53IAb6cZV7LbtNGNiuJL3iCbLxptDqJmh1RyRZYcVZhbsWRuTm5S0E4qg6mDga4i81FD uxOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762968357; x=1763573157; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UNBYYgKYBAN8KJ+cgQyzq0Cqs/83MYIWHYqLx/z3jiU=; b=uCjZvnwUvFd/bk7jYO9wVg9BxSgWmgntHAW8lUhI+pSBmUaSaN96xC7Gcnml0COGPg JQyybpZZkbgSs83l6lCQ79dUIT9wIjFtRcqL2iZbpZjLS3laLLQ3jkr65MIiB9QaOkUl EdQmeiUURGYP4h9g9nqnBfa5zdDh+8BBwieeTkoJwj9iuq4Pl8vofYJ4KJTZ/V7/aRUW u30cbvDnXM35y5fVl6DH591GedO7MNe2qxDWLLZVwkK6IKKZUOF8dEmB0FaoPacdbIzu 0zj34fJn/EBcaQFcS4mo09zpquhY695DhmCXV2KIEVZa4r1nqX5krGkNjsziDWb/YvMb FJ8w== X-Forwarded-Encrypted: i=1; AJvYcCXNTkQL4rvyawoWR2JSEq9i+pEJ3FGiwBxVwAcA4CRTkm1mVATY+d0roCWFmk/gXdQkNrptLjB1Yj82lIw=@vger.kernel.org X-Gm-Message-State: AOJu0YzwQyGjhMZtiPa3dJwRoNBKf2SYcEChHsPUtAFVDLqb9Mfi/8t3 ICL8rQfx9G7jxmswiKhbxVCje4B6cBPt+F3Aew5UdHVFC8aBreePWxK/5lRAj0EKu3HRfb8xCMO ZQHEass82STg4/QqyQ9WH/H7ryUTvrC7RmnHoOngSQUi8/Gn1rgsa+FiVka6iefg9hv8= X-Gm-Gg: ASbGncvrHFs1UTMG7GK/hFdN0nOp0U7jZgegtdbqi70hMC1zGYXuEBQbIY4W6zPetoX zu83KP6Cu9B4pq8V2mvD3kfGqHJ/70Lm7USi7ot0C6Tht0FDbdnuK0ZBvBmShqmDnDmp10vI22m gd3cSMfA7KPq9ndJgFdH2Aly4rVcSNRo4E21+jD0ZTikyXzhYOhpEnb4oFVAVhlK7DsX1tfx5rO Uf0Q1sRW2Kff8vcUAmCsIWCZ2OnwJzZYSBQZhQkupQ5duF40s47hYRnEM1nbIEuBEFL9LuZKbsu fR4ntzLH0slUcbsYjbPmz96HE3+DQH1FImvGcfF/W7TNQKWipHevYWEyZIV7gFkHXCsjiMGuhMs prtl2c6BytirCIc/r63FJR4NangDmS2kJ X-Received: by 2002:a17:903:4b2f:b0:264:70da:7a3b with SMTP id d9443c01a7336-2984edefea2mr49647915ad.49.1762968357056; Wed, 12 Nov 2025 09:25:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlxML53eq5FCGodemREH9wM+Y3YdT+a0wr3azep64CW6zyU6Xwbk8j/OZEoJXgKMwh8FNU/g== X-Received: by 2002:a17:903:4b2f:b0:264:70da:7a3b with SMTP id d9443c01a7336-2984edefea2mr49647545ad.49.1762968356489; Wed, 12 Nov 2025 09:25:56 -0800 (PST) Received: from [10.216.19.73] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2984dcea628sm35957245ad.104.2025.11.12.09.25.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Nov 2025 09:25:56 -0800 (PST) Message-ID: <5d03ea27-82e7-1a55-3441-b80c7496a26b@oss.qualcomm.com> Date: Wed, 12 Nov 2025 22:55:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v17 09/12] arm64: dts: qcom: qcs6490-rb3gen2: Add PSCI SYSTEM_RESET2 types Content-Language: en-US To: Mukesh Ojha , Bjorn Andersson Cc: Bartosz Golaszewski , Sebastian Reichel , Rob Herring , Sudeep Holla , Souvik Chakravarty , Krzysztof Kozlowski , Conor Dooley , Andy Yan , Mark Rutland , Lorenzo Pieralisi , Arnd Bergmann , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Vinod Koul , Catalin Marinas , Will Deacon , Florian Fainelli , Moritz Fischer , John Stultz , Matthias Brugger , Krzysztof Kozlowski , Dmitry Baryshkov , Stephen Boyd , Andre Draszik , Kathiravan Thirumoorthy , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Elliot Berman , Xin Liu , Srinivas Kandagatla , Elliot Berman , Konrad Dybcio References: <20251109-arm-psci-system_reset2-vendor-reboots-v17-0-46e085bca4cc@oss.qualcomm.com> <20251109-arm-psci-system_reset2-vendor-reboots-v17-9-46e085bca4cc@oss.qualcomm.com> <20251110122824.5je5jfoanivl6xrh@hu-mojha-hyd.qualcomm.com> <20251110161950.ngs4ihn3asijoqks@hu-mojha-hyd.qualcomm.com> <20251112111540.w57ygzrvc6m3qbrs@hu-mojha-hyd.qualcomm.com> From: Shivendra Pratap In-Reply-To: <20251112111540.w57ygzrvc6m3qbrs@hu-mojha-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=EbHFgfmC c=1 sm=1 tr=0 ts=6914c326 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=oQ2sxdDcfxKlcFxZ0_oA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: kFLF01ehPQTB0W7Moo0GDVdtBNynQQ0W X-Proofpoint-GUID: kFLF01ehPQTB0W7Moo0GDVdtBNynQQ0W X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTEyMDE0MCBTYWx0ZWRfXzBNI/WdSf9C9 E7O8SLVDczp1KCiD1zSZzQOMiRYEdKhgVnNaSAEwtnHcb8eW5VjZ19pfTKk2knZN/f8hTbsATaQ 2bTYOGP3CH58TrU8cSx3N9vD2F0sWjm9EN87PRwqh/0LO6K/bfeI4+eCLR2zspTY9K92WLDdvtB wJixSXxa1G6A8Sfr+DziWftoryWFnKux7YLawXTx15Ky6+zJe9tAkQcyl+D++E/lUQc7DbpX0EV GsGBN26TP54PhxYZ+a8EK1FLvvoI1x0vmbtJT5tb2EgMV4IvWPG4FN86NYZkKK4Zf4P0PBKwalJ mnskipCAofAZOmjDzZrT4cQYj2cEXU6eDZ68yUNSmGdiJxm2ewCdKFIceJdHzHdktlx7yLv2xDj 4kD878QhFXVug4urSjUCb1MsRx4bog== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-12_05,2025-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511120140 On 11/12/2025 4:45 PM, Mukesh Ojha wrote: > On Tue, Nov 11, 2025 at 10:52:34AM -0600, Bjorn Andersson wrote: >> On Mon, Nov 10, 2025 at 09:49:50PM +0530, Mukesh Ojha wrote: >>> On Mon, Nov 10, 2025 at 09:30:26AM -0600, Bjorn Andersson wrote: >>>> On Mon, Nov 10, 2025 at 05:58:24PM +0530, Mukesh Ojha wrote: >>>>> On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote: >>>>>> From: Elliot Berman >>>>>> >>>>>> Add support for SYSTEM_RESET2 vendor-specific resets in >>>>>> qcs6490-rb3gen2 as reboot-modes. Describe the resets: >>>>>> "bootloader" will cause device to reboot and stop in the >>>>>> bootloader's fastboot mode. "edl" will cause device to reboot >>>>>> into "emergency download mode", which permits loading images via >>>>>> the Firehose protocol. >>>>>> >>>>>> Reviewed-by: Konrad Dybcio >>>>>> Signed-off-by: Elliot Berman >>>>>> Signed-off-by: Shivendra Pratap >>>>>> --- >>>>>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++ >>>>>> 1 file changed, 7 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >>>>>> index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >>>>>> @@ -935,6 +935,13 @@ &pon_resin { >>>>>> status = "okay"; >>>>>> }; >>>>>> >>>>>> +&psci { >>>>>> + reboot-mode { >>>>>> + mode-bootloader = <0x10001 0x2>; >>>>>> + mode-edl = <0 0x1>; >>>>>> + }; >>>>>> +}; >>>>>> + >>>>> >>>>> Make sense for this as it leverages sc7280 and adding it there would not >>>>> have made sense. >>>>> >>>> >>>> Why wouldn't it make sense? >>> >>> It is better to add for platforms we know their firmware support this >>> from day1 and not add for something like chrome or any other variant of >>> sc7280 where this support would never come or not tested. >> >> So SYSTEM_RESET2 only exist in newer firmware versions and hence this >> isn't (and won't be) broadly available in SC7280 devices. >> >> That would be excellent information to put in the commit message, so >> others writing Kodiak dts doesn't feel the urge to copy this and debug >> why it doesn't work. > > Sure, @shivendra please add this information in commit text. Ack. > >> >>>> >>>>> Acked-by: Mukesh Ojha >>>>> >>>> >>>> Please read submitting-patches.rst about Acked-by, and use Reviewed-by >>>> going forward. >>> >>> I was acking the idea of this particular change in platform file compared to >>> other patches, if above reason looks fine, can be converted to R-by. >>> >> >> That's appreciated, but per the documentation, the meaning of acked-by >> is different. > > Sure.. > >> >> Regards, >> Bjorn >> >>>> >>>> Regards, >>>> Bjorn >>>> >>>>>> &qup_uart7_cts { >>>>>> /* >>>>>> * Configure a bias-bus-hold on CTS to lower power >>>>>> >>>>>> -- >>>>>> 2.34.1 >>>>>> >>>>> >>>>> -- >>>>> -Mukesh Ojha >>>>> >>> >>> -- >>> -Mukesh Ojha >