From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [4/7] cpufreq: maple: Checking implementation of maple_cpufreq_init()
Date: Wed, 3 Apr 2019 15:50:44 +0200 [thread overview]
Message-ID: <5d0e8f12-baaa-e4af-f1d2-03e0508e3fd1@web.de> (raw)
In-Reply-To: <1554082674-2049-5-git-send-email-wen.yang99@zte.com.cn>
> @@ -210,7 +210,7 @@ static int __init maple_cpufreq_init(void)
> */
> valp = of_get_property(cpunode, "clock-frequency", NULL);
> if (!valp)
> - return -ENODEV;
> + goto bail_noprops;
> max_freq = (*valp)/1000;
> maple_cpu_freqs[0].frequency = max_freq;
> maple_cpu_freqs[1].frequency = max_freq/2;
* How do you think about use the jump label “put_node” instead?
* Would you like to reduce a bit of duplicate source code at the end
of this function?
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cpufreq/maple-cpufreq.c?id=bf97b82f37c6d90e16de001d0659644c57fa490d#n232
Regards,
Markus
next prev parent reply other threads:[~2019-04-03 13:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 1:37 [PATCH 0/7] fix possible object reference leaks in cpufreq Wen Yang
2019-04-01 1:37 ` [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Wen Yang
2019-04-02 13:54 ` [1/7] cpufreq: ap806: Checking implementation of armada_8k_cpufreq_init() Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-08 10:21 ` [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Viresh Kumar
2019-04-01 1:37 ` [PATCH 2/7] cpufreq: imx6q: " Wen Yang
2019-04-01 1:37 ` [PATCH 3/7] cpufreq: kirkwood: " Wen Yang
2019-04-03 13:17 ` [3/7] " Markus Elfring
2019-04-01 1:37 ` [PATCH 4/7] cpufreq: maple: " Wen Yang
2019-04-03 13:50 ` Markus Elfring [this message]
2019-04-01 1:37 ` [PATCH 5/7] cpufreq/pasemi: " Wen Yang
2019-04-03 14:23 ` [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init() Markus Elfring
2019-04-03 15:31 ` Dan Carpenter
2019-04-01 1:37 ` [PATCH 6/7] cpufreq: pmac32: fix possible object reference leak Wen Yang
2019-04-01 1:37 ` [PATCH 7/7] cpufreq: ppc_cbe: " Wen Yang
2019-04-02 10:43 ` Markus Elfring
2019-04-02 10:50 ` Julia Lawall
2019-04-02 12:50 ` Markus Elfring
2019-04-02 13:15 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d0e8f12-baaa-e4af-f1d2-03e0508e3fd1@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®