From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5C2C2D0A3 for ; Mon, 9 Nov 2020 13:12:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47DF4208FE for ; Mon, 9 Nov 2020 13:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732561AbgKINMQ (ORCPT ); Mon, 9 Nov 2020 08:12:16 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:7437 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732554AbgKINMN (ORCPT ); Mon, 9 Nov 2020 08:12:13 -0500 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CVBGr1K1Jz756Y; Mon, 9 Nov 2020 21:12:04 +0800 (CST) Received: from [10.174.179.62] (10.174.179.62) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Mon, 9 Nov 2020 21:12:03 +0800 Subject: Re: [PATCH] mtd: rawnand: ingenic: remove redundant get_device() in ingenic_ecc_get() To: , , , CC: , , References: <20201031105439.2304211-1-yukuai3@huawei.com> From: "yukuai (C)" Message-ID: <5d14a96d-3815-c485-46e9-3c580d68f1e4@huawei.com> Date: Mon, 9 Nov 2020 21:12:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201031105439.2304211-1-yukuai3@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.62] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping.. On 2020/10/31 18:54, Yu Kuai wrote: > of_find_device_by_node() already takes a reference to the device, and > ingenic_ecc_release() will drop the reference. So, the get_device() in > ingenic_ecc_get() is redundand. > > Fixes: 15de8c6efd0e("mtd: rawnand: ingenic: Separate top-level and SoC specific code") > Signed-off-by: Yu Kuai > --- > drivers/mtd/nand/raw/ingenic/ingenic_ecc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c > index 8e22cd6ec71f..efe0ffe4f1ab 100644 > --- a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c > +++ b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c > @@ -71,8 +71,6 @@ static struct ingenic_ecc *ingenic_ecc_get(struct device_node *np) > if (!pdev || !platform_get_drvdata(pdev)) > return ERR_PTR(-EPROBE_DEFER); > > - get_device(&pdev->dev); > - > ecc = platform_get_drvdata(pdev); > clk_prepare_enable(ecc->clk); > >