From: Chengming Zhou <zhouchengming@bytedance.com>
To: Valentin Schneider <vschneid@redhat.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [External] Re: [PATCH] sched/fair: move nohz definition to where it's used
Date: Tue, 5 Jul 2022 16:02:20 +0800 [thread overview]
Message-ID: <5d1909e6-54bf-5511-74e0-e9c62fcf66c3@bytedance.com> (raw)
In-Reply-To: <xhsmhwncsf15y.mognet@vschneid.remote.csb>
On 2022/7/5 15:50, Valentin Schneider wrote:
> On 23/06/22 21:03, Chengming Zhou wrote:
>> The nohz definition is too far from where it's used, just move it
>> to the right place. No functional change.
>>
>> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
>
> Standalone cosmetic changes are very unlikely to get anywhere, I'd suggest
> bundling this with some other non-cosmetic patches hitting the area.
>
Right, make sense, just minor grumble when review the code, sorry for noise.
Thanks.
prev parent reply other threads:[~2022-07-05 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 13:03 Chengming Zhou
2022-07-05 7:50 ` Valentin Schneider
2022-07-05 8:02 ` Chengming Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d1909e6-54bf-5511-74e0-e9c62fcf66c3@bytedance.com \
--to=zhouchengming@bytedance.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®