From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751286AbdCPGTF (ORCPT ); Thu, 16 Mar 2017 02:19:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:36895 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbdCPGTE (ORCPT ); Thu, 16 Mar 2017 02:19:04 -0400 Subject: Re: [PATCH v4 0/7] Xen transport for 9pfs frontend driver To: Stefano Stabellini , xen-devel@lists.xenproject.org References: Cc: linux-kernel@vger.kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net, v9fs-developer@lists.sourceforge.net, groug@kaod.org From: Juergen Gross Message-ID: <5d250095-b899-2449-6930-a96a0800cfe6@suse.com> Date: Thu, 16 Mar 2017 07:19:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/03/17 20:23, Stefano Stabellini wrote: > Hi all, > > This patch series implements a new transport for 9pfs, aimed at Xen > systems. > > The transport is based on a traditional Xen frontend and backend drivers > pair. This patch series implements the frontend, which typically runs in > a regular unprivileged guest. > > I also sent a series that implements the backend in userspace in QEMU, > which typically runs in Dom0 (but could also run in a another guest). > > The frontend complies to the Xen transport for 9pfs specification > version 1, available here: > > http://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=docs/misc/9pfs.markdown;hb=HEAD > > > Changes in v4: > - code style improvements > - use xenbus_read_unsigned when possible > - do not leak "versions" > - introduce BUILD_BUG_ON > - introduce rwlock to protect the xen_9pfs_devs list > - add review-by > > Changes in v3: > - add full copyright header to trans_xen.c > - rename ring->ring to ring->data > - handle gnttab_grant_foreign_access errors > - remove ring->bytes > - wrap long lines > - add reviewed-by > > Changes in v2: > - use XEN_PAGE_SHIFT instead of PAGE_SHIFT > - remove unnecessary initializations > - fix error paths > - fix memory allocations for 64K kernels > - simplify p9_xen_create and p9_xen_close > - use virt_XXX barriers > - set status = REQ_STATUS_ERROR inside the p9_xen_response loop > - add in-code comments > > > Stefano Stabellini (7): > xen: import new ring macros in ring.h > xen: introduce the header file for the Xen 9pfs transport protocol > xen/9pfs: introduce Xen 9pfs transport driver > xen/9pfs: connect to the backend > xen/9pfs: send requests to the backend > xen/9pfs: receive responses > xen/9pfs: build 9pfs Xen transport driver > > include/xen/interface/io/9pfs.h | 40 ++++ > include/xen/interface/io/ring.h | 131 ++++++++++ > net/9p/Kconfig | 8 + > net/9p/Makefile | 4 + > net/9p/trans_xen.c | 513 ++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 696 insertions(+) > create mode 100644 include/xen/interface/io/9pfs.h > create mode 100644 net/9p/trans_xen.c I strongly recommend running checkpatch.pl to avoid style problems. This will save us some more rounds, I guess: there are multiple style violations in the patches which are not related to the header import from Xen. Juergen