From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754940AbcIALNK (ORCPT ); Thu, 1 Sep 2016 07:13:10 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:57926 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbcIALNH (ORCPT ); Thu, 1 Sep 2016 07:13:07 -0400 X-AuditID: cbfec7f5-f792e6d0000013f5-84-57c80d401a15 Subject: Re: [PATCH v2 01/10] pinctrl: dt-bindings: samsung: Add header with values used for configuration To: Bartlomiej Zolnierkiewicz References: <1472714638-15676-1-git-send-email-k.kozlowski@samsung.com> <1472714638-15676-2-git-send-email-k.kozlowski@samsung.com> <3419428.Xfa2aHQ3xc@amdc1976> Cc: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim , Arnd Bergmann , javier@osg.samsung.com, Linus Walleij From: Krzysztof Kozlowski Message-id: <5d29ca8c-2dfc-4477-9c5c-80254d6ddac4@samsung.com> Date: Thu, 01 Sep 2016 13:13:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <3419428.Xfa2aHQ3xc@amdc1976> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsVy+t/xy7oOvCfCDR7e47H4O+kYu8XGGetZ LeYfOcdq8ebtGiaL1y8MLfofv2a2OH9+A7vFlD/LmSw2Pb7GanF51xw2ixnn9zFZLL1+kcmi de8RdovDb9pZLVbt+sPowO+xZt4aRo/fvyYxeuycdZfdY9OqTjaPO9f2sHlsXlLvsaUfKNS3 ZRWjx+dNcgGcUVw2Kak5mWWpRfp2CVwZ3TcmMhWcF6z4dPo/UwPjbr4uRk4OCQETibX/brNA 2GISF+6tZ+ti5OIQEljKKHGw4xQLhPOMUeLdsaNsIFXCAjkSnze/YAaxRQQsJNaueMsC1/H2 z1uwdmaBi8wSzSfuMoFUsQkYS2xevgSsm1fATuLg4z9g+1gEVCWu7l0HViMqECFxa9VHRoga QYkfk++B1XAKaElsn/sHqJcDaKiexP2LWiBhZgF5ic1r3jJPYBSYhaRjFkLVLCRVCxiZVzGK ppYmFxQnpeca6RUn5haX5qXrJefnbmKExNbXHYxLj1kdYhTgYFTi4XV4cyxciDWxrLgy9xCj BAezkghvNdeJcCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8M3e9DxESSE8sSc1OTS1ILYLJMnFw SjUwHnl78eSZ1EXcpuk8soG7d3Fc3v45NkFnp9l3TyuVrx9vCu9Suvy98X6BZp7dkZq9/sm7 2m+5PjY5WuOVH2zAv8TrguTa4CW2l3Y56P3MYPWc57Oo+fI6BZ6br9lnxN55M//k6s47Es/5 GO1LSjLcZ04/eCtj69RNDwKVmvL2Ndw/Of+Jhq2aiBJLcUaioRZzUXEiAHC9XDypAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2016 01:02 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday, September 01, 2016 09:23:49 AM Krzysztof Kozlowski wrote: >> Hard-coded pinctrl configuration values are scattered through DTS files. >> The numbers are difficult to decode by human, especially without the >> datasheet. Additionally the drive strength differs between Exynos SoC >> families increasing the confusion. >> >> The header will help making this more readable and maintainable. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> MAINTAINERS | 1 + >> include/dt-bindings/pinctrl/samsung.h | 57 +++++++++++++++++++++++++++++++++++ >> 2 files changed, 58 insertions(+) >> create mode 100644 include/dt-bindings/pinctrl/samsung.h >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index d8e81b1dde30..836bcd327ee4 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -9318,6 +9318,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> L: linux-samsung-soc@vger.kernel.org (moderated for non-subscribers) >> S: Maintained >> F: drivers/pinctrl/samsung/ >> +F: include/dt-bindings/pinctrl/samsung.h >> >> PIN CONTROLLER - SINGLE >> M: Tony Lindgren >> diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h >> new file mode 100644 >> index 000000000000..0f410ba5ec7e >> --- /dev/null >> +++ b/include/dt-bindings/pinctrl/samsung.h >> @@ -0,0 +1,57 @@ >> +/* >> + * Samsung's Exynos pinctrl bindings >> + * >> + * Copyright (c) 2016 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * Author: Krzysztof Kozlowski >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> +*/ >> + >> +#ifndef __DT_BINDINGS_PINCTRL_EXYNOS_H__ >> +#define __DT_BINDINGS_PINCTRL_EXYNOS_H__ > > Minor nit: > > shouldn't this be __DT_BINDINGS_PINCTRL_SAMSUNG_H__ (the header file > is named samsung.h and is going to be used also by s3c* SoCs)? Yes, it should. Thanks! Best regards, Krzysztof