From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbaCSSDN (ORCPT ); Wed, 19 Mar 2014 14:03:13 -0400 Received: from mail-by2lp0243.outbound.protection.outlook.com ([207.46.163.243]:14895 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751377AbaCSSDL convert rfc822-to-8bit (ORCPT ); Wed, 19 Mar 2014 14:03:11 -0400 From: "suresh.gupta@freescale.com" To: "gregkh@linuxfoundation.org" CC: "balbi@ti.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id Thread-Topic: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id Thread-Index: AQHPPpdRgmsBtN4byECY9YgUxW/lcprfJAUAgAHdeiCAAGBZgIAGzXhAgAB6fgCAABOuYA== Date: Wed, 19 Mar 2014 18:03:05 +0000 Message-ID: <5d2b00238de54faaa290f375dd55eead@BN1PR03MB251.namprd03.prod.outlook.com> References: <1394719531-27062-1-git-send-email-suresh.gupta@freescale.com> <20140313152628.GI4599@saruman.home> <71f42b215c58414d8bfa7efb968dadbf@BN1PR03MB251.namprd03.prod.outlook.com> <20140315014015.GD31520@saruman.home> <20140319165138.GC27142@kroah.com> In-Reply-To: <20140319165138.GC27142@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [117.205.81.145] x-forefront-prvs: 01559F388D x-forefront-antispam-report: SFV:NSPM;SFS:(10009001)(6009001)(428001)(52604005)(51704005)(24454002)(377454003)(13464003)(199002)(189002)(76482001)(51856001)(54356001)(53806001)(54316002)(56776001)(81542001)(46102001)(81342001)(74502001)(47446002)(31966008)(49866001)(69226001)(47976001)(4396001)(47736001)(93136001)(92566001)(74662001)(81686001)(81816001)(33646001)(97336001)(97186001)(87936001)(56816005)(50986001)(85852003)(85306002)(90146001)(76796001)(87266001)(2656002)(77096001)(83322001)(19580395003)(76786001)(76576001)(83072002)(95666003)(80976001)(19580405001)(94946001)(93516002)(94316002)(95416001)(86362001)(79102001)(74366001)(74706001)(74316001)(74876001)(77982001)(65816001)(66066001)(80022001)(59766001)(63696002)(20776003)(24736002)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR03MB249;H:BN1PR03MB251.namprd03.prod.outlook.com;FPR:375CF15D.A7309C29.1E75F63.415CFA79.20359;MLV:sfv;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ramneek, Do you understand, what Greg want to communicate. Thanks SuresH > -----Original Message----- > From: gregkh@linuxfoundation.org [mailto:gregkh@linuxfoundation.org] > Sent: Wednesday, March 19, 2014 10:22 PM > To: Gupta Suresh-B42813 > Cc: balbi@ti.com; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in > platform device id > > On Wed, Mar 19, 2014 at 02:25:25PM +0000, suresh.gupta@freescale.com > wrote: > > Hi > > > > > -----Original Message----- > > > From: Felipe Balbi [mailto:balbi@ti.com] > > > Sent: Saturday, March 15, 2014 7:10 AM > > > To: Gupta Suresh-B42813 > > > Cc: balbi@ti.com; gregkh@linuxfoundation.org; > > > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in > > > platform device id > > > > > > On Fri, Mar 14, 2014 at 08:52:19PM +0000, suresh.gupta@freescale.com > > > wrote: > > > > Hi, > > > > Thanks for reviewing my patches. > > > > Please find my comments inline > > > > > > > > -----Original Message----- > > > > From: Felipe Balbi [mailto:balbi@ti.com] > > > > Sent: Thursday, March 13, 2014 8:56 PM > > > > To: Gupta Suresh-B42813 > > > > Cc: balbi@ti.com; gregkh@linuxfoundation.org; > > > > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Gupta > > > > Suresh-B42813 > > > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in > > > > platform device id > > > > > > > > On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote: > > > > > From: Suresh Gupta > > > > > > > > > > Add FSL USB Gadget entry in platform device id table > > > > > > > > why this tab ? > > > > [SuresH] I will remove it in next version. > > > > > > > > > Signed-off-by: Suresh Gupta > > > > > --- > > > > > drivers/usb/gadget/fsl_udc_core.c | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/drivers/usb/gadget/fsl_udc_core.c > > > > > b/drivers/usb/gadget/fsl_udc_core.c > > > > > index b7dea4e..35b20e6 100644 > > > > > --- a/drivers/usb/gadget/fsl_udc_core.c > > > > > +++ b/drivers/usb/gadget/fsl_udc_core.c > > > > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id > > > fsl_udc_devtype[] = { > > > > > }, { > > > > > .name = "imx-udc-mx51", > > > > > }, { > > > > > + .name = "fsl-usb2-udc", > > > > > > > > why aren't you just using chipidea ? > > > > [SuresH] This is our legacy driver for all previous and existing > > > > ppc socs. Many of our customers are already using this, and we > > > > need to support them on this driver. We do have plans to shift to > > > > chipidea, but after some time. > > > > > > cool, you already have plans, so we will see a new glue layer for > > > v3.16 right ? Which means I don't need to take this patch either. > > > > > we do have plans, but in remote future. Right now, we need to support > > customers on the present legacy driver. We'll phase out this driver > > slowly when we integrate chipidea. At this time I would request you to > > please accept this patch > > Even if Felipe takes the patch, I'll reject it as you should be doing the > correct thing here, and if it's accepted, it will never be changed... > > greg k-h >