From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f47.google.com (mail-dl1-f47.google.com [74.125.82.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9301133F39C for ; Thu, 29 Jan 2026 16:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769703634; cv=none; b=uuJy/KS5NaPgqS5xvlpuB5F0j22JoHAmeAtEk+H0GDaKvp8q7AJ2cvjvg+viVYwEfCkK6n6R2weTYhRAwHzGVnBcII3MXvbMWVEfp5lFWvke+NMW3arE35Ayed+FEK4FYA7F284PhaSLifz5vTr52Th/XMdK5+tFp6gNjTcOLD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769703634; c=relaxed/simple; bh=EGsRY7aG0zzAYU857y9QMnROLwSVALHkPRes/8MaDSM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=l1LS9VEYblLrOC32RIWV3/lxQ/Xuuh2u0DAgz9IZV7W+XLvMtOSCzQ3njYuLEeLZwOmmp5ckSeGejvtQ/1o/DCE5kuZhYQafpldfsZKQCB4QwLgycSP4YaxqUElscvWtpi8WU6MggPndVfvlqBoP4n5yJOQAfDaEH9o4MZcKdrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=L1mMlLB8; arc=none smtp.client-ip=74.125.82.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="L1mMlLB8" Received: by mail-dl1-f47.google.com with SMTP id a92af1059eb24-124899ee9d3so788719c88.0 for ; Thu, 29 Jan 2026 08:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1769703630; x=1770308430; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=MOn+Bs0qoUGUzxsaUu2YGKwHvxmscu6j9iNcuCgMsM4=; b=L1mMlLB8xCwzeZpeKHkkBH6smX7+6helVTuSQ7qmRxi8GtnAprEhlUW0ci8HNWVFNd z7z83MPNMvDjeaCb1+cO1H0f1MXRZ6vu5Kx3EdPgQ7l39u+90vqOqWR0u8Yy9uNiKdhx QfDhO+GyfpplyoVD9ldqr5WKVAPDChBBko6UhEuk2ZSlo2e9idjOKo4VrNaeOcUaNzCM jyNY+S1Y8qgXjgcaqyuPwDDcApgV9LSazkz26Beg1Jx7l6La5dVzV94v9+dK+JsT/Gc6 9zkP2+6GKx0B6GmzoQp0uor2QNZYq5aZJc0Ifk50S13NL8yM5xFErP3Y8HMLs2z+lU0o Bxsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769703630; x=1770308430; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MOn+Bs0qoUGUzxsaUu2YGKwHvxmscu6j9iNcuCgMsM4=; b=HiKBMrYfp7mqx9b6fHnPEobhffN3id5cVSEFk5OF7nRn7XevYFnYxNMMpImVsak0tp K/3VDS4O5aw7iw2IjmmPw2zKcdOReMxxkGxrk/tCz0Riw23BJISDBMrAbRpGr1aM7wBL YlhtbKfHkXY5WZrJ4YCPcMkf1E/o/KUA8TuzQcn41cCO1N2tlP/loaLKy/AN8/H/EdRv Dv/NaVu5Ee5sksAmblEzP54dBnZ5sAztRPlX777D7lcGwg8goWNfzA5I0xZior46eKsb KAeSh3mnUnSv2YCx9RnqgisHR02IUMe4SfQgEUuI8IyP6n1giqFvIbWqFDNb7QCoQ6u6 ZGog== X-Forwarded-Encrypted: i=1; AJvYcCX6WSnI4EciNU5IcZ63P8WiWTOiUOXQ6NOimo03xBAk55kMmyzgx2TWoqILhnAKh1f81st3E02Rfnn1nqw=@vger.kernel.org X-Gm-Message-State: AOJu0Yybdr5zIKut3P/uyX7uNt8XseShabaQNRhUpt0sFJyJ4EfF8rbf YhZPVPPss3ZlzwAcIaXfRxoUpW9wECJH3nmsaULe1TwJDdb/ErV5wpk3N/XtKUs6w6g= X-Gm-Gg: AZuq6aJ7KW4eV5J2loG97RmBGJWeBfYTc1jiwJiBuM1z9bzdRryXG3RMHTcMIvNtmta 4snGBwDLdzeO0zSfluF+ljJlqKAgQDpLe7QYhSu8IlldgIxWeGGTvF9oAAjz4h5hgerTkcgxglr x5egk9ETFRxJ09OPXNm6l/XE3EmDWDhLqhXhtza8ZW6c7CZHA4yHgaHEe4yw0S8agbvKQgk1EGy FatYg2CpmuD5zhJ5b3kkHKXDSXd3VoULYE9qcLWvpU4FvDxRBdJWanOsu2AxFQc8V0ZkqXlXLVV Qkc72bJUiAVeSVpba+FU5kve5DXo6yt8Zu0V76mz47NXt1jL94o0Eea1RDlEpMP9SW2lzfYbGo0 5eJtGZSUin3bszeTxuWcy8dv+Oo7HQwFljXQ8m+5XprUdc1pj9dBp4DSrtGxkSgAB1vwLFCbv16 jz8Xy6VSI9s3YLV/wYJa0odacqMTgyV+wiVYLf2qK+MVmViB56lofvxqWPdPYg X-Received: by 2002:a05:7022:220d:b0:123:331f:978f with SMTP id a92af1059eb24-124b101ee64mr1698024c88.7.1769703629586; Thu, 29 Jan 2026 08:20:29 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:eca6:912e:45a4:4837? ([2600:8803:e7e4:500:eca6:912e:45a4:4837]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9d6b663sm6740743c88.1.2026.01.29.08.20.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 08:20:29 -0800 (PST) Message-ID: <5d2e85cd-caa2-43a6-a451-3b822bd0ef01@baylibre.com> Date: Thu, 29 Jan 2026 10:20:27 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ad4080: add AD4880 support To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260129152731.154368-1-antoniu.miclaus@analog.com> <20260129152731.154368-2-antoniu.miclaus@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260129152731.154368-2-antoniu.miclaus@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/29/26 9:27 AM, Antoniu Miclaus wrote: > Add AD4880 dual-channel ADC to the AD4080 bindings. The AD4880 is a > dual-channel variant with two independent ADC channels, each with its > own SPI configuration interface. > > For AD4880, the binding requires: > - adi,aux-spi-cs property for secondary channel chip select > - Two io-backends entries for each channel's data interface > > Signed-off-by: Antoniu Miclaus > --- > .../bindings/iio/adc/adi,ad4080.yaml | 49 ++++++++++++++++++- > 1 file changed, 48 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml > index ccd6a0ac1539..3909e3095507 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml > @@ -18,6 +18,9 @@ description: | > service a wide variety of precision, wide bandwidth data acquisition > applications. > > + The AD4880 is a dual-channel variant with two independent ADC channels, > + each with its own SPI configuration interface. > + > https://www.analog.com/media/en/technical-documentation/data-sheets/ad4080.pdf Can we get a datasheet link? > > $ref: /schemas/spi/spi-peripheral-props.yaml# > @@ -31,10 +34,18 @@ properties: > - adi,ad4084 > - adi,ad4086 > - adi,ad4087 > + - adi,ad4880 > > reg: > maxItems: 1 > > + adi,aux-spi-cs: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Chip select for the auxiliary SPI interface used by multi-channel > + devices like AD4880. Each additional channel beyond the first requires > + its own SPI configuration interface on a separate chip select. > + > spi-max-frequency: > description: Configuration of the SPI bus. > maximum: 50000000 > @@ -57,7 +68,8 @@ properties: > vrefin-supply: true > > io-backends: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > > adi,lvds-cnv-enable: > description: Enable the LVDS signal type on the CNV pin. Default is CMOS. > @@ -78,6 +90,23 @@ required: > - vdd33-supply > - vrefin-supply > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: adi,ad4880 > + then: > + properties: > + io-backends: > + minItems: 2 > + required: > + - adi,aux-spi-cs > + else: > + properties: > + io-backends: > + maxItems: 1 > + > additionalProperties: false > > examples: > @@ -98,4 +127,22 @@ examples: > io-backends = <&iio_backend>; > }; > }; > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@0 { > + compatible = "adi,ad4880"; > + reg = <0>; > + adi,aux-spi-cs = <1>; We can already have multiple reg for a multiple CS device. reg = <0>, <1>; So we shouldn't need a new adi,aux-spi-cs property for that. > + spi-max-frequency = <10000000>; > + vdd33-supply = <&vdd33>; > + vddldo-supply = <&vddldo>; > + vrefin-supply = <&vrefin>; > + clocks = <&cnv>; > + clock-names = "cnv"; > + io-backends = <&iio_backend_cha>, <&iio_backend_chb>; > + }; > + }; > ...