From: John Garry <john.garry@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <namhyung@kernel.org>,
<ak@linux.intel.com>, <wcohen@redhat.com>, <will.deacon@arm.com>,
<ganapatrao.kulkarni@cavium.com>, <catalin.marinas@arm.com>,
<mark.rutland@arm.com>, <xuwei5@hisilicon.com>,
<linuxarm@huawei.com>, <zhangshaokun@hisilicon.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/5] perf jevents: add support for arch recommended events
Date: Fri, 15 Dec 2017 11:22:50 +0000 [thread overview]
Message-ID: <5d322353-2785-a99f-bcd8-b948bd6cb09a@huawei.com> (raw)
In-Reply-To: <20171209073104.GB14297@krava>
>> Actually having a scalable JSON standard format for pmu events, which allows
>> us to define common events per architecture / vendor and reference them per
>> platform JSON could be useful.
>>
>> Here we're dealing with trade-off between duplication (simplicity) vs
>> complexity (or over-engineering).
>
> understood, but as I said we already are ok with duplicates,
> if it's reasonable size as is for x86 now.. how much amount
> are we talking about for arm?
>
Hi Jirka,
When you say reasonable size for x86, I ran a string duplication finder
on the x86 JSONs and the results show a huge amount of duplication.
Please check this:
https://gist.githubusercontent.com/johnpgarry/68bc87e823ae2ce0f7b475b4e55e5795/raw/f4cea138999d8b34151b9586d733592e01774d7a/x86%2520JSON%2520duplication
Extract:
"Found a 65 line (311 tokens) duplication in the following files:
Starting at line 100 of
/linux/tools/perf/pmu-events/arch/x86/ivybridge/ivb-metrics.json
Starting at line 100 of
/linux/tools/perf/pmu-events/arch/x86/ivytown/ivt-metrics.json
Starting at line 100 of
/linux/tools/perf/pmu-events/arch/x86/broadwell/bdw-metrics.json
Starting at line 100 of
/linux/tools/perf/pmu-events/arch/x86/skylakex/skx-metrics.json
Starting at line 76 of
/linux/tools/perf/pmu-events/arch/x86/jaketown/jkt-metrics.json
Starting at line 100 of
/linux/tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json
Starting at line 76 of
/linux/tools/perf/pmu-events/arch/x86/sandybridge/snb-metrics.json
Starting at line 100 of
/linux/tools/perf/pmu-events/arch/x86/broadwellx/bdx-metrics.json"
Won't this all potentially have a big maintainence cost?
For example, I saw multiple JSON update patches which look identical:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/tools/perf/pmu-events/arch/x86?h=v4.15-rc3&id=7347bba5552f479d4292ffd008d18d41a965f021
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/tools/perf/pmu-events/arch/x86?h=v4.15-rc3&id=984d91f4c62f64026cbfef51f609971025934cec
I just don't know how this schema scales with more archs and more
platforms supported. It's just early days now...
Regards,
John
> jirka
>
> .
>
next prev parent reply other threads:[~2017-12-15 11:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 16:13 [RFC PATCH 0/5] perf events patches for improved ARM64 support John Garry
2017-12-05 16:13 ` [RFC PATCH 1/5] perf jevents: add support for pmu events vendor subdirectory John Garry
2017-12-06 13:38 ` Jiri Olsa
2017-12-06 14:41 ` John Garry
2017-12-05 16:13 ` [RFC PATCH 2/5] perf jevents: add support for arch recommended events John Garry
2017-12-05 17:27 ` Andi Kleen
2017-12-06 8:34 ` John Garry
2017-12-06 13:36 ` Jiri Olsa
2017-12-06 15:20 ` John Garry
2017-12-08 12:29 ` Jiri Olsa
2017-12-08 15:42 ` John Garry
2017-12-09 7:31 ` Jiri Olsa
2017-12-11 10:25 ` John Garry
2017-12-15 11:22 ` John Garry [this message]
2017-12-16 18:47 ` Andi Kleen
2018-01-02 12:07 ` John Garry
2018-01-02 17:48 ` Andi Kleen
2018-01-03 12:22 ` John Garry
2017-12-21 19:39 ` Jiri Olsa
2018-01-04 17:17 ` John Garry
2018-01-08 14:08 ` Jiri Olsa
2017-12-06 13:37 ` Jiri Olsa
2017-12-06 14:40 ` John Garry
2017-12-08 12:31 ` Jiri Olsa
2017-12-08 15:38 ` John Garry
2017-12-09 7:26 ` Jiri Olsa
2017-12-05 16:13 ` [RFC PATCH 3/5] perf vendor events arm64: add armv8 recommended events JSON John Garry
2017-12-05 16:13 ` [RFC PATCH 4/5] perf vendor events arm64: relocate thunderx2 JSON John Garry
2017-12-05 16:13 ` [RFC PATCH 5/5] perf vendor events arm64: add HiSilicon hip08 JSON John Garry
2017-12-06 16:42 ` [RFC PATCH 0/5] perf events patches for improved ARM64 support William Cohen
2017-12-06 17:35 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d322353-2785-a99f-bcd8-b948bd6cb09a@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=ganapatrao.kulkarni@cavium.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wcohen@redhat.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®