From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 935ABC4363D for ; Tue, 22 Sep 2020 05:54:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FB9C23A9C for ; Tue, 22 Sep 2020 05:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600754085; bh=qinHNa98lV8Vbex+es8YwI6s9Zh4TPeJErHxYKfr41E=; h=Subject:From:To:Date:In-Reply-To:References:List-ID:From; b=eqOkBaELk9t/KHkdg+xFPum6jBXiaRfNz0BKKoKDZWmy5gm/iFk0HdqBSeEXSP88j tnG7vVCndV/kxmgRHxxTa4Djl9Dh9FFoCqdX3wn7e+rFj+JJ0W8N4gIsqJKohzPqd9 N7b7Mg8UOqCMsQBwsIGQy6M96MoEcP8H/hakvMWc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729137AbgIVFyo (ORCPT ); Tue, 22 Sep 2020 01:54:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:53424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726488AbgIVFyn (ORCPT ); Tue, 22 Sep 2020 01:54:43 -0400 Received: from lt-jalone-7480.mtl.com (c-24-6-56-119.hsd1.ca.comcast.net [24.6.56.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CAD9623A9B; Tue, 22 Sep 2020 05:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600754083; bh=qinHNa98lV8Vbex+es8YwI6s9Zh4TPeJErHxYKfr41E=; h=Subject:From:To:Date:In-Reply-To:References:From; b=pjDKcZ4OtrGP7QNOPqlZ9fFJkM46FuvH3PMLX316DxHEfz9GAJ4Xy3XH0eiyxKr7k Jw/Ox28kvFvFlwen7/ZVA0Z65qOZpRrxGtuP3qXHg190hWVU7Dzh1K/B76XFYhsZ2K VDT6Lma3m2A+ebXtOiAjZ1rg7HgurHBoKlFHlp9c= Message-ID: <5d37fdcb0d50d79f93e8cdb31cb3f182548ffcc1.camel@kernel.org> Subject: Re: [PATCH] net/mlx5: remove unreachable return From: Saeed Mahameed To: Pavel Machek , eranbe@mellanox.com, lariel@mellanox.com, saeedm@mellanox.com, leon@kernel.org, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 21 Sep 2020 22:54:41 -0700 In-Reply-To: <20200921114103.GA21071@duo.ucw.cz> References: <20200921114103.GA21071@duo.ucw.cz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-09-21 at 13:41 +0200, Pavel Machek wrote: > The last return statement is unreachable code. I'm not sure if it > will > provoke any warnings, but it looks ugly. > > Signed-off-by: Pavel Machek (CIP) > > Applied to net-next-mlx5. Thanks, Saeed.