From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5AD443B6FA for ; Wed, 8 Jul 2026 12:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783512742; cv=none; b=izDZjzLbFhR7l7z0/YYZBMjBEQEkan4Zvfjz+v1K1JE6b0qGIj6K59pMFvhQDnW6+/XM2xZup+zzN0yXN2vakaTEkHBEnVsP2C1UWo3YOSPTOR7gKw9ioOCMxmB2OSf1zRLzVWpg8DWuLJGMEo7fdI1SXK4hvUO8WG09rQNpWdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783512742; c=relaxed/simple; bh=QDWu4O8I5KOVgg1UuqQFKZb6pS9L+NuXj96Vv9RNZaQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=skHggO7YkmuzuwL2ZOwvLhsObxakCBQwBNoQJ2Uckkkvau4YAGy4CYiVwaaEisUiOdD0jeRrJXYja0iVoPhHl+i47Sa/DfV2thud9GVtWeOMu5w0pZrOyD7wJllgP6rEgHSniIJ1DqMGO5uzdo8/TBdFmYkP1CmMJAoqyjF9lt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ja9AnmOD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bvwbrRo9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ja9AnmOD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bvwbrRo9" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668C3D032792090 for ; Wed, 8 Jul 2026 12:12:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= x99srZ1k83NBw3X7LSFItZj86d9NxG5WKDanacpAupc=; b=ja9AnmODhXlEoMTF FNwz0QJU2GPyndpnLM5SOP90Nk3EdQtqJDdrafXJpQ7j9YWqpO6cdBHiMnWWJkku ppjEAKg3MCFnwrs9JTU5KgYfysEys/pj6JtdQS68qM2z8PI7szix+pzphtpajJqI sn6KOMFkKvAdzMWI2sx67/Qf8qzYR04+SYlPcwBd+SyJc/yPFe5U1O8ZsKLhbZX9 mBpu1M+aj7jwNb7551K4q9RQxcCMDVOphoq6TbeWTa4C1LaPMkHVN5LpTr5Qv15G 5Mhzv3VccFehIBZDmdLJvlxH/zQ3N4jCE25+aUDAMo0QagIt1pI4E6XKA//p/aDP f5upfw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9cswa9fy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 12:12:20 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c267931ebso3513501cf.2 for ; Wed, 08 Jul 2026 05:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783512739; x=1784117539; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=x99srZ1k83NBw3X7LSFItZj86d9NxG5WKDanacpAupc=; b=bvwbrRo9nEBUJ8vWCQRFAxjRiSl5HPAvGncc8EqJY+sY20aSo2IKBApFl8+wM1kjZI kC0kw0+5Tl/XPt4G3U04DEYCQM6dWGvNIuRQARVhqw50qnCfteu7jWKaC0owTVqQRikZ 1n+zDPechTYyLh36k6wBDH8Ovd6ZlcuerG4AEKt3ijY6WOcEsccqIfMUZwuKSlnVpVEU PjHtHQXNTc74qd70CXLuNJUX0b0fMOqbWJEkytSF578Fzd+ryB75Z+d23EHMyJhPpD1J iAM7pl/SraWLEvmzNn8AvJ1mTCHxbjpwtMwuC8CcXaGL0J9jeKNu8T9pPPaE3LVfOJap bnww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783512739; x=1784117539; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=x99srZ1k83NBw3X7LSFItZj86d9NxG5WKDanacpAupc=; b=aRJe0+OnzKhQkD8OI8EPnIdr3wzbJLAMAen6IEFA7Rf0C6v0DqdpsrT5sem6Js43Pt AY8SpzIGHhmmElBxklc93DdaF+D8/zEfAIef/Hm/jDAsbPT3hBFBXbbNSH4SVomOZZiR Unf723L1IYolCCjJsrgiCbJp0B71oSIzlk5IlvjMbYNTSnhXfmGynCDsACGdGPYNt7K0 SigC75+8zbNuqN0u/Tc56Km/T3RomffrRy0c2KJ1CIK7V7PAHhBX8BrBIJZXQNIwOkV+ tKA1yb2KdEIzHzuyi9aDjgAQRVNuJuAywUpc+huSJpd8gz/IPgU8uh4BRR+pYySSyRRb eNtA== X-Forwarded-Encrypted: i=1; AHgh+RrBU0IpPnTLjXsbgjnmown/ZCUrcaQx2uAWBomi2d4YVf+v8nXSEAfpRMaVpNVfpjLOw/m/4KN4qp8xikQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yya7ZIPxCl0Lue9aHIfVy+tzLIL8u5/juJJGWCE2ru70WSbYAMy lBM0R3nBHZYnPrU8lGVa7gFP9pweUzVn1YXdU5TretmGfhncbzbDfmTTgw7bnvRXVpwlYIqcpGm swNOgSvfxTWFwxJEwO8M8tL6Rt6rAPMBgDknrlQlgZFJR4nhmEjRCskCGs/NXLukJXHrMy8etRX w= X-Gm-Gg: AfdE7clIDpQ3pPgwa3enJ/V0TAlF9CGn8jn5ZRTBmDy7Y7JkouzoGd6wClPsPl2fvlJ S/mdo1ZA8cmnojLQvgybth0VVswF3WHsD1QBbiI6S15ZyQnljG9KeXjpr0WF8SBmjiMXj7U8pcW mTah4Gq31DRXckyay6TKe+/GOg8vfO2jC4TOZSXH9VGab1U9UQgWfavovoKBuIj7yZg6oFZCoIV +Rz9ad8QaAgmbakQS5QxCrZIQVfekz2AXE3noYLserLvn/mu4rVPSw4ueGk75iEPZpg9nBnblME H9hKc5Ww0AVWXXMImKtaCfUptnsPmFbYc4usyb2ZT3bsjyeNVf1kcyKoP2jFFDDk3wIjUU/zHpx F9KRi3mHbE0n/zz19Op2oAMKVVBhFcuQfgk8= X-Received: by 2002:a05:622a:110d:b0:51a:8d32:f796 with SMTP id d75a77b69052e-51c8b2712camr17779201cf.0.1783512738984; Wed, 08 Jul 2026 05:12:18 -0700 (PDT) X-Received: by 2002:a05:622a:110d:b0:51a:8d32:f796 with SMTP id d75a77b69052e-51c8b2712camr17778871cf.0.1783512738409; Wed, 08 Jul 2026 05:12:18 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69aa6dba523sm1965138a12.0.2026.07.08.05.12.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 05:12:17 -0700 (PDT) Message-ID: <5d46c46b-1f58-487c-a883-bfb8ea356035@oss.qualcomm.com> Date: Wed, 8 Jul 2026 14:12:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: eliza-cqs-evk: Enable sound card support with WSA8845 and DMIC To: Ravi Hothi , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com, ajay.nandam@oss.qualcomm.com References: <20260703083421.2736184-1-ravi.hothi@oss.qualcomm.com> <20260703083421.2736184-3-ravi.hothi@oss.qualcomm.com> <059f8b92-6df0-4439-b3ff-1a270b5ee1b7@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <059f8b92-6df0-4439-b3ff-1a270b5ee1b7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: jQb-fFCeed9i6pgGuNkQjzIPdh9cAiy9 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDExNyBTYWx0ZWRfX30TWP1IBEvfA 00p2ah+ahNkmGjD5WVFZ7/INESRsYfrNKk3v983IGC1KatGUaQAOCO9HHh0qAhGmUypEx++dTKn mmYM2nKP2t06xuNcCc1ZoM8MTG/YP+U= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDExNyBTYWx0ZWRfXx2x9Qrg/Ccm4 wlrQd2RXYaAttqQBC/RHHPvuTVQl3OZG/tXT8p4d+lnjAX05ky7v1EI1RUcI1XuaUmXxLcq8pq4 Ier+YXa7Fnw+6BhF/jTmj1d4GIbl/sGzarFl5Wt9pd7RBaUTiTnderMlfUgVmUZWFk+YmeQGi/I 76NkKp9vvr+LXeJ9TCZpqkGwyqrwSbtKFHtes2gMl7C0JnTpv0jc6KzySk9rtEsCfzqsRpzzJ3G KGufmJC7zzTeRupmeaSrwEN/Z36lXaw5V04FOf4haUznwuvRwQ9KmFHQ/gOHCzjonIPEXoOC395 msYqbSUJpFg2gZATUsU8Gauc3CI5emKn9Crq4NUGrccg5+ExQwUPLhc3ymfIJsaDp+bBpeAW3+x 02/BahY0OuSus4JDbIDCcYSnzeUxZonLkj2Z5EPoZ4D39q6IdaKsTo9a9JOnUOaBrZvo04wU09N sZTcuC6Pe44ZYbg9J/g== X-Authority-Analysis: v=2.4 cv=HaYkiCE8 c=1 sm=1 tr=0 ts=6a4e3ea4 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=QKulUWdV5NHAk1IIq1IA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: jQb-fFCeed9i6pgGuNkQjzIPdh9cAiy9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_02,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080117 On 7/8/26 1:27 PM, Ravi Hothi wrote: > > > On 7/7/2026 2:11 PM, Konrad Dybcio wrote: >> On 7/1/26 7:43 PM, Ravi Hothi wrote: >>> Enable the sound card on the Eliza CQS EVK platform, including the >>> WSA8845 external speaker path and DMIC microphone capture via VA macro. >>> >>> Enable the required LPASS WSA macro, VA macro and SoundWire controller >>> along with the necessary pinctrl configurations for DMIC and WSA >>> SoundWire interfaces. >>> >>> Signed-off-by: Ravi Hothi >>> --- [...] >>> +&pm7550_gpios { >>> +    dmic-eldo-en-hog { >>> +        gpio-hog; >>> +        gpios = <7 GPIO_ACTIVE_HIGH>; >>> +        output-high; >>> +        line-name = "dmic-eldo-en"; >>> +    }; >> >> Why add a hog if you defined the regulator already? >> >> Konrad >> > > The gpio-hog is the mechanism that actually drives PM7550 GPIO8 high at boot to enable the ELDO hardware. This GPIO enable is required to enable the ELDO regulator which is powering the MIC BIAS supply. > The regulator-fixed driver with empty fixed_voltage_ops has no .enable()/.disable() callbacks — it cannot toggle the GPIO. The dmic_eldo regulator node is needed to correctly describe the supply chain to the VA macro driver (vdd-micb-supply) and for power tracking, but it cannot control the GPIO itself. Both are needed for different purposes. Well, why do you think the binding would accept the GPIO if it couldn't be controlled? Of course it can power it on/off, check regulator core code Konrad