From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D35C0438FEE for ; Fri, 15 May 2026 09:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778838183; cv=none; b=IDX6zG+uzUgOleZYKMeruQ4a8cUNB53n9nJiGBuMLLtUsPT/TzEUDmEcBhvgnj0sdp7v+VxrJ5yRkCN1X978nbPH6A0415wJIIcBKACtib7VVMJ5pEuDojfjoi2Pg/O2sgukc7Ot+rm2YmrvZsH6eGWr7wmgr1iBR3O49kzkH5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778838183; c=relaxed/simple; bh=EU+HmJT6nnrW+H8x6Cnl4CrlEA7rDTKbZqUrmoYkGSI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LBb5bok+jRS4np8DpTkmKGMMyrL53F5mYwh8MvyP70vwGax5IPkMdo5snM+DvsNbN8VP69dGX6lExGL2rMIAokV4UdqTVdoIdiA1EkL+oqygo/r6CAjBpL3emen7a4QyCzSrljJDDnRNB7zZJY3Bi4j4XzX+pd+EJpQJIZCcPh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ky5v5luO; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ky5v5luO" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48e8132c6d0so45185535e9.1 for ; Fri, 15 May 2026 02:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778838179; x=1779442979; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SVDGicVJg59XTncijfQC7XsfDc3wPf8gJrlfL/wbLsg=; b=ky5v5luOR6Z+r7B5K49YoovWpN8lfcX1hhNBr/YluhS10Ine9Yb5ehwd3l/3c2wxbQ NZurzrcBYCFs+66FSqX6tazSj4f+D/DXw7khkITJd0Hz8FwtBP10CB+j9y0EABAVOgEt F054QqgmNZ3yycBdg2voToyd93okhfm3+g7ORRRdhDPFsj8dbXO7N475h3kbFBumKbnX n7aDTFrE6wavnx034IyHxyuFJwWgSDmYPIB9PqlsaVJ7bALyzIZEdPwbg2MzqntEaPM+ lQ03C9RmMfa2D7TK4X9rMDCMl9F0h0RaKzD6wY53ocf4+gxXLFSlhFO8A558MNj8Hi8i SKFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778838179; x=1779442979; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SVDGicVJg59XTncijfQC7XsfDc3wPf8gJrlfL/wbLsg=; b=tNGgZuxkthKonIUmyc/qYNhqtaocrX5BHVARWsZ0zvrmWw3jfQBOSTmYDG+HnBCXag 2/aQSj+M02CaxMJbXwjcEsSWgLBTcaDUBoEbNzwoF2GUxtNH6H4EPfhxDZNdEXSTuiKD DzZrPHvdATMQWhKXdHsB5kYUHiGyXRSZpNbHsDb+59ZVEQ3BmQ12hNqH7465FI3LvN7l x0yOa4JdzdLIbx79xUM2dlpWXP9Qp/mHeDq1v+U3oIfnN1Ks23KHDUPZ4mh5W2vOQCbs QBv09NQjWe2MRZ6BxiMg8ut6flXPO2/+9lPUjv2ULAcUcmx5HFqjoVdIcBxrHGWN0bG8 4Ubw== X-Forwarded-Encrypted: i=1; AFNElJ9VTNt1nS2Q2Jqwo9JGGb2T24Xh5xb9UW5RIBDWK9AQBK/ssjLRUFpzMbMFN2td4I0Eh0P9ZTS1/XNQ9vk=@vger.kernel.org X-Gm-Message-State: AOJu0YysWyOlytsut1GDB+94JDZzq6hDuwUP9DGfX3qEKfLGZDGi6M1+ 4t1rlqCXr7J71fM2apezwyXin7jO3BphbqkjVxxKTg3Xr4XP4hcxPffxRdXNnEGIIF4= X-Gm-Gg: Acq92OFQLP8a1ugIQtTKPv7MVTsItlA5shK9ufpYo4Vu44kbxscUUnVFs/pnnA/Ao4y P/aYiPRAVHc672u3jeZlTjCHyaV2Mom9qEbT+nZ9a3U0C+4uHRsjO5qNPB6nKx+wxrOeVRM/hdX 5b2saD3PJ/68rJNIJjWEhJdLppC6636gMNOg5haAfGtnvlMVP/BWnAocXhINqVnWM6VvDFgM8jB BCTGmzD3s5p84nC0P8jexBWSXcid/AJMgDuWN+H9gP/YW+/x1gIL2taX4S8ejDsvfg7vLLxwieR qwa7i2+ky4oI9SrjTVb9xN3/NkWg0riun8Ke31myiIkW8397IkJgX6xa7R8NDJyRte5ZiA6nzPr kLemTOqA/4bYOGr/ZamV0ahb6pm8ZJreQl2UQ4mKy3BowJFjEwPyzJMnWljPM8FKjC5J4hXbZfO lS6wSFxM2EEsn2nED2GkhgrbFOiF2My9mTAU4= X-Received: by 2002:a05:600c:34c7:b0:48a:54fd:54ea with SMTP id 5b1f17b1804b1-48fe60ecd93mr47471195e9.12.1778838179190; Fri, 15 May 2026 02:42:59 -0700 (PDT) Received: from [192.168.0.35] ([109.76.168.101]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe248dsm12825790f8f.30.2026.05.15.02.42.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 02:42:58 -0700 (PDT) Message-ID: <5d4fd84d-59e2-48c1-9982-0c3ad932bd15@linaro.org> Date: Fri, 15 May 2026 10:42:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats To: Neil Armstrong , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org> <0boIejkDZLA5Kw9uSWxeZX3GforfnPgAo7E27fY_Nnp4VjgHo8d9b70ojS2zrG-xk4dDT__EyunCPPEgJh1Niw==@protonmail.internalid> <20260511-topic-sm8x50-iris-10bit-decoding-v3-5-7fc049b93042@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20260511-topic-sm8x50-iris-10bit-decoding-v3-5-7fc049b93042@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/05/2026 10:20, Neil Armstrong wrote: > The 10bit pixel format can be only used when the decoder identifies the > stream as decoding into 10bit pixel format buffers, so update the > find_format helper to filter the formats and only allow the proper > formats when setting or trying a capture format. > > Signed-off-by: Neil Armstrong > --- > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 + > drivers/media/platform/qcom/iris/iris_vdec.c | 10 ++++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index 5a489917580e..cd3509da4b75 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -18,6 +18,7 @@ struct iris_inst; > > #define REGISTER_BIT_DEPTH(luma, chroma) ((luma) << 16 | (chroma)) > #define BIT_DEPTH_8 REGISTER_BIT_DEPTH(8, 8) > +#define BIT_DEPTH_10 REGISTER_BIT_DEPTH(10, 10) > #define CODED_FRAMES_PROGRESSIVE 0x0 > #define DEFAULT_MAX_HOST_BUF_COUNT 64 > #define DEFAULT_MAX_HOST_BURST_BUF_COUNT 256 > diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c > index eea69f937147..f4d9951ed04c 100644 > --- a/drivers/media/platform/qcom/iris/iris_vdec.c > +++ b/drivers/media/platform/qcom/iris/iris_vdec.c > @@ -99,6 +99,16 @@ find_format(struct iris_inst *inst, u32 pixfmt, u32 type) > if (i == size || fmt[i].type != type) > return NULL; > > + if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) { > + if (iris_fmt_is_8bit(fmt[i].pixfmt) && > + inst->fw_caps[BIT_DEPTH].value == BIT_DEPTH_10) > + return NULL; > + > + if (iris_fmt_is_10bit(fmt[i].pixfmt) && > + inst->fw_caps[BIT_DEPTH].value != BIT_DEPTH_10) > + return NULL; > + } > + > return &fmt[i]; > } > > > -- > 2.34.1 > Reviewed-by: Bryan O'Donoghue