mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Arunpravin.PaneerSelvam@amd.com, "Prosyak,
	Vitaly" <Vitaly.Prosyak@amd.com>,
	"Sharma, Shashank" <Shashank.Sharma@amd.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Felix.Kuehling@amd.com, daniel@ffwll.ch, airlied@gmail.com,
	Xinhui.Pan@amd.com, christian.koenig@amd.com,
	alexander.deucher@amd.com
Subject: Re: [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list_create()
Date: Mon, 21 Aug 2023 13:03:46 +0200	[thread overview]
Message-ID: <5d52550a-92a1-55e7-69ad-92f18330ff48@amd.com> (raw)
In-Reply-To: <cover.1692524665.git.christophe.jaillet@wanadoo.fr>

Am 20.08.23 um 11:51 schrieb Christophe JAILLET:
> This serie simplifies amdgpu_bo_list_create() and usage of the 'struct
> amdgpu_bo_list'.

Oh, yes please. That's something I always wanted to cleanup as well.

> It is compile tested only.

That bothers me a bit. Arun, Vitaly, Shashank can anybody with time run 
a quick test on this? Preferable the IGT tests, but this just some game 
should probably do as well.

Apart from that looks good to me,
Christian.

>
> Christophe JAILLET (4):
>    drm/amdgpu: Explicitly add a flexible array at the end of 'struct
>      amdgpu_bo_list'
>    drm/amdgpu: Remove a redundant sanity check
>    drm/amdgpu: Remove amdgpu_bo_list_array_entry()
>    drm/amdgpu: Use kvzalloc() to simplify code
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 15 ++-------------
>   drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.h | 18 ++++++------------
>   2 files changed, 8 insertions(+), 25 deletions(-)
>


  parent reply	other threads:[~2023-08-21 11:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-20  9:51 Christophe JAILLET
2023-08-20  9:51 ` [PATCH 1/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' Christophe JAILLET
2023-08-20  9:51 ` [PATCH 2/4] drm/amdgpu: Remove a redundant sanity check Christophe JAILLET
2023-08-20  9:51 ` [PATCH 3/4] drm/amdgpu: Remove amdgpu_bo_list_array_entry() Christophe JAILLET
2023-08-20  9:51 ` [PATCH 4/4] drm/amdgpu: Use kvzalloc() to simplify code Christophe JAILLET
2023-08-21 11:03 ` Christian König [this message]
2023-08-21 13:00   ` [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list_create() Shashank Sharma
2023-08-22 13:26     ` Somalapuram, Amaranath
2023-08-24 14:37       ` Alex Deucher
2023-08-21 18:16   ` Arunpravin Paneer Selvam
2023-08-22  0:33   ` vitaly prosyak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d52550a-92a1-55e7-69ad-92f18330ff48@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Arunpravin.PaneerSelvam@amd.com \
    --cc=Felix.Kuehling@amd.com \
    --cc=Shashank.Sharma@amd.com \
    --cc=Vitaly.Prosyak@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®