From: "Trilok Soni" <soni.trilok@gmail.com>
To: "Sam Ravnborg" <sam@ravnborg.org>
Cc: linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com,
akpm@linux-foundation.org, "Tony Lindgren" <tony@atomide.com>,
imre.deak@solidboot.com, juha.yrjola@solidboot.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/17] OMAP: Add TI OMAP framebuffer driver
Date: Wed, 27 Jun 2007 14:14:08 +0530 [thread overview]
Message-ID: <5d5443650706270144l2d905d2h142617d01f515785@mail.gmail.com> (raw)
In-Reply-To: <20070626165003.GA22389@uranus.ravnborg.org>
Hi Sam,
On 6/26/07, Sam Ravnborg <sam@ravnborg.org> wrote:
> diff --git a/drivers/video/omap/Makefile b/drivers/video/omap/Makefile
> new file mode 100644
> index 0000000..5aa7175
> --- /dev/null
> +++ b/drivers/video/omap/Makefile
> @@ -0,0 +1,10 @@
> +#
> +# Makefile for the new OMAP framebuffer device driver
> +#
> +
> +obj-$(CONFIG_FB_OMAP) += omapfb.o
> +
> +objs-yy := omapfb_main.o
> +
> +omapfb-objs := $(objs-yy)
> +
>
> This looks strangs.
> Please use:
> obj-$(CONFIG_FB_OMAP) += omapfb.o
>
> omapfb-y := omapfb_main.o
>
> Or even better rename your .c file to omapfb.c then
> you only need to use:
> obj-$(CONFIG_FB_OMAP) += omapfb.o
>
Thanx for the review. I will incorporate your suggestions into the
next update of fb patches.
--
--Trilok Soni
prev parent reply other threads:[~2007-06-27 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 12:33 Trilok Soni
2007-06-26 16:50 ` Sam Ravnborg
2007-06-27 8:44 ` Trilok Soni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650706270144l2d905d2h142617d01f515785@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=imre.deak@solidboot.com \
--cc=juha.yrjola@solidboot.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®