From: Trilok Soni <soni.trilok@gmail.com>
To: Linus Walleij <linus.ml.walleij@gmail.com>
Cc: Mike Rapoport <mike@compulab.co.il>,
linux-kernel@vger.kernel.org, sameo@linux.intel.com,
linux-i2c@vger.kernel.org,
Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: [PATCH 1/1] MFD: Add U300 AB3100 core support v2
Date: Tue, 19 May 2009 22:56:16 +0530 [thread overview]
Message-ID: <5d5443650905191026w22b0ff95j992e09923f55dd0a@mail.gmail.com> (raw)
In-Reply-To: <63386a3d0905190923t36d301c5hf245c06db00b6127@mail.gmail.com>
Hi Linus,
On Tue, May 19, 2009 at 9:53 PM, Linus Walleij
<linus.ml.walleij@gmail.com> wrote:
> Hm I shouldn't been so trigger-happy as to send v3 out so soon... :-/
>
> Thanks for you quick review Mike!
>
> 2009/5/19 Mike Rapoport <mike@compulab.co.il>:
>
>>> + /* Set a pointer back to the container in device data */
>>> + for (i = 0; i < ARRAY_SIZE(ab3100_platform_devs); i++)
>>> + platform_set_drvdata(ab3100_platform_devs[i], ab3100_local);
>>> +
>>> + /* Register the platform devices */
>>> + platform_add_devices(ab3100_platform_devs,
>>> + ARRAY_SIZE(ab3100_platform_devs));
>>
>> If you register sub-devices this way, they won't appear as ab3100 children.
>
> I'll set the parent in the first loop then (will test that this works) because I
> really like that device table. (Similar to how the board setup does things.)
>
I don't know but why people are not encouraging to use mfd_xxx apis
here? Lot's of drivers are available under drivers/mfd, but only
couple of them are using real mfd_xxx apis? Is there anything missing
in those apis?
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
next prev parent reply other threads:[~2009-05-19 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 20:40 Linus Walleij
2009-05-19 10:50 ` Ben Dooks
2009-05-19 14:35 ` Mike Rapoport
2009-05-19 16:23 ` Linus Walleij
2009-05-19 17:26 ` Trilok Soni [this message]
2009-05-19 18:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650905191026w22b0ff95j992e09923f55dd0a@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=linus.ml.walleij@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®