From: Trilok Soni <soni.trilok@gmail.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH] Haptic class support (v2)
Date: Mon, 12 Oct 2009 19:14:57 +0530 [thread overview]
Message-ID: <5d5443650910120644x4180ff6bt45b72be86b50588f@mail.gmail.com> (raw)
In-Reply-To: <9c9fda240910111732x262a9510rf3dd862aa16d0bdf@mail.gmail.com>
Hi Kyungmin,
On Mon, Oct 12, 2009 at 6:02 AM, Kyungmin Park <kmpark@infradead.org> wrote:
> On Sun, Oct 11, 2009 at 6:05 PM, Pavel Machek <pavel@ucw.cz> wrote:
>> On Tue 2009-10-06 16:45:33, Kyungmin Park wrote:
>>> This patch includes two haptic devices, isa1000 and isa1200
>>> ISA1000 is gpio based haptic, but isa1200 is based on I2C
>>> Both are working on Samsung SoCs and tested.
>>>
>>> To enable the haptic, echo 1 > /sys/class/haptic/${name}/enable
>>> You can adjust the level by echo ${level} > /sys/class/haptic/${name}/enable
>>> or
>>> With oneshot feature, echo ${msec time} > /sys/class/haptic/${name}/oneshot
>>
>> New device classes should certainly be documented in Documentation/.
>>
>> For example... is level 0-100?
>
> Basically. range from 0 to 255. also each device can set max level in
> case of isa1000 it's 6.
>
>> Is it valid to change level while 'oneshot' is running?
>
> we usually use it under 1 sec. but I think it's possible to change it
> but not tried.
>
>> Does oneshot use last level set?
>
> Right. it used last set value.
>
> If you don't mind to update these at Documentation please wait until
> commit first patches merged.
Let's see what Greg prefers. Could you please refresh your patchset
with probably addressing comments given in the isa1200 and samsung_pwm
driver by me?
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
next prev parent reply other threads:[~2009-10-12 13:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 7:45 Kyungmin Park
2009-10-06 15:25 ` Randy Dunlap
2009-10-06 18:35 ` Trilok Soni
2009-10-07 5:13 ` Kyungmin Park
2009-10-11 9:05 ` Pavel Machek
2009-10-12 0:32 ` Kyungmin Park
2009-10-12 13:44 ` Trilok Soni [this message]
2009-10-12 14:40 ` Greg KH
2009-10-13 11:05 ` Pavel Machek
2009-10-12 15:42 ` Kay Sievers
2009-10-12 16:20 ` Mark Brown
2009-10-13 16:45 ` Kay Sievers
2009-10-20 6:44 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650910120644x4180ff6bt45b72be86b50588f@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=greg@kroah.com \
--cc=kmpark@infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®