From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 949EEC433FF for ; Wed, 14 Aug 2019 17:59:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70CB020651 for ; Wed, 14 Aug 2019 17:59:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Zc/RhUNa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728689AbfHNR7p (ORCPT ); Wed, 14 Aug 2019 13:59:45 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35513 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728301AbfHNR7p (ORCPT ); Wed, 14 Aug 2019 13:59:45 -0400 Received: by mail-pg1-f196.google.com with SMTP id n4so11732825pgv.2 for ; Wed, 14 Aug 2019 10:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:subject:from:cc:to:user-agent:date; bh=kF2rSGg7TWdsph3+jKGWM5Z90AAtcPpo25Mf5csWFrU=; b=Zc/RhUNaKUH6TKfhRZWBo6OBqnN6wsyVNMAXjBgiNUtQxZoaGMZ+qifnZYFCHOtQNq 93B6SETP1TqUWc7SCQ5mY3c3gtiWJs3r/RoBFb0OerUawl9ihfJgTVV4pxnTZyN7Uy7w 41upxhquofjg2gVE6AG70o1y8XyTA+QyHCgLQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:subject:from:cc:to :user-agent:date; bh=kF2rSGg7TWdsph3+jKGWM5Z90AAtcPpo25Mf5csWFrU=; b=XRlyIS9JSBMUrXJOelXSv9pPFBCbIU7jc14L4z6xI0pjVAJuaJaVZA2lo1b6Mo1JyB W9Zx23qKxWIe29Q9zo3M9r9HOMlPzCfz9mEn3NjRfYa2RLCrNMIqDgeS3McdF9soRmC2 akVTD6m0gVw4Ps07LYNuNDX1P9n/pkqOE/MbEfY8OXzMP5CL6i1fygYfOkLVwwfl7kyH k4y0upV08Bl79asd02qDoPmJUjtb+gInrk5PGnTs2L/5fbRu3OzCIpKGa7qsLBhOZqDf hikzikBcLUJDDP5YXiDiGzZoT6+G/sxisLeG1f5MNwqeU/pbpjscIYlPOnb2G0viCX2I HU3A== X-Gm-Message-State: APjAAAUMXEBNU7BKe9+op6XYbhCvnBUGalXRwzhv8EnNLh/i8pofNsra 5bjt8Tf5nDktqbOgdRjIbiPNXNhQz7TlkA== X-Google-Smtp-Source: APXvYqzlhFg/syHBm6u3NkrWSTkdwA/nnqbqnwh5uAmEwTa/NV7gwIbeSWeDmlMEvcDq5rUej/oTTg== X-Received: by 2002:a17:90a:7d09:: with SMTP id g9mr903391pjl.38.1565805584194; Wed, 14 Aug 2019 10:59:44 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id f72sm486217pjg.10.2019.08.14.10.59.43 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 14 Aug 2019 10:59:43 -0700 (PDT) Message-ID: <5d544c0f.1c69fb81.a78d3.1381@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190813082442.25796-2-mkshah@codeaurora.org> References: <20190813082442.25796-1-mkshah@codeaurora.org> <20190813082442.25796-2-mkshah@codeaurora.org> Subject: Re: [PATCH 1/4] drivers: qcom: rpmh: fix macro to accept NULL argument From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, bjorn.andersson@linaro.org, evgreen@chromium.org, dianders@chromium.org, rnayak@codeaurora.org, ilina@codeaurora.org, lsrao@codeaurora.org, ulf.hansson@linaro.org, Maulik Shah To: Maulik Shah , agross@kernel.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org User-Agent: alot/0.8.1 Date: Wed, 14 Aug 2019 10:59:42 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Maulik Shah (2019-08-13 01:24:39) > Device argument matches with dev variable declared in RPMH message. > Compiler reports error when the argument is NULL since the argument > matches the name of the property. Rename dev argument to device to > fix this. >=20 > Signed-off-by: Maulik Shah > --- Maybe this should have a Fixes tag? And the subject could be something like "avoid shadowing local variables in macro"? Reviewed-by: Stephen Boyd