From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753223AbcHQGLv (ORCPT ); Wed, 17 Aug 2016 02:11:51 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:56942 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbcHQGLu (ORCPT ); Wed, 17 Aug 2016 02:11:50 -0400 Subject: Re: [PATCH V4]mmc: dw_mmc-k3: UHS-SD card for Hisilicon Hikey To: Jaehoon Chung , Shawn Lin , , , , , , , , References: <1470276973-41683-1-git-send-email-kid.jin@hisilicon.com> <74c80b1c-5570-0ee0-4132-ff703d8d5eb4@hisilicon.com> <06f63a26-251d-5ba8-f877-dae75aa8e362@rock-chips.com> <1b724dde-863d-fa28-fa58-595c34c1bef2@samsung.com> CC: , , From: Jinguojun Message-ID: <5d5551f4-e49c-d005-eb0b-9ca472a8d249@hisilicon.com> Date: Wed, 17 Aug 2016 14:11:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1b724dde-863d-fa28-fa58-595c34c1bef2@samsung.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.142.148.191] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0206.57B4001F.0030,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: fec00084de0ad2bf78eacbd671ffeeda Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 2016/8/8 18:46, Jaehoon Chung wrote: > Hi, > > On 08/08/2016 06:10 PM, Shawn Lin wrote: >> Hi guy, >> >> On 2016/8/8 15:10, Jinguojun wrote: >>> Hi,maintainers >>> >>> Pls help to review code,this is the newest patch after your advise > > Subject.. > > s/UHS-SD/UHS-I/ > >>> >> >> Please give Jaehoon more time to review your patch before sending a >> ping or resending one(~2 weeks), as it's only four days(weekend >> included) since v4 was done....IMHO, it's quite bold... >> >>> Thx I apologize for my rudeness. >>> On 2016/8/4 10:16, Jin Guojun wrote: >>>> mmc: dw_mmc-k3: Hisilicon Hikey have no tuning function in >>>> dw_mmc-k3.c,so we must do the tuning function stub when we init UHS card. >>>> >> >> Hrmmm.... remove "mmc: dw_mmc-k3:" from the meat of commit msg。 >> >> And you do nothing for dw_mci_hi6220_execute_tuning, why? >> Could you elaborate more.. >> >> OK I'll remove the mmc: dw_mmc-k3:,Then Hikey can't support SDR104,so we only support SDR12 SDR25 SD50,and we do not need to do tuning for these modes. >>>> V1:add .prepare_command in dw_mmc.c >>>> V2:delete .prepare_command, add err = 0 in dw_mci_execute_tuning >>>> V3:delete err = 0 in dw_mci_execute_tuning,add .execute_tuning in >>>> dw_mmc-k3.c >>>> V4:add "linux-mmc@vger.kernel.org", patch version, Changelog, etc.. >> >> The changelog is totally wrong, namely it should not be listed in the >> commit msg... >> OK I'll delete this part >>>> >>>> Signed-off-by: Jin Guojun >>>> --- >>>> drivers/mmc/host/dw_mmc-k3.c | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c >>>> index 8e9d886..6247894 100644 >>>> --- a/drivers/mmc/host/dw_mmc-k3.c >>>> +++ b/drivers/mmc/host/dw_mmc-k3.c >>>> @@ -131,11 +131,17 @@ static void dw_mci_hi6220_set_ios(struct dw_mci *host, struct mmc_ios *ios) >>>> host->bus_hz = clk_get_rate(host->biu_clk); >>>> } >>>> >>>> +static int dw_mci_hi6220_execute_tuning(struct dw_mci_slot *slot, u32 opcode) >>>> +{ >>>> + return 0; >>>> +} > > > All of UHS-I cards didn't need to do tuning sequence on your SoC? it's strange. > > I think we can fix more exactly in dw_mmc.c > As i know, some UHS cards don't need to send the tuning sequence. > (If i know wrong, let me know plz.) > > But just skipping execute_tuning..I think it's not correct. > > Best Regards, > Jaehoon Chung > We cant support SDR104 currently.We only turn on SDR12 SDR25 SDR50. >>>> + >>>> static const struct dw_mci_drv_data hi6220_data = { >>>> .caps = dw_mci_hi6220_caps, >>>> .switch_voltage = dw_mci_hi6220_switch_voltage, >>>> .set_ios = dw_mci_hi6220_set_ios, >>>> .parse_dt = dw_mci_hi6220_parse_dt, >>>> + .execute_tuning = dw_mci_hi6220_execute_tuning, >>>> }; >>>> >>>> static const struct of_device_id dw_mci_k3_match[] = { >>>> >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> >> > > > . >