Re: [PATCH] staging: r8188eu: core: remove condition with no effect

[Michael Straube <straube.linux@gmail.com>]

On 8/21/21 10:23 PM, Saurav Girepunje wrote:
> Remove the condition with no effect (if == else) in rtw_led.c
> file.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>   drivers/staging/r8188eu/core/rtw_led.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c
> index 22d4df9c92a5..76cbd5f19f90 100644
> --- a/drivers/staging/r8188eu/core/rtw_led.c
> +++ b/drivers/staging/r8188eu/core/rtw_led.c
> @@ -148,10 +148,7 @@ static void SwLedBlink(struct LED_871x *pLed)
>   			_set_timer(&(pLed->BlinkTimer), LED_BLINK_SLOWLY_INTERVAL);
>   			break;
>   		case LED_BLINK_WPS:
> -			if (pLed->BlinkingLedState == RTW_LED_ON)
> -				_set_timer(&(pLed->BlinkTimer), LED_BLINK_LONG_INTERVAL);
> -			else
> -				_set_timer(&(pLed->BlinkTimer), LED_BLINK_LONG_INTERVAL);
> +			_set_timer(&(pLed->BlinkTimer), LED_BLINK_LONG_INTERVAL);
>   			break;
>   		default:
>   			_set_timer(&(pLed->BlinkTimer), LED_BLINK_SLOWLY_INTERVAL);
> --
> 2.30.2
> 
> 

Hi Saurav,

this does not apply to staging-testing. Please rebase against
staging-testing and send v2.

Thanks,

Michael