From: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
To: John Stultz <john.stultz@linaro.org>, Felipe Balbi <balbi@kernel.org>
Cc: "Yang, Fei" <fei.yang@intel.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Chen Yu <chenyu56@huawei.com>,
lkml <linux-kernel@vger.kernel.org>,
Linux USB List <linux-usb@vger.kernel.org>,
Amit Pundir <amit.pundir@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers
Date: Wed, 8 May 2019 09:01:27 +0200 [thread overview]
Message-ID: <5d58059c-1b10-665f-983b-a1d018a30d1f@gmail.com> (raw)
In-Reply-To: <CALAqxLUMRaNxwTUi9QS7-Cy-Ve4+vteBm8-jW4yzZg_QTJVChA@mail.gmail.com>
Hi John,
+= Marek
W dniu 08.05.2019 o 04:18, John Stultz pisze:
> Since commit 772a7a724f69 ("usb: gadget: f_fs: Allow scatter-gather
> buffers"), I've been seeing trouble with adb transfers in Android on
> HiKey960, HiKey and now Dragonboard 845c.
>
> Sometimes things crash, but often the transfers just stop w/o any
> obvious error messages.
>
> Initially I thought it was an issue with the HiKey960 dwc3 usb patches
> being upstreamed, and was using the following hack workaround:
> https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/hikey960-5.1&id=dcdadaaec9db7a7b78ea9b838dd1453359a2f388
>
> Then dwc2 added sg support, and I ended up having to revert it to get
> by on HiKey:
> https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/hikey-5.1&id=6e91b4c7bd1e94bdd835263403c53e85a677b848
>
> (See thread here: https://lkml.org/lkml/2019/3/8/765)
>
> And now I've reproduced the same issue (with the same dwc3 workaround)
> on the already upstream code for Dragonboard 845c.
>
> Fei Yang has also reached out and mentioned he was seeing similar
> problems with the f_fs sg support.
>
> Andrzej: Do you have any ideas or suggestions on this? I'm happy to
> test or run any debug patches, if it would help narrow the issue down.
>
There is a patch:
https://www.spinics.net/lists/linux-usb/msg178536.html
https://www.spinics.net/lists/linux-usb/msg179653.html
which fixes a subtle bug, but hasn't been applied yet.
Can you please try it?
> If not, should we consider reverting the f_fs sg support?
>
Andrzej
next prev parent reply other threads:[~2019-05-08 7:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 2:18 John Stultz
2019-05-08 7:01 ` Andrzej Pietrasiewicz [this message]
2019-05-08 21:39 ` John Stultz
2019-05-09 3:25 ` John Stultz
2019-05-08 12:44 ` Andrzej Pietrasiewicz
2019-05-08 21:45 ` John Stultz
2019-05-09 14:02 ` Andrzej Pietrasiewicz
2019-05-09 18:25 ` John Stultz
2019-05-09 21:23 ` John Stultz
2019-05-13 14:08 ` Andrzej Pietrasiewicz
2019-05-13 18:09 ` John Stultz
2019-05-14 10:14 ` Andrzej Pietrasiewicz
2019-05-20 10:42 ` Andrzej Pietrasiewicz
2019-05-20 16:23 ` Yang, Fei
2019-05-20 18:33 ` John Stultz
2019-05-20 21:52 ` Yang, Fei
2019-05-21 10:04 ` Andrzej Pietrasiewicz
2019-05-21 15:34 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d58059c-1b10-665f-983b-a1d018a30d1f@gmail.com \
--to=andrzejtp2010@gmail.com \
--cc=amit.pundir@linaro.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chenyu56@huawei.com \
--cc=fei.yang@intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®