From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752061AbdEIHhP (ORCPT ); Tue, 9 May 2017 03:37:15 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:32185 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbdEIHhN (ORCPT ); Tue, 9 May 2017 03:37:13 -0400 From: Hugues FRUCHET To: Hans Verkuil , Rob Herring , "Mark Rutland" , Maxime Coquelin , Alexandre TORGUE , Mauro Carvalho Chehab CC: "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , Benjamin Gaignard , Yannick FERTRE Subject: Re: [PATCH v5 2/8] [media] stm32-dcmi: STM32 DCMI camera interface driver Thread-Topic: [PATCH v5 2/8] [media] stm32-dcmi: STM32 DCMI camera interface driver Thread-Index: AQHSxkZZpDlxLHJSoke7kwNZhwWkKqHrf+MA Date: Tue, 9 May 2017 07:36:34 +0000 Message-ID: <5d588e10-4185-60c5-de38-54b2a4428ae6@st.com> References: <1493998287-5828-1-git-send-email-hugues.fruchet@st.com> <1493998287-5828-3-git-send-email-hugues.fruchet@st.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.50] Content-Type: text/plain; charset="utf-8" Content-ID: <55EF19CDA8ED04469180783B236B4A77@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-09_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v497bPSI016672 Hi Hans, It's OK, feel free to change. BR Hugues. On 05/06/2017 10:54 AM, Hans Verkuil wrote: > Hi Hugues, > > On 05/05/2017 05:31 PM, Hugues Fruchet wrote: >> This V4L2 subdev driver enables Digital Camera Memory Interface (DCMI) >> of STMicroelectronics STM32 SoC series. >> >> Reviewed-by: Hans Verkuil >> Signed-off-by: Yannick Fertre >> Signed-off-by: Hugues Fruchet >> --- >> drivers/media/platform/Kconfig | 12 + >> drivers/media/platform/Makefile | 2 + >> drivers/media/platform/stm32/Makefile | 1 + >> drivers/media/platform/stm32/stm32-dcmi.c | 1403 +++++++++++++++++++++++++++++ >> 4 files changed, 1418 insertions(+) >> create mode 100644 drivers/media/platform/stm32/Makefile >> create mode 100644 drivers/media/platform/stm32/stm32-dcmi.c >> >> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig >> index ac026ee..de6e18b 100644 >> --- a/drivers/media/platform/Kconfig >> +++ b/drivers/media/platform/Kconfig >> @@ -114,6 +114,18 @@ config VIDEO_S3C_CAMIF >> To compile this driver as a module, choose M here: the module >> will be called s3c-camif. >> >> +config VIDEO_STM32_DCMI >> + tristate "Digital Camera Memory Interface (DCMI) support" > > Is it OK with you if I change this to: > > tristate "STM32 Digital Camera Memory Interface (DCMI) support" > > Right now the text gives no indication that this driver is for an STM32 platform. > > No need to spin a new patch, just let me know you're OK with it and I'll make > the change. > > Regards, > > Hans > >> + depends on VIDEO_V4L2 && OF && HAS_DMA >> + depends on ARCH_STM32 || COMPILE_TEST >> + select VIDEOBUF2_DMA_CONTIG >> + ---help--- >> + This module makes the STM32 Digital Camera Memory Interface (DCMI) >> + available as a v4l2 device. >> + >> + To compile this driver as a module, choose M here: the module >> + will be called stm32-dcmi. >> + >> source "drivers/media/platform/soc_camera/Kconfig" >> source "drivers/media/platform/exynos4-is/Kconfig" >> source "drivers/media/platform/am437x/Kconfig"