From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57E3E13B7AE for ; Mon, 24 Jun 2024 12:34:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719232493; cv=none; b=jDbImDnEKJWR2hBEfDnJSF28Ib74sCb5TXYNWeUP/YgPZVBEQq9zK5x31jrpngfRAakpXAqQZ88OwmGQLRZtKBZ0LJvVWvclPX/XIuZr7vA+AOWWDPbSjCpBPPo312UVcvuZ7XjGPn21QnHYfFvOMi0z6hjnuTcLE2OsvYBqL7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719232493; c=relaxed/simple; bh=5f0/UoGx6xaywRoX9Pa4HI10K9jFxVdu6pAJ0tGudJk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AvNsdgzLT//tITHwNyed1jcW5pAbNaHMglWt12lz8LNjhxKPmYcWDO8/vokKTKpYCp4mKykkWY2xlFpJwJqK6A8xmdlcnMJNxlQf3X2no0bWIVm8jh7j6T8jhPHUwFHqenvEmJ1V3fwnBVOGIC8kPzL7wFmldlV1Z3p7QJZfizA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VQKGa16B; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VQKGa16B" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a6fe617966fso183479066b.1 for ; Mon, 24 Jun 2024 05:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719232490; x=1719837290; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T6mu5FL/2KlapxSCeQ/DGjboe5sy2JfXpFVHbsPe+7s=; b=VQKGa16BAXYLVBbkG18H0v2Ccnje4zrb75x8fenRbds+FOkpBxv/RyQXv/Md5C9bNU FWiwwi7WsNSQOrWK3y0DpD3SSrZi/bwNgN4Q9DFIcItkVG7gmSGJWlY6MAkvc+snevVs 1YR6UIeOpL2P1XYaNm4xVrDsftL88bcOqrpet/5wqmXNv24zGMarDAEcBloHVz60UsNl ofAJ/mZXz7eElMmOnwlYRPyz9zO2Ykxsqu30Ebg+NJ9JXYYMJM8P0ISWoG/J+EJQHgwM be6k+pRGzgAsMBP2XmjNYM5a3nMeQaA+NQjYYEqIxCIStHrP6N5Iwbgiti0oN3B8ei1m Aybw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719232490; x=1719837290; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T6mu5FL/2KlapxSCeQ/DGjboe5sy2JfXpFVHbsPe+7s=; b=WMPRhp8/TJmA+XoSLrwBr29t241Bibi2QJ/pkU1KzJT9UK8PKiqEjUtqVLrb8MM0sw n1eLmSIkHRi+JF020z3XZ5RBNqeM+giKqUNT7vIdbx0xgdfjs8tfJ8MR8Fw6MWOvgjFc 7AJeJDTfk56ayhiKGjIFP2ZguCN58+1PTLcYoUMOngA9zZ2RqCm1LkonUXUhvufz+Z/M w+IHf0BY/Oha8T+qgDYcLqtiEqPrnbGtpU1rIhIgZNOPoVfMUQswrlRGUFOsYhP7fciZ NCbYePr9WHr30R7NDsZRxS2rqzAsNm7sKjo9QpPscphhnf9nF4uT8zj6PiFSAAWz7iKO JFVw== X-Forwarded-Encrypted: i=1; AJvYcCUEdtRSZFYfhsUPuW/Q7a+OPKfoEeIdMkmgvHu6yLwF5Du7a8b5FLu3k7n1NwAB79BVwMqFyxqPCGy4eeHHuet0ygiterZGbp1gKCR+ X-Gm-Message-State: AOJu0YxSghLuEDYCKdcDTnT5kN7ROGBdvpx5oter/RoDG9+T3uNqoai2 eN1WPj9WnDV049KBxvv9OARAhx8mjX/ksmEdAwJyNBMNYXY+HMK2xvXdfOi4BD8= X-Google-Smtp-Source: AGHT+IHhqhonX6NXyzCrMbfxJmbvAwRvtzOkWNJuPKmWWYJ0JpIp7FmdDe+Qp1r7MvCKUIDvI8XH+g== X-Received: by 2002:a17:907:c301:b0:a6f:5f5d:e924 with SMTP id a640c23a62f3a-a7245b4c9bcmr369118666b.6.1719232489511; Mon, 24 Jun 2024 05:34:49 -0700 (PDT) Received: from ?IPV6:2a02:8109:aa0d:be00::52af? ([2a02:8109:aa0d:be00::52af]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72452140e0sm209539866b.217.2024.06.24.05.34.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 05:34:49 -0700 (PDT) Message-ID: <5d5eaabc-8a85-4d1f-bf2e-cb2594005a39@linaro.org> Date: Mon, 24 Jun 2024 14:34:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: prefer host mode on dev boards To: neil.armstrong@linaro.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240624-b4-rb2-fixes-v1-0-8d763ee4e42e@linaro.org> <20240624-b4-rb2-fixes-v1-3-8d763ee4e42e@linaro.org> <8411fee8-7e09-421a-a52b-487acd3a3e24@linaro.org> Content-Language: en-US From: Caleb Connolly In-Reply-To: <8411fee8-7e09-421a-a52b-487acd3a3e24@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 24/06/2024 14:28, neil.armstrong@linaro.org wrote: > On 24/06/2024 14:23, Caleb Connolly wrote: >> Generally, when given the choice these boards should prefer host mode >> since they're SBCs. When attached to a laptop (which is host-only) they >> should still fall back to peripheral mode. > > It's really not what I observed on sm8550/sm8650 QRD/HDK, as the power > is setup for peripheral by the bootloader and without an actual UCSI/PD > negociation it would only be functionnal as peripheral mode. > > So this is definitely untrue on sm8450/sm8550/sm8650 HDK/QRD/MTP. Hmm, yeah in that case this change could break U-Boot. Let me re-send and split out the rb1/2 since those are much more clear cut. > > Neil > >> >> Suggested-by: Dmitry Baryshkov >> Signed-off-by: Caleb Connolly >> --- >>   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 1 + >>   arch/arm64/boot/dts/qcom/qrb2210-rb1.dts     | 4 ++++ >>   arch/arm64/boot/dts/qcom/qrb4210-rb2.dts     | 4 ++++ >>   arch/arm64/boot/dts/qcom/sm8150-hdk.dts      | 1 + >>   arch/arm64/boot/dts/qcom/sm8350-hdk.dts      | 4 ++++ >>   arch/arm64/boot/dts/qcom/sm8450-hdk.dts      | 1 + >>   arch/arm64/boot/dts/qcom/sm8550-hdk.dts      | 4 ++++ >>   arch/arm64/boot/dts/qcom/sm8550-mtp.dts      | 4 ++++ >>   arch/arm64/boot/dts/qcom/sm8550-qrd.dts      | 4 ++++ >>   arch/arm64/boot/dts/qcom/sm8650-hdk.dts      | 4 ++++ >>   arch/arm64/boot/dts/qcom/sm8650-mtp.dts      | 4 ++++ >>   arch/arm64/boot/dts/qcom/sm8650-qrd.dts      | 4 ++++ >>   12 files changed, 39 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> index c4cde4328e3d..bac4ed5874b6 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts >> @@ -657,8 +657,9 @@ &usb_1 { >>   &usb_1_dwc3 { >>       dr_mode = "otg"; >>       usb-role-switch; >> +    role-switch-default-mode = "host"; >>   }; >>   &usb_1_dwc3_hs { >>       remote-endpoint = <&pmic_glink_hs_in>; >> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts >> b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts >> index e19790464a11..bece4896ca23 100644 >> --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts >> +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts >> @@ -593,8 +593,12 @@ &uart4 { >>   &usb { >>       status = "okay"; >>   }; >> +&usb_dwc3 { >> +    role-switch-default-mode = "host"; >> +}; >> + >>   &usb_dwc3_hs { >>       remote-endpoint = <&pm4125_hs_in>; >>   }; >> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> index 1c7de7f2db79..17d36f0ef5ab 100644 >> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> @@ -661,8 +661,12 @@ &uart4 { >>   &usb { >>       status = "okay"; >>   }; >> +&usb_dwc3 { >> +    role-switch-default-mode = "host"; >> +}; >> + >>   &usb_dwc3_hs { >>       remote-endpoint = <&pmi632_hs_in>; >>   }; >> diff --git a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts >> b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts >> index bac08f00b303..fe548d795490 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts >> @@ -695,8 +695,9 @@ &usb_2 { >>   &usb_1_dwc3 { >>       dr_mode = "otg"; >>       usb-role-switch; >> +    role-switch-default-mode = "host"; >>   }; >>   &usb_1_dwc3_hs { >>       remote-endpoint = <&pm8150b_hs_in>; >> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts >> b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts >> index e031ad4c19f4..20d5c54cfcf9 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts >> @@ -847,8 +847,12 @@ &ufs_mem_phy { >>   &usb_1 { >>       status = "okay"; >>   }; >> +&usb_1_dwc3 { >> +    role-switch-default-mode = "host"; >> +}; >> + >>   &usb_1_dwc3_hs { >>       remote-endpoint = <&pmic_glink_hs_in>; >>   }; >> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> index a754b8fe9167..ebafcbe6859e 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> @@ -1098,8 +1098,9 @@ &usb_1 { >>   &usb_1_dwc3 { >>       dr_mode = "otg"; >>       usb-role-switch; >> +    role-switch-default-mode = "host"; >>   }; >>   &usb_1_dwc3_hs { >>       remote-endpoint = <&pmic_glink_hs_in>; >> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts >> b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts >> index e0dc03a97771..1efda478b7b9 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts >> @@ -1252,8 +1252,12 @@ &ufs_mem_phy { >>   &usb_1 { >>       status = "okay"; >>   }; >> +&usb_1_dwc3 { >> +    role-switch-default-mode = "host"; >> +}; >> + >>   &usb_1_dwc3_hs { >>       remote-endpoint = <&pmic_glink_hs_in>; >>   }; >> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> index 26dfca0c3e05..7b05932f9c36 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> @@ -945,8 +945,12 @@ &ufs_mem_phy { >>   &usb_1 { >>       status = "okay"; >>   }; >> +&usb_1_dwc3 { >> +    role-switch-default-mode = "host"; >> +}; >> + >>   &usb_1_dwc3_hs { >>       remote-endpoint = <&pmic_glink_hs_in>; >>   }; >> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts >> b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts >> index 361b0792db4f..744bdc846e70 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts >> @@ -1211,8 +1211,12 @@ &ufs_mem_phy { >>   &usb_1 { >>       status = "okay"; >>   }; >> +&usb_1_dwc3 { >> +    role-switch-default-mode = "host"; >> +}; >> + >>   &usb_1_dwc3_hs { >>       remote-endpoint = <&pmic_glink_hs_in>; >>   }; >> diff --git a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts >> b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts >> index 092b78fd8a3b..f07a56583e7d 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts >> @@ -1300,8 +1300,12 @@ &ufs_mem_phy { >>   &usb_1 { >>       status = "okay"; >>   }; >> +&usb_1_dwc3 { >> +    role-switch-default-mode = "host"; >> +}; >> + >>   &usb_1_dwc3_hs { >>       remote-endpoint = <&pmic_glink_hs_in>; >>   }; >> diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts >> b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts >> index d6f91580ba8d..1a9a31423af4 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts >> @@ -839,8 +839,12 @@ &ufs_mem_phy { >>   &usb_1 { >>       status = "okay"; >>   }; >> +&usb_1_dwc3 { >> +    role-switch-default-mode = "host"; >> +}; >> + >>   &usb_1_dwc3_hs { >>       remote-endpoint = <&pmic_glink_hs_in>; >>   }; >> diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts >> b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts >> index bd60c2770da2..031b7ada8eb1 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts >> @@ -1285,8 +1285,12 @@ &ufs_mem_phy { >>   &usb_1 { >>       status = "okay"; >>   }; >> +&usb_1_dwc3 { >> +    role-switch-default-mode = "host"; >> +}; >> + >>   &usb_1_dwc3_hs { >>       remote-endpoint = <&pmic_glink_hs_in>; >>   }; >> > -- // Caleb (they/them)