mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Glauber de Oliveira Costa" <glommer@gmail.com>
To: "Glauber de Oliveira Costa" <gcosta@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	"Jeremy Fitzhardinge" <jeremy@goop.org>
Subject: Re: [PATCH] Wipe out traditional opt from x86_64 Makefile
Date: Thu, 25 Oct 2007 14:03:56 -0200	[thread overview]
Message-ID: <5d6222a80710250903y87f63f2g4193ab7161fb57c8@mail.gmail.com> (raw)
In-Reply-To: <11933164723812-git-send-email-gcosta@redhat.com>

Ok, ok... this was stupid.

I sent the patch against an already-commented out version, which is
the one I was using for testing. Really stupid.

On 10/25/07, Glauber de Oliveira Costa <gcosta@redhat.com> wrote:
> Among other things, using -traditional as a gcc option stops us from
> using macro token pasting, which is a feature we heavily rely on.
>
> There was still a use of -traditional in arch/x86/kernel/Makefile_64,
> which this patch removes.
>
> I don't see any problems building kernels in my x86_64 box without
> -traditional.
>
> Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
> ---
>  arch/x86/kernel/Makefile_64 |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/Makefile_64 b/arch/x86/kernel/Makefile_64
> index 82da906..03a01f6 100644
> --- a/arch/x86/kernel/Makefile_64
> +++ b/arch/x86/kernel/Makefile_64
> @@ -3,7 +3,6 @@
>  #
>
>  extra-y        := head_64.o head64.o init_task.o vmlinux.lds
> -#EXTRA_AFLAGS  := -traditional
>  obj-y  := process_64.o signal_64.o entry_64.o traps_64.o irq_64.o \
>                 ptrace_64.o time_64.o ioport_64.o ldt_64.o setup_64.o i8259_64.o sys_x86_64.o \
>                 x8664_ksyms_64.o i387_64.o syscall_64.o vsyscall_64.o \
> --
> 1.4.4.2
>
>


-- 
Glauber de Oliveira Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."

  reply	other threads:[~2007-10-25 16:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25 12:47 Glauber de Oliveira Costa
2007-10-25 16:03 ` Glauber de Oliveira Costa [this message]
2007-10-25 17:23 ` H. Peter Anvin
2007-10-25 17:36 ` Adrian Bunk
2007-10-25 17:56   ` H. Peter Anvin
2007-10-25 18:30     ` Adrian Bunk
2007-10-25 18:35       ` Jeremy Fitzhardinge
2007-10-26 19:47         ` Glauber de Oliveira Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d6222a80710250903y87f63f2g4193ab7161fb57c8@mail.gmail.com \
    --to=glommer@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=gcosta@redhat.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®