From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Saalim Quadri <danascape@gmail.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, daniel.baluta@nxp.com
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: wm8753: Convert to dtschema
Date: Sat, 15 Apr 2023 11:16:29 +0200 [thread overview]
Message-ID: <5d629ff3-c5ae-bd00-e70d-8c0d58365ce3@linaro.org> (raw)
In-Reply-To: <20230414223801.1106550-1-danascape@gmail.com>
On 15/04/2023 00:38, Saalim Quadri wrote:
> Convert the WM8753 audio codec bindings to DT schema.
>
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
> ---
> .../devicetree/bindings/sound/wlf,wm8753.yaml | 62 +++++++++++++++++++
> .../devicetree/bindings/sound/wm8753.txt | 40 ------------
Guys,
You choose unusual bindings to convert to DT schema. It is fine but
honestly, less useful, with limited impact. This is an old, 12 year old
binding without users. Maybe it would be even removed by now...
I suggest converting ones which have a real impact - have users in DTS.
Otherwise you will be putting quite a lot of effort for no real gains...
because what is the difference between this binding being TXT and DT schema?
> 2 files changed, 62 insertions(+), 40 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8753.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/wm8753.txt
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-15 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 22:38 Saalim Quadri
2023-04-15 9:16 ` Krzysztof Kozlowski [this message]
2023-04-15 20:12 ` Saalim Quadri
2023-04-16 7:35 ` Krzysztof Kozlowski
2023-04-16 18:51 ` Krzysztof Kozlowski
2023-04-17 20:46 ` Saalim Quadri
2023-04-17 9:15 ` Charles Keepax
2023-04-17 19:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d629ff3-c5ae-bd00-e70d-8c0d58365ce3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=danascape@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®