From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 753EDEB64DB for ; Thu, 15 Jun 2023 10:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343781AbjFOKGs (ORCPT ); Thu, 15 Jun 2023 06:06:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343742AbjFOKGZ (ORCPT ); Thu, 15 Jun 2023 06:06:25 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68801297D; Thu, 15 Jun 2023 03:06:04 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DA87D1FE03; Thu, 15 Jun 2023 10:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686823562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=atHh4oZI3Lsgj++bTTX/cCma79tEArLh42dujofeoy4=; b=GpVS4WSngjatjfN3tY/rif++DZgurobmGiLntZx3MnP37Rd7fCeizQ7YNdcCpmrhkjX/uc cokIdZHX2Nikwhn4zWEX2PJ4PY4MtHOZ1qB8HZG0a1dO7r9LgOSCI8KcfIOCE7GQCsU/jB hTw1idddJ2d8t9qrkCyPOteOxuPQflM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686823562; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=atHh4oZI3Lsgj++bTTX/cCma79tEArLh42dujofeoy4=; b=QLf5mIhi+VSkUhJXZM3R0anBQSteqJFIAYNWOxTvxK/shYcp5SRNOclkMRlnmHcmAc4FiJ y4kgsj+Wa/UJitCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C426C13A47; Thu, 15 Jun 2023 10:06:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id y6ufL4riimQVZgAAMHmgww (envelope-from ); Thu, 15 Jun 2023 10:06:02 +0000 Message-ID: <5d652560-cd80-228d-a107-a2cf8abda45d@suse.de> Date: Thu, 15 Jun 2023 12:06:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 1/2] nvme-fc: Do not wait in vain when unloading module Content-Language: en-US To: Daniel Wagner , linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Chaitanya Kulkarni , Shin'ichiro Kawasaki , Sagi Grimberg , James Smart References: <20230615094356.14878-1-dwagner@suse.de> <20230615094356.14878-2-dwagner@suse.de> From: Hannes Reinecke In-Reply-To: <20230615094356.14878-2-dwagner@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/15/23 11:43, Daniel Wagner wrote: > The module unload code will wait for a controller to be delete even when > there is no controller and we wait for completion forever to happen. > Thus only wait for the completion when there is a controller which > needs to be removed. > > Signed-off-by: Daniel Wagner > --- > drivers/nvme/host/fc.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes