From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4771D439F93 for ; Thu, 23 Jul 2026 12:05:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784808323; cv=none; b=l/hz1N/y5SVjkknx8jntyGN52yhwlGmFVndmDzEkhBD84EgyAjoAbdzue3nC/ZfQUHetuCuUEm2JyW4HSXSyb2u5/oG+Ip1v+Kb/MJy1zC5B0cLPVbCHZFHRzkJZBo4N6Dj2FtEMkPVXIFnAW0iaccS1OQXqcGP4JNT6Z9V9zv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784808323; c=relaxed/simple; bh=ACzxvPV7vra5qA+hMv+7yW6gYZx1YXG7wPPaYGWThks=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f13uK0Rm9AGbh/HH+wUkTjDEFmoghnc+UWYMa0BXOp0qx+AkdmjKk9iWFayc3cvHRYIIzvaXe+PMVb1SKh7s2tlYqlGSIlbVDU5EKkrveLuA3WB91SQizEA4m/CLf0fPI+nWf2UFITh3GvHbSjbReDo9A0th6fKjehjLEaFM0oQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jv6pkxYr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D7x6fsgY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jv6pkxYr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D7x6fsgY" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66N8qnOk3388121 for ; Thu, 23 Jul 2026 12:05:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kMKUqxc+rIEZeKT8ufnpN8oi8S7g7PqEIVgl3NYOaK0=; b=Jv6pkxYrcfEXFfuK DR+nXozpfiZJdN2a8xxu9dRl/sj2KNF/ryiY95SdCtQBdhoPqx9JEcPrBxUsPTg/ zF1DZnxzle0DuUc/gWeXx0Ie6TLswgoExanTtjn/Fa58YZtafjhB2zK4E+JJfW76 6RoinSY7iy3tfAwY6ls+yE/mjDnZ0hnRUO9wMCWX6I1mnHVDA8EwvlvtR4/R8dej cUwGJCdWFBtRrfpU3h3vdqKI2pyFA6ulc7dZ+9ud5Y4J/HW5NJXddwxzaBwjzd+Z NBfj1Go6cRt2rq5U4yYR/eAMZug64EhPDYZyMO3jgDQldpByD4qUT7eqcW7SPCKp iBNVCg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fk275kytn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 12:05:20 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c07313be5so2300021cf.2 for ; Thu, 23 Jul 2026 05:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784808320; x=1785413120; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kMKUqxc+rIEZeKT8ufnpN8oi8S7g7PqEIVgl3NYOaK0=; b=D7x6fsgYneBBwfI89oci4BFLkkZCSTJ7SKq6eI9hIvI795gesrkR0eU1iEEWQldl56 Y0exytOJqVdpYlQwkRwxJbJZF4FQAdHd9+Lbnm25SsfZaKR9AZ2NTopg8CpEnHhaC+qY iQrBw9EQ9lrZDn+AbJf3d8jQWt1wibItoy1I0AjBjkCLjyepuIQ+zfFph90bmxdQmGqL AxXtj3t3xi9jBclyddpd9MF/ttMIBQl5lAy2xEzpvbzh+AGDuwHj7z3zuXAck8ub3ohw 3G/w6QiFLEhF1R0NIkX+/youmNkPlrJCqIJEHW4VnvjRGi78Y2iZPlBpk8N7e0lHM4nw ZGdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784808320; x=1785413120; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kMKUqxc+rIEZeKT8ufnpN8oi8S7g7PqEIVgl3NYOaK0=; b=jiNBPimeqq/iEscWUZoagp+ez71RQloqeLudcuYS8B3cy3wM57rKyT/ewEcmQwwuTm ZJpVKrCeWpmYbMwEoIwA8NSklO11QvmnbM5ih1Xk/rwtIyrR1s6IqjekTVtwben//Ht1 16+qIbG5/5bCGtvLsyjSljQqb3u69Frfwndmc0XUbDPisBs0szCYlyeZw1O8YgK5NQqZ OalP8/fW/f9D9cq9LqzIYfAbW5cylP+zEcvzZnRZSG5vT9fgQPsCxo/8uyGjNYOCDAEp wAR5ioBZ3TKFXt5cW8Goway3mX97UutpkEJTXGgvxiDOnDgj97DpLHOe7yfNYiolPoE9 O9pQ== X-Forwarded-Encrypted: i=1; AHgh+RruignO+cc8AUGUgnwAG92OZCxAQcmuPv0LLoLnMR8uQNBPZreFdB4w7kUSVNEgt9q68KMmhK6arBYlQdo=@vger.kernel.org X-Gm-Message-State: AOJu0YxS4kuH0ap91eI/Vls4MI6yk6tKySijc3y+e3YnGO7dg9bq6Ap7 OjYwtOfb0Af0+8WCar6cxrY/4keii7pfhAzOqhvo18v9ki6etPOzNThQlj5MwJDSjVjQIK4VEeu Kz8+OXMU4uTrWCS4oI+z9W6q7swnj3g7YhcDVgMofRqhD6PxSbBo4Xq4K5ekZVtK5Zk4= X-Gm-Gg: AR+sD11N9Y7Msr6L9QcZ+O8imlzeEhXuwy8ZPMb4UrhLAh6R45+thRqkF9LdzUkAobj PIblsrw5EhQ/IRym95guc50q+A22FSjptlfmaK/LuATZgdzdE0llFyHEP7JE6VqlVpjC55o0iJA bcgLRiY9WM829Z540Z5CW2xXkvhzSgGZaGvD/XmbI6OdgjdW2XIv64fBs+twVbjzXY9wEXHj3l1 sTtWrrQ0/wjwiKsZQxQtje5B3n8YcqvZKSMuXvq4ncco1t5KyG/wOQRj6nAaZv6nRiHAJmaDffk JPPzdzmhn5grooUmStk4rCFTPXbieBZqAHGrLLlteyodN1Wg3ECVW9HcU76DOt2KjIPY7IWmeT+ kEiivQuUBS74hXCi3t//yV7lG X-Received: by 2002:ac8:5cc2:0:b0:51c:11b4:6b24 with SMTP id d75a77b69052e-52846fdf76amr2142501cf.3.1784808319832; Thu, 23 Jul 2026 05:05:19 -0700 (PDT) X-Received: by 2002:ac8:5cc2:0:b0:51c:11b4:6b24 with SMTP id d75a77b69052e-52846fdf76amr2142091cf.3.1784808319339; Thu, 23 Jul 2026 05:05:19 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69f345b1b9dsm1994224a12.6.2026.07.23.05.05.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 05:05:18 -0700 (PDT) Message-ID: <5d6da74a-785c-4c02-b065-876d8a46f2b2@oss.qualcomm.com> Date: Thu, 23 Jul 2026 14:05:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: add initial Motorola Moto E4 (perry) support To: Aneesh Pradhan , Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Catherine Frederick , linux-clk@vger.kernel.org, Aneesh Pradhan References: <20260723012431.48499-1-aneeshpradhan@acm.org> <20260723014627.63310-1-aneeshpradhan@acm.org> <20260723014627.63310-4-aneeshpradhan@acm.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260723014627.63310-4-aneeshpradhan@acm.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Q53iJY2a c=1 sm=1 tr=0 ts=6a620381 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=DhTvykhhAAAA:8 a=QjXiKPweKVnjtAxLVzIA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=bLiRU7DCRrRo9wiowOr6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDExOSBTYWx0ZWRfX5FtUVTFjouhs z7JdBd1eG6VlrvvPa0XsCWm7QC++IezQZtXL78sAmoyKlroxLajXYg6hPK3470yXGDlqI8ipWAv yChhFdmj6ze0T7IPQx/ZmkcBWdXuxlY= X-Proofpoint-GUID: W6XVXFEHsw3JTPAasLOobefuVYwamI4s X-Proofpoint-ORIG-GUID: W6XVXFEHsw3JTPAasLOobefuVYwamI4s X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDExOSBTYWx0ZWRfX1F1LfX6fUT+L N+dAxCnXNax4xRCFGDOwX365t+ccwt+uOVhewbpkczZUwBoTHnjDFNy+wXYCIRDF+FMOIeS8psW PgJActimHL85WtbbpbE/j441pcOoS9s4vyDJoGsTqfbCYdgiBUzHjWvpNk3GuyZz5JRVHbquByC hZ9PpbzsF7RFiSm9GJwe0iR3cPmywjcioZHZVqhEyewwx7MErq+wzHLPHH8r+TUu8QSir7QJ3wn u2z4OM7IgnWehOmuXSxDuL4YxwfGNugpMIAdb7ZK6iyUy644jWKPd5/yIHsrVkPJPclWMq2CIBi JS95QFCwpvIWhMA5pQ74SMHr6q0iJICVHWnOpGHCGg2pkd36//7KdEZZUkD/0PJZwrverbERtEl jhbYoJSYQeydal2oBniswi6WDVrm665c4YMaK+yhv2rNWN6hOa4pNHTjQtD3rUhrOMmWINo8JS3 UJo6ZbXyv6qgJHFiOnQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_03,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230119 On 7/23/26 3:46 AM, Aneesh Pradhan wrote: > From: "Catherine Frederick (coolguy)" > > Add MSM8917 and MSM8920 board files for the Motorola Moto E4 (perry) > sharing a common dtsi, shaped against in-tree msm8917-xiaomi-wingtech / > msm8937-xiaomi-land so every referenced label exists on mainline. Do we know whether both MSM8917 and MSM8920 variants actually exist in the wild? It's common practice for vendors to include an oversized set of msm-ids in their downstream forks, either because of negligence or because decisions change during product development. > > Initial subset: regulators, eMMC/SD, USB OTG (gpio extcon), gpio-keys, > Synaptics RMI4 touchscreen, BMA253 via i2c-gpio, WCNSS Wi-Fi > (qcom,wcn3660b), and PMI8950 WLED. > > Deferred (missing mainline SoC/PMIC nodes or drivers): DSI panel/MDSS, > IPA, QDSP6/WCD audio, PMI8950 FG/smbcharger, modem/ADSP/Venus remoteprocs. > > Validated on XT1765 under postmarketOS with a fuller fork DT carry; this > is the trimmed upstream-first subset. You should definitely validate the changes you send on their own, atop linux-next/master [...] > + /* Early console deferred with MDSS; panel driver not upstream yet. */ > + stdout-path = "framebuffer0"; > + > + framebuffer0: framebuffer@90001000 { > + compatible = "simple-framebuffer"; > + reg = <0x0 0x90001000 0x0 (720 * 1280 * 3)>; Please use memory-region instead of reg here > + width = <720>; > + height = <1280>; > + stride = <(720 * 3)>; > + format = "r8g8b8"; > + > + clocks = <&gcc GCC_MDSS_AHB_CLK>, > + <&gcc GCC_MDSS_AXI_CLK>, > + <&gcc GCC_MDSS_VSYNC_CLK>, > + <&gcc GCC_MDSS_MDP_CLK>, > + <&gcc GCC_MDSS_BYTE0_CLK>, > + <&gcc GCC_MDSS_PCLK0_CLK>, > + <&gcc GCC_MDSS_ESC0_CLK>; > + power-domains = <&gcc MDSS_GDSC>; > + status = "disabled"; Is this disable an oversight? > +&blsp1_i2c3 { > + status = "okay"; > + > + touchscreen@20 { > + compatible = "syna,rmi4-i2c"; > + reg = <0x20>; > + interrupt-parent = <&tlmm>; > + interrupts = <65 IRQ_TYPE_EDGE_FALLING>; interrupts-extended = <&tlmm 65 IRQ.. [...] > +&usb { > + extcon = <&usb_id>, <&usb_id>; > + dr_mode = "otg"; > + status = "okay"; Please uniformly keep a \n before 'status' [...] > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8920-motorola-perry.dts > @@ -0,0 +1,20 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2025 Val Packett I'm confused as to why Val Packett's copyright is there. Is that the same person as the aforementioned Catherine Frederick? Konrad