mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Mayank Chopra <mak.chopra@codeaurora.org>
Subject: Re: [PATCH v2 5/5] misc: fastrpc: free dma buf scatter list
Date: Wed, 04 Sep 2019 22:11:55 -0700	[thread overview]
Message-ID: <5d70991c.1c69fb81.c0590.2f13@mx.google.com> (raw)
In-Reply-To: <20190829092926.12037-6-srinivas.kandagatla@linaro.org>

Quoting Srinivas Kandagatla (2019-08-29 02:29:26)
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index eee2bb398947..47ae84afac2e 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -550,6 +550,7 @@ static void fastrpc_dma_buf_detatch(struct dma_buf *dmabuf,

Is the function really called buf_detatch? Is it supposed to be
buf_detach?

>         mutex_lock(&buffer->lock);
>         list_del(&a->node);
>         mutex_unlock(&buffer->lock);
> +       sg_free_table(&a->sgt);
>         kfree(a);

  reply	other threads:[~2019-09-05  5:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29  9:29 [PATCH v2 0/5] misc: fastrpc: few fixes Srinivas Kandagatla
2019-08-29  9:29 ` [PATCH v2 1/5] misc: fastrpc: Reference count channel context Srinivas Kandagatla
2019-08-29  9:29 ` [PATCH v2 2/5] misc: fastrpc: Don't reference rpmsg_device after remove Srinivas Kandagatla
2019-08-29  9:29 ` [PATCH v2 3/5] misc: fastrpc: remove unused definition Srinivas Kandagatla
2019-08-29  9:29 ` [PATCH v2 4/5] misc: fastrpc: fix double refcounting on dmabuf Srinivas Kandagatla
2019-08-29  9:29 ` [PATCH v2 5/5] misc: fastrpc: free dma buf scatter list Srinivas Kandagatla
2019-09-05  5:11   ` Stephen Boyd [this message]
2019-09-05  8:15     ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d70991c.1c69fb81.c0590.2f13@mx.google.com \
    --to=swboyd@chromium.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mak.chopra@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome