From: Johannes Berg <johannes@sipsolutions.net>
To: "Uday Shankar" <ushankar@purestorage.com>,
"Breno Leitao" <leitao@debian.org>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Simon Horman" <horms@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jonathan Corbet" <corbet@lwn.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 1/2] net, treewide: define and use MAC_ADDR_LEN
Date: Wed, 05 Feb 2025 08:25:46 +0100 [thread overview]
Message-ID: <5d70ec0708ec351efb530a53f0a2c6ad0503bcbb.camel@sipsolutions.net> (raw)
In-Reply-To: <20250204-netconsole-v2-1-5ef5eb5f6056@purestorage.com>
On Tue, 2025-02-04 at 14:41 -0700, Uday Shankar wrote:
> There are a few places in the tree which compute the length of the
> string representation of a MAC address as 3 * ETH_ALEN - 1. Define a
> constant for this and use it where relevant. No functionality changes
> are expected.
True ... but is "MAC_ADDR_LEN" really an appropriate name for that? Just
plain reading the subject, my first thought was why you weren't going to
use ETH_ALEN.
Would seem nicer to me, at least, to have something indicating a
*string* in there, e.g. MAC_ADDR_STR_LEN or so.
johannes
next prev parent reply other threads:[~2025-02-05 7:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 21:41 [PATCH v2 0/2] netconsole: allow selection of egress interface via MAC address Uday Shankar
2025-02-04 21:41 ` [PATCH v2 1/2] net, treewide: define and use MAC_ADDR_LEN Uday Shankar
2025-02-05 7:25 ` Johannes Berg [this message]
2025-02-06 9:31 ` kernel test robot
2025-02-04 21:41 ` [PATCH v2 2/2] netconsole: allow selection of egress interface via MAC address Uday Shankar
2025-02-05 19:07 ` Breno Leitao
2025-02-05 20:46 ` Uday Shankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d70ec0708ec351efb530a53f0a2c6ad0503bcbb.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
--cc=srinivas.kandagatla@linaro.org \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®