mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kemeng Shi <shikemeng@huaweicloud.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	linux-ext4@vger.kernel.org,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Theodore Ts'o <tytso@mit.edu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] ext4: avoid buffer_head leak in ext4_mark_inode_used
Date: Thu, 15 Aug 2024 21:17:10 +0800	[thread overview]
Message-ID: <5d75ab7f-0fad-07ef-bbcb-3fed16a5170e@huaweicloud.com> (raw)
In-Reply-To: <fec59d4d-898d-447c-b4fb-e9d055550f96@web.de>



on 8/15/2024 5:55 PM, Markus Elfring wrote:
>> Release inode_bitmap_bh from ext4_read_inode_bitmap in
>> ext4_mark_inode_used to avoid buffer_head leak.
>> By the way, remove unneeded goto for invalid ino when inode_bitmap_bh
>> is NULL.
> 
> 1. I suggest to split such changes into separate update steps.
>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc3#n81
It's acceptable to me, but I'm not sure if it worth separate patches
to others. I will do separate in next version if no person is against
this.
> 
> 2. How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
> 
> 3. Would you like to append parentheses to any function names?
Thanks for remind me of these. I will improve the series in next
version.

Thanks,
Kemeng
> 
> Regards,
> Markus
> 


  reply	other threads:[~2024-08-15 13:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13 12:07 [PATCH 0/7] Fixes and cleanups to ext4 ialloc Kemeng Shi
2024-08-13 12:07 ` [PATCH 1/7] ext4: avoid buffer_head leak in ext4_mark_inode_used Kemeng Shi
2024-08-15  9:55   ` Markus Elfring
2024-08-15 13:17     ` Kemeng Shi [this message]
2024-08-15 14:49       ` Darrick J. Wong
2024-08-16  6:56         ` Markus Elfring
2024-08-16 16:35           ` Theodore Ts'o
2024-08-13 12:07 ` [PATCH 2/7] ext4: avoid potential buffer_head leak in __ext4_new_inode Kemeng Shi
2024-08-14  8:48   ` Zhang Yi
2024-08-15  1:36     ` Kemeng Shi
2024-08-13 12:07 ` [PATCH 3/7] ext4: avoid negative min_clusters in find_group_orlov Kemeng Shi
2024-08-13 12:07 ` [PATCH 4/7] ext4: remove dead check in __ext4_new_inode Kemeng Shi
2024-08-13 12:07 ` [PATCH 5/7] ext4: move checksum length calculation of inode bitmap into ext4_inode_bitmap_csum_[verify/set] functions Kemeng Shi
2024-08-13 12:07 ` [PATCH 6/7] ext4: remove unneeded NULL check of buffer_head in ext4_mark_inode_used Kemeng Shi
2024-08-13 12:07 ` [PATCH 7/7] ext4: check buffer_verified in advance to avoid unneeded ext4_get_group_info Kemeng Shi
2024-08-15 11:13   ` Markus Elfring
2024-08-15 13:17     ` Kemeng Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d75ab7f-0fad-07ef-bbcb-3fed16a5170e@huaweicloud.com \
    --to=shikemeng@huaweicloud.com \
    --cc=Markus.Elfring@web.de \
    --cc=adilger.kernel@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®