mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Clark <james.clark@linaro.org>
To: TAKANO Mitsuhiro <takano32@gmail.com>
Cc: Ian Rogers <irogers@google.com>,
	linux-kernel@vger.kernel.org,
	Shunsuke Nakamura <nakamura.shun@fujitsu.com>,
	John Garry <john.garry@linux.dev>,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf vendor events arm64: Fix typos in event descriptions
Date: Mon, 9 Nov 2026 10:20:25 +0000	[thread overview]
Message-ID: <5d77f0ed-e175-47f6-af0a-050e0bbc66c7@linaro.org> (raw)
In-Reply-To: <20261108184654.3811267-1-takano32@gmail.com>



On 08/11/2026 18:46, TAKANO Mitsuhiro wrote:
> Six entries in common-and-microarch.json spell Statistical as "Statisical"
> (the SAMPLE_FEED_* events), and one entry in the Fujitsu a64fx table, the
> L2HWPF_STREAM_PF event, spells prefetcher as "prefecher" in both its
> BriefDescription and its PublicDescription.
> 
> The SAMPLE_FEED_* events are inherited through ArchStdEvent by the
> neoverse-n3, neoverse-v3 and t410 tables, so the misspelling reaches those
> three generated tables.  The a64fx pair appears once, because the long
> description is dropped when it equals the brief one.
> 
> Spell the words correctly.  Event names, codes and expressions are
> unchanged.
> 
> Written with Hermes Agent, an LLM assistant.  Running jevents.py for arm64
> before and after this change removes 12 occurrences of "Statisical" and the
> one "prefecher" from the generated string table; perf was not rebuilt.
> 
> Fixes: 994256a79867 ("perf vendor events arm64: Add N3 events/metrics")
> Fixes: 5497b23e870c ("perf vendor events arm64: Add Fujitsu A64FX pmu event")
> Signed-off-by: TAKANO Mitsuhiro <takano32@gmail.com>
> ---
>   .../pmu-events/arch/arm64/common-and-microarch.json  | 12 ++++++------
>   .../pmu-events/arch/arm64/fujitsu/a64fx/other.json   |  4 ++--
>   2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/arch/arm64/common-and-microarch.json b/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
> index 144325d87be4..c61d6c0ceb4f 100644
> --- a/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
> +++ b/tools/perf/pmu-events/arch/arm64/common-and-microarch.json
> @@ -1340,32 +1340,32 @@
>       {
>           "EventCode": "0x812A",
>           "EventName": "SAMPLE_FEED_BR",
> -        "BriefDescription": "Statisical Profiling sample taken, branch"
> +        "BriefDescription": "Statistical Profiling sample taken, branch"
>       },
>       {
>           "EventCode": "0x812B",
>           "EventName": "SAMPLE_FEED_LD",
> -        "BriefDescription": "Statisical Profiling sample taken, load"
> +        "BriefDescription": "Statistical Profiling sample taken, load"
>       },
>       {
>           "EventCode": "0x812C",
>           "EventName": "SAMPLE_FEED_ST",
> -        "BriefDescription": "Statisical Profiling sample taken, store"
> +        "BriefDescription": "Statistical Profiling sample taken, store"
>       },
>       {
>           "EventCode": "0x812D",
>           "EventName": "SAMPLE_FEED_OP",
> -        "BriefDescription": "Statisical Profiling sample taken, matching operation type"
> +        "BriefDescription": "Statistical Profiling sample taken, matching operation type"
>       },
>       {
>           "EventCode": "0x812E",
>           "EventName": "SAMPLE_FEED_EVENT",
> -        "BriefDescription": "Statisical Profiling sample taken, matching events"
> +        "BriefDescription": "Statistical Profiling sample taken, matching events"
>       },
>       {
>           "EventCode": "0x812F",
>           "EventName": "SAMPLE_FEED_LAT",
> -        "BriefDescription": "Statisical Profiling sample taken, exceeding minimum latency"
> +        "BriefDescription": "Statistical Profiling sample taken, exceeding minimum latency"
>       },
>       {
>           "EventCode": "0x8130",
> diff --git a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json
> index 10c823ac26cc..6fa2936e427d 100644
> --- a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json
> +++ b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json
> @@ -162,10 +162,10 @@
>       "BriefDescription": "This event counts non-allocation type prefetch injection requests to L1D cache generated by hardware prefetcher."
>     },
>     {
> -    "PublicDescription": "This event counts streaming prefetch requests to L2 cache generated by hardware prefecher.",
> +    "PublicDescription": "This event counts streaming prefetch requests to L2 cache generated by hardware prefetcher.",
>       "EventCode": "0x233",
>       "EventName": "L2HWPF_STREAM_PF",
> -    "BriefDescription": "This event counts streaming prefetch requests to L2 cache generated by hardware prefecher."
> +    "BriefDescription": "This event counts streaming prefetch requests to L2 cache generated by hardware prefetcher."
>     },
>     {
>       "PublicDescription": "This event counts allocation type prefetch injection requests to L2 cache generated by hardware prefetcher.",
> 
> base-commit: d48723711bae9b8cdc56719c448ba42fef28cbee

Reviewed-by: James Clark <james.clark@linaro.org>


      reply	other threads:[~2026-11-09 10:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08 18:46 TAKANO Mitsuhiro
2026-11-09 10:20 ` James Clark [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d77f0ed-e175-47f6-af0a-050e0bbc66c7@linaro.org \
    --to=james.clark@linaro.org \
    --cc=acme@kernel.org \
    --cc=irogers@google.com \
    --cc=john.garry@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=nakamura.shun@fujitsu.com \
    --cc=namhyung@kernel.org \
    --cc=takano32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®