From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43295E7B5E4 for ; Wed, 4 Oct 2023 09:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242041AbjJDJiK (ORCPT ); Wed, 4 Oct 2023 05:38:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242018AbjJDJiI (ORCPT ); Wed, 4 Oct 2023 05:38:08 -0400 Received: from mail.tuxedocomputers.com (mail.tuxedocomputers.com [157.90.84.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D7ACBB; Wed, 4 Oct 2023 02:38:04 -0700 (PDT) Received: from [192.168.42.20] (unknown [91.22.66.69]) (Authenticated sender: wse@tuxedocomputers.com) by mail.tuxedocomputers.com (Postfix) with ESMTPSA id D0AF02FC0010; Wed, 4 Oct 2023 11:38:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxedocomputers.com; s=default; t=1696412282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9EHI8fHLnGoVd2F2Ocb2wELrRiN7lJQWOBGnepKa2sM=; b=HeIJy8femgJ2hQmkH3yfw7h1BlAmQrTVdUZFsPT4vK/KN3okjt+Dk5xXHaBerYgQ8/jTg0 wn8h0uA/vev4YGP05v8/BSfMZFaOIDsM1yhXtSc1M5Ryn/ClJENEnrU++eOKwchB7clOsj gGBikXsCqGLOl5uCmpO3EuygaoaQ6ac= Authentication-Results: mail.tuxedocomputers.com; auth=pass smtp.auth=wse@tuxedocomputers.com smtp.mailfrom=wse@tuxedocomputers.com Message-ID: <5d82fcac-a360-2d8b-8f6a-9b5cecb08ca2@tuxedocomputers.com> Date: Wed, 4 Oct 2023 11:38:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] ACPI: resource: Do IRQ override on TongFang GMxXGxx To: "Rafael J. Wysocki" Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230929134010.25644-1-wse@tuxedocomputers.com> Content-Language: en-US From: Werner Sembach In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 03.10.23 um 20:39 schrieb Rafael J. Wysocki: > On Fri, Sep 29, 2023 at 3:40 PM Werner Sembach wrote: >> The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding >> for the keyboard to work. Adding an entry for this laptop to the >> override_table makes the internal keyboard functional again. > You said "again", so it used to work. Do you know which commit broke it? Sorry that "again" is a bit misleading. I Copied it from here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7592b79ba4a9 I actually only tested the direct predecessor of this Notebook on older kernels: https://bugzilla.kernel.org/show_bug.cgi?id=216698 I suspected that it's the same issue and since the same fix worked I now even more believe so, but I actually never tested a kernel before the breaking change. > >> Signed-off-by: Werner Sembach >> Cc: > What's the oldest kernel version you want this to be applied to? 5.15 because Ubuntu 22.04 Kind regards, Werner Sembach > >> --- >> drivers/acpi/resource.c | 16 ++++++++++++++-- >> 1 file changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c >> index 32cfa3f4efd3d..3aff81820e321 100644 >> --- a/drivers/acpi/resource.c >> +++ b/drivers/acpi/resource.c >> @@ -470,13 +470,25 @@ static const struct dmi_system_id asus_laptop[] = { >> { } >> }; >> >> -static const struct dmi_system_id tongfang_gm_rg[] = { >> +static const struct dmi_system_id tongfang_gm[] = { >> { >> .ident = "TongFang GMxRGxx/XMG CORE 15 (M22)/TUXEDO Stellaris 15 Gen4 AMD", >> .matches = { >> DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"), >> }, >> }, >> + { >> + .ident = "TongFang GMxXGxx/TUXEDO Polaris 15 Gen5 AMD", >> + .matches = { >> + DMI_MATCH(DMI_BOARD_NAME, "GMxXGxx"), >> + }, >> + }, >> + { >> + .ident = "TongFang GM6XGxX/TUXEDO Stellaris 16 Gen5 AMD", >> + .matches = { >> + DMI_MATCH(DMI_BOARD_NAME, "GM6XGxX"), >> + }, >> + }, >> { } >> }; >> >> @@ -536,7 +548,7 @@ struct irq_override_cmp { >> static const struct irq_override_cmp override_table[] = { >> { medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false }, >> { asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false }, >> - { tongfang_gm_rg, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true }, >> + { tongfang_gm, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true }, >> { maingear_laptop, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true }, >> { pcspecialist_laptop, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1, true }, >> { lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false }, >> -- >> 2.34.1 >>