mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Song Liu <song@kernel.org>, linan666@huaweicloud.com
Cc: bingjingc@synology.com, allenpeng@synology.com,
	alexwu@synology.com, shli@fb.com, neilb@suse.de,
	linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
	linan122@huawei.com, yi.zhang@huawei.com, houtao1@huawei.com,
	yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v2 1/4] md/raid10: fix null-ptr-deref of mreplace in raid10_sync_request
Date: Sat, 27 May 2023 09:17:45 +0800	[thread overview]
Message-ID: <5d836b41-2dff-e829-2e18-97ea4565b5bc@huaweicloud.com> (raw)
In-Reply-To: <CAPhsuW5ThXyAL2rAyWZC31etY27fqsG+eFHcHtzfCS9Da4bosw@mail.gmail.com>

Hi,

在 2023/05/27 5:38, Song Liu 写道:
> On Fri, May 26, 2023 at 12:47 AM <linan666@huaweicloud.com> wrote:                    }
> 
> To make sure I understand the issue correctly:
> 
> The null-ptr-deref only happens when the Faulty bit was set after the
> last check and before this check below, right?

Yes, you're right.

Thanks,
Kuai
> 
>> -                       if (mreplace && test_bit(Faulty, &mreplace->flags))
>> -                               mreplace = NULL;
>>                          /* Unless we are doing a full sync, or a replacement
>>                           * we only need to recover the block if it is set in
>>                           * the bitmap
> 
> Thanks,
> Song
> 


  reply	other threads:[~2023-05-27  1:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26  7:45 [PATCH v2 0/4] raid10 bugfix linan666
2023-05-26  7:45 ` [PATCH v2 1/4] md/raid10: fix null-ptr-deref of mreplace in raid10_sync_request linan666
2023-05-26 21:38   ` Song Liu
2023-05-27  1:17     ` Yu Kuai [this message]
2023-05-27  1:28     ` Li Nan
2023-05-27  1:21   ` Yu Kuai
2023-05-27  1:29     ` Li Nan
2023-05-26  7:45 ` [PATCH v2 2/4] md/raid10: improve code of mrdev " linan666
2023-05-27  1:41   ` Yu Kuai
2023-05-26  7:45 ` [PATCH v2 3/4] md/raid10: fix incorrect done of recovery linan666
2023-05-26  7:45 ` [PATCH v2 4/4] md/raid10: fix io loss while replacement replace rdev linan666

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d836b41-2dff-e829-2e18-97ea4565b5bc@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=alexwu@synology.com \
    --cc=allenpeng@synology.com \
    --cc=bingjingc@synology.com \
    --cc=houtao1@huawei.com \
    --cc=linan122@huawei.com \
    --cc=linan666@huaweicloud.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=shli@fb.com \
    --cc=song@kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®