From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B6F42580F2 for ; Mon, 22 Dec 2025 10:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766397807; cv=none; b=BeuYYDTi/73Q4DZwlbq3jH9QN6sfpGqR9iur0FuggGX6JJBv/9jUquZr/9gQ/IM3YwvURSl/UWVDZdZH6NcIdyI1Th6dsVUfYZKqzXPdO/N4rNgeaGu44xd35Ume2Fk8IvHhxzWFCjVKVSiyb16BUVT5ZC7ckxzVY76a46sK7a4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766397807; c=relaxed/simple; bh=7r/hHIr9s5n58sQ6EVtc9ZEHJMJqF1KkEnSmwvuZe2w=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=bQYRG0hByJ3KQ4cXRu3nGW3pHzX2aoqwrVi1l9fBF90CuV93oii9td+9ppXJVTwMRE/80bjg3EE25/nJzzpFPmosEI/haJJyUJIsXRHCUW/TGGP+Ri19VbqOa7hQki6WsE7ySoXfMyhRvHJYMt5Fucy8nwQILbZTVe0zAwGJzGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KhBxwB7+; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KhBxwB7+" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4775ae77516so34206465e9.1 for ; Mon, 22 Dec 2025 02:03:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1766397803; x=1767002603; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=VPwuYzfJbD0huZhrwrbt9JDgu1VnggIdoXIg1UE2EZU=; b=KhBxwB7+k3IMV6wqAFLORnnDntvPo0+7rERA25Y4vTjsCEOPFrNBS+N1B3AfLa96TK DtC9Dtdo0nqc/sDhrBnLCuc51+25/8I6kIivSSk+AUQAtgafQxPFD0JJLB5O6Vj4BTYP lYbSZVFj9YATjrzMfbzbrfpR8JaBpQaxcL6vMqPZ1FnGC52HBMVU2HXi0LZGOD4iiIW9 PHWW9pqLGmKQrzQJkmV4ilAvvWLGAEZ7sZuhgsLXCLLMGJj68rMn9sdJwZR+bP80oqmE Zhwbk/C8BG9Rm8qKnpHEWF5/F54NxIEKJByEVARenAjKMc9rpBbusIA3IrAJzobWuY1P kx6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766397803; x=1767002603; h=mime-version:user-agent:content-transfer-encoding:organization :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VPwuYzfJbD0huZhrwrbt9JDgu1VnggIdoXIg1UE2EZU=; b=PlMgPJuYI8v2bRav+LoiFllW8ymcJGONjLPG+pxImVYn/W4Ib52vu/VKJnB5WEbKME wlhwKjNdgKtI5p2Rdo4P1A7L8FJB+ZcRDsxm/OhlxeOw8wnEruAnwUCfoJGhAwDEGnMw 01v8E3R7BgIyN8wBdUcAfGuTGGRGKOnP57gsyp96Sf/wkJat2684biQ9lxV5uR626OI7 352fC+/h0pluYcV8VkG3B+Uvm/kNAbBcGPLLe918dyI6tmLEjyezp3mz2afMInuoTJ48 M5Ex4wmGXjDtzHDQXNpvOwoczDgc+aP19lhqwZ1InNNUOgYRKQsNaY+CquaYtX5cj54Z l21Q== X-Forwarded-Encrypted: i=1; AJvYcCX1xCO2Sms5ryNq4lzcl8LidXzsGt7r00O4nGX2pxFiSSSnA6G1ao4cZFr0u/J2+HvqckbSU9xCLSNGA24=@vger.kernel.org X-Gm-Message-State: AOJu0YwjHkL34SsKg3KAbj7ef6HM3EhljpLf+x6owbCviCyziaEtI+j/ EMN7O5drRFPE/JPFD7VJdw3iBK3pg+ra0/v0G8Ymvq3GR1VmnWRB7Fmz/4TrbcArLFQ= X-Gm-Gg: AY/fxX7ugBVX8UpM42XZCXYPU5DBv/+xrTZVp6I7nEtu0dQ0yL5A3Ep3Ktb7/4gWIX+ TZEQa5dERj3Lakv9zk27ZhAeQUM8QsTeyrt3SbTJ+yEHBE7EakfC/K1tJpjIPR1xZ9lkshaOD7O YwUy27k78fTMlS8+7t6u4xrRRLz6uP2fmw1C6wPVyDlxx6CmJCL0LYv6EooOVVqujFXeZxE/cr9 RpC9ZXNyTTSrSDT7NiMa4dKXkzMhhg9QttVZV38PG0WyiTIQ1Ackrzpff8qPoVw82wYHdn4xcZf QYHnqhENijcYBkzhrf3LUnjoBwZdcZflQrNl14sxSH6Il+13WEidfx1rkkfJlQRM65BhY8z24fI zGKXVwZGOHDyk+yHMzb2Jg4hRas5CGM+kiLz1RVhialcck3ZaMQ8YcOnwtOcNdZ3qj7E+EXlUuO dgKrXrXLBnrmIQlYII8OgV0eEwHuHCgaD9Jnx641/3jsPE1I3k1g== X-Google-Smtp-Source: AGHT+IH+w7gIXMHEGP+405bV3HAMn3Mn3ZtitH8FbqQDrOHikBwWdS7U6F6L0tIQWa4zK/iQC+gR+A== X-Received: by 2002:a05:600c:8718:b0:479:1a0a:ebbe with SMTP id 5b1f17b1804b1-47d25082cc8mr60281135e9.14.1766397803388; Mon, 22 Dec 2025 02:03:23 -0800 (PST) Received: from ?IPv6:2a01:e0a:1d:5380:6cdc:9dff:7d8c:ff76? ([2a01:e0a:1d:5380:6cdc:9dff:7d8c:ff76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193522cdsm174899765e9.4.2025.12.22.02.03.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 02:03:22 -0800 (PST) Message-ID: <5d87f4c294be78dc7a4bc39de9883779aba6fa9e.camel@suse.com> Subject: Re: [PATCH 1/1] firmware: dmi-id: add product_family to modalias as pf From: Jean DELVARE To: Crag Wang Cc: dell.client.kernel@dell.com, crag.wang@dell.com, linux-kernel@vger.kernel.org Date: Mon, 22 Dec 2025 11:03:21 +0100 In-Reply-To: <20250814064443.1278029-1-crag0715@gmail.com> References: <20250814064443.1278029-1-crag0715@gmail.com> Organization: SUSE Linux Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Crag, On Thu, 2025-08-14 at 14:44 +0800, Crag Wang wrote: > Some devices require product_family information to trigger > conditional actions when the value matches a predefined criterion >=20 > $ cat /sys/class/dmi/id/product_family > Dell Pro Max Desktops >=20 > $ udevadm info -q all --path=3D/sys/class/dmi/id | grep MODALIAS > E: MODALIAS=3Ddmi:bvnDellInc.:bvr0.59.39:bd12/16/2024:br0.59:efr0.0:svnDe= llInc.:pfDellProMaxDesktops:pnDellProMaxMicroFCM2250:pvr:rvnDellInc.:rn:rvr= :cvnDellInc.:ct3:cvr:sku0D14: >=20 > $ cat /sys/class/dmi/id/modalias > dmi:bvnDellInc.:bvr0.59.39:bd12/16/2024:br0.59:efr0.0:svnDellInc.:pfDellP= roMaxDesktops:pnDellProMaxMicroFCM2250:pvr:rvnDellInc.:rn:rvr:cvnDellInc.:c= t3:cvr:sku0D14: >=20 > Signed-off-by: Crag Wang > --- > =C2=A0drivers/firmware/dmi-id.c | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c > index d19c78a78ae3..284652d75cc7 100644 > --- a/drivers/firmware/dmi-id.c > +++ b/drivers/firmware/dmi-id.c > @@ -87,6 +87,7 @@ static ssize_t get_modalias(char *buffer, size_t buffer= _size) > =C2=A0 { "br",=C2=A0 DMI_BIOS_RELEASE }, > =C2=A0 { "efr", DMI_EC_FIRMWARE_RELEASE }, > =C2=A0 { "svn", DMI_SYS_VENDOR }, > + { "pf",=C2=A0 DMI_PRODUCT_FAMILY }, > =C2=A0 { "pn",=C2=A0 DMI_PRODUCT_NAME }, > =C2=A0 { "pvr", DMI_PRODUCT_VERSION }, > =C2=A0 { "rvn", DMI_BOARD_VENDOR }, For consistency, I'd rather add it between DMI_PRODUCT_VERSION and DMI_BOARD_VENDOR. That's simple enough, so why not. Out of curiosity, which udev rule (and/or driver) needs this? --=20 Jean Delvare SUSE L3 Support