From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=194.13.80.246 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793705982; b=uBSuj93+W60nF7aSAFUAPu74P9E+HX9/mrivxcCGtKVbu7RNnsP7UzROUFOQLSqsK0aN w9GaeF23hpIH98MLYeBwfqHnTrC9fYaJZ0ruVUwuJJjR4Ux5+oMBRNT6+T675w/xOgGIX qntzTDFTJwInoqcXFK8bvZZof4+vAKpX8YXRFf3M21xIuyzr3xapfWhloRDLTL8b4pXUa XUbb2KxyEm8QJFZjhuXEaDWB2ZRGj+Q+I7MHxtlRh8krn7oOrDSrO4iYY/VyQboFLQisF dlWTcSdURtTdvN9q6tgUSS17coQ0Hh8lDpAk0zqXyEZIMHoG+4a7p4q+OpV0n+1ifRg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793705982; h=DMARC-Filter:Received:DKIM-Signature:MIME-Version:Date:From:To:Cc: Subject:In-Reply-To:References:Message-ID:X-Sender:Content-Type: Content-Transfer-Encoding:X-Last-TLS-Session-Version; bh=PIHEnWIzZ7nCqKK2g4F2Wla4/XfshctWrwjq2tgtt+w=; b=tg86JwsQSNIXZhikGLC0V7ei92xUfftwbtgDe4UPfc8muGXz9NY+MhI8XuVaN0D0Bu7V cFOmxTt5gl2IA3J4CHWSt8/fGViqWjfix53CI0gE0LK3o3NyGfXPzUEE1e25+Nb23OpcA OczXgbEUZoXZg4s9p9InWt+sn2P0HKhn4iidlTuNgsSZcJeuXbFEO7Ywf55bK3qT6Lp+M /jtUEhcE6idtmEys6+UHnkZsX0Blr37/qshdXujhjcGd8M27EHVnp/UBxdb2Hys65FOKL GYIrSlwhySmwWQIPl7PBu+evygtZvyMdRlF7srpnT/QNL8YYzogCkxI9D4AIsFVip3Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=tipi-net.de; spf=pass smtp.mailfrom=tipi-net.de; dkim=pass header.d=tipi-net.de header.i=@tipi-net.de header.a=rsa-sha256 header.s=dkim header.b=pNhxTM8x; arc=none smtp.remote-ip=194.13.80.246 Received: from mail.tipi-net.de (mail.tipi-net.de [194.13.80.246]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0D09606EEAC; Tue, 3 Nov 2026 11:39:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F0D09606EEAC Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tipi-net.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tipi-net.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=tipi-net.de header.i=@tipi-net.de header.a=rsa-sha256 header.s=dkim header.b=pNhxTM8x Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A1783A160B; Tue, 03 Nov 2026 12:39:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tipi-net.de; s=dkim; t=1793705976; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=PIHEnWIzZ7nCqKK2g4F2Wla4/XfshctWrwjq2tgtt+w=; b=pNhxTM8x0QuNH/4HAX9JxS6/S0GEDfxDqNAVrXFF3mr1gZ7j3wazrQGaHLgdRzyU5JdhKk Kq9hOT7zEasIDJ2fd72bKOumBx7451W82dk74OXvetBPN2wdHj8R5bzeGX5Aw1Gmlm+6o6 OAJcIanD3jHUY2fbqCJQMhMLAC6YpPHEJWrDcEcftcypYoyxn0M1/1SXTyw7sqF1Boz65S 9tEOSkXb2tb3peYTBgRUbra3OqD8iYIC1149XVHUQ9PgGlxxxucZRh35RY6xAEvKQgi7eg RNcDH+vKk+Iops+rgHbvIIHH9tkKkIEmCgZr/sKwzDVO3VDEhHHPjDI3Aectvw== X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Date: Tue, 03 Nov 2026 12:39:15 +0100 From: Nicolai Buchwitz To: Frank.Li@oss.nxp.com Cc: Greg Kroah-Hartman , Jiri Slaby , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Cunhao Lu <1579567540@qq.com>, Raul E Rangel , Yenchia Chen , Zhiyong Tao , Carlo Caione , Moteen Shah , Kendall Willis , Andy Shevchenko , Kartik Rajput , Fan Wu , Karl Mehltretter , =?UTF-8?Q?Stefan_D=C3=B6singer?= , Shitalkumar Gandhi , Peng Fan , Sherry Sun , John Ogness , Pan Chuang , Petr Mladek , Robin Gong , Konrad Dybcio , Stephan Gerhold , Zhaoyang Yu <2426767509@qq.com>, "Nikola Z. Ivanov" , Haoxiang Li , "Mike Rapoport (Microsoft)" , Biju Das , Geert Uytterhoeven , Myeonghun Pak , Wenhua Lin , Cixi Geng , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, vkoul@kernel.org Subject: Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback() In-Reply-To: <20261102175527.3957740-1-Frank.Li@oss.nxp.com> References: <20261102175527.3957740-1-Frank.Li@oss.nxp.com> Message-ID: <5d8894bdaacb407ef5a6cac2c9eacbad@tipi-net.de> X-Sender: nb@tipi-net.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Frank On 2.11.2026 18:54, Frank.Li@oss.nxp.com wrote: > From: Frank Li > > Replace open-coded assignments to callback and callback_param fields > of struct dma_async_tx_descriptor with calls to the > dmaengine_desc_set_callback() helper across serial drivers. > > No functional change intended. Prepare to make struct > dma_async_tx_descriptor private to the DMA engine. > > Signed-off-by: Frank Li > --- > drivers/tty/serial/8250/8250_dma.c | 6 ++---- > drivers/tty/serial/8250/8250_mtk.c | 3 +-- > drivers/tty/serial/8250/8250_omap.c | 6 ++---- > drivers/tty/serial/amba-pl011.c | 6 ++---- > drivers/tty/serial/atmel_serial.c | 6 ++---- > drivers/tty/serial/fsl_lpuart.c | 6 ++---- > drivers/tty/serial/imx.c | 6 ++---- > drivers/tty/serial/msm_serial.c | 6 ++---- > drivers/tty/serial/mxs-auart.c | 6 ++---- > drivers/tty/serial/pch_uart.c | 6 ++---- > drivers/tty/serial/samsung_tty.c | 6 ++---- > drivers/tty/serial/serial-tegra.c | 6 ++---- > drivers/tty/serial/sh-sci.c | 9 +++------ > drivers/tty/serial/sprd_serial.c | 3 +-- > drivers/tty/serial/stm32-usart.c | 6 ++---- > 15 files changed, 29 insertions(+), 58 deletions(-) > [...] > diff --git a/drivers/tty/serial/amba-pl011.c > b/drivers/tty/serial/amba-pl011.c > index e6f652905ca6f..e7373cd11b621 100644 > --- a/drivers/tty/serial/amba-pl011.c > +++ b/drivers/tty/serial/amba-pl011.c > @@ -715,8 +715,7 @@ static int pl011_dma_tx_refill(struct > uart_amba_port *uap) > } > > /* Some data to go along to the callback */ > - desc->callback = pl011_dma_tx_callback; > - desc->callback_param = uap; > + dmaengine_desc_set_callback(desc, pl011_dma_tx_callback, NULL, uap); > > /* All errors should happen at prepare time */ > dmaengine_submit(desc); > @@ -906,8 +905,7 @@ static int pl011_dma_rx_trigger_dma(struct > uart_amba_port *uap) > } > > /* Some data to go along to the callback */ > - desc->callback = pl011_dma_rx_callback; > - desc->callback_param = uap; > + dmaengine_desc_set_callback(desc, pl011_dma_rx_callback, NULL, uap); > dmarx->cookie = dmaengine_submit(desc); > dma_async_issue_pending(rxchan); > [...] Reviewed-by: Nicolai Buchwitz # amba-pl011 Thanks, Nicolai