Re: 回复: [PATCH 1/3] pinctrl: cix: Add pin-controller support for sky1

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/08/2025 08:44, Gary Yang wrote:
>>
>>> +     if (ret) {
>>> +             dev_err(&pdev->dev, "fail to probe dt properties\n");
>>
>> You are printing same error twice. Drop this and just handle error printing in
>> sky1_pinctrl_probe_dt().
>> Especially that you now print errors on ENOMEM.
>>
> 
> Sorry, this print message is only once, not twice, please give more information

Trigger the error and check how many error messages you see. I see two.
You should know your code better than me...

> 
>>> +             return ret;
>>> +     }
>>> +
>>> +     pinctrl_provide_dummies();
>>> +     dev_info(&pdev->dev, "initialized SKY1 pinctrl driver\n");
>>
>>
>> No, please drop. Drivers should be silent on success.
>>
> 
> Ok, replace dev_info with dev_dbg next version


No, it is completely redundant. You are duplicating existing mechanism
for no gain at all.

Best regards,
Krzysztof