mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	Michal Simek <michal.simek@xilinx.com>,
	<linux-kernel@vger.kernel.org>, <monstr@monstr.eu>,
	<gregkh@linuxfoundation.org>, <geert@linux-m68k.org>
Cc: <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH] of: base: Fix english spelling in of_alias_get_alias_list()
Date: Thu, 27 Sep 2018 08:52:49 +0200	[thread overview]
Message-ID: <5d8b8daa-3953-a22d-3cab-5bd1764e4602@xilinx.com> (raw)
In-Reply-To: <dfd94b86-0a71-a2c4-449d-7f06ff3ae30e@infradead.org>

On 26.9.2018 17:34, Randy Dunlap wrote:
> On 9/26/18 4:06 AM, Michal Simek wrote:
>> Fix english spelling in of_alias_get_alias_list().
>>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Greg: Please apply it on the top of tty-next because patch is going via
>> your tree.
> 
> Maybe a few more fixes first...
> 
>> ---
>>  drivers/of/base.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/of/base.c b/drivers/of/base.c
>> index 33011b88ed3f..ffcbb2963ba2 100644
>> --- a/drivers/of/base.c
>> +++ b/drivers/of/base.c
>> @@ -1948,7 +1948,7 @@ int of_alias_get_id(struct device_node *np, const char *stem)
>>   * @matches:	Array of OF device match structures to search in
>>   * @stem:	Alias stem of the given device_node
>>   * @bitmap:	Bitmap field pointer
>> - * @nbits:	Maximum number of alias ID which can be recorded it bitmap
>> + * @nbits:	Maximum number of alias IDs which can be recorded it bitmap
> 
> s/it/in/
> 
>>   *
>>   * The function travels the lookup table to record alias ids for the given
>>   * device match structures and alias stem.
>> @@ -1971,7 +1971,7 @@ int of_alias_get_alias_list(const struct of_device_id *matches,
>>  			 __func__, app->stem, app->id);
>>  
>>  		if (strcmp(app->stem, stem) != 0) {
>> -			pr_debug("%s: stem comparison doesn't passed %s\n",
>> +			pr_debug("%s: stem comparison didn't pass %s\n",
>>  				 __func__, app->stem);
>>  			continue;
>>  		}
>> @@ -1986,7 +1986,7 @@ int of_alias_get_alias_list(const struct of_device_id *matches,
>>  			pr_debug("%s: Allocated ID %d\n", __func__, app->id);
>>  			set_bit(app->id, bitmap);
>>  		}
>> -		/* Alias exist but it not compatible with matches */
>> +		/* Alias exists but it not compatible with matches */
> 
> s/it/is/
> 
>>  	}
>>  	mutex_unlock(&of_mutex);
>>  
>>
> 
> thanks,

I will include these fixes to v2 and will wait for Geert in connection
to discussion we had in origin thread.

Thanks,
Michal



      reply	other threads:[~2018-09-27  7:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 11:06 Michal Simek
2018-09-26 15:34 ` Randy Dunlap
2018-09-27  6:52   ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d8b8daa-3953-a22d-3cab-5bd1764e4602@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®