From: Pavel Skripkin <paskripkin@gmail.com>
To: Wang Cheng <wanngchenng@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: fix uninit-value "data" and "mac"
Date: Sat, 16 Apr 2022 13:57:33 +0300 [thread overview]
Message-ID: <5d9181be-0a02-0623-7741-1d4352d62610@gmail.com> (raw)
In-Reply-To: <20220415095741.3zfuztivtgidvpqc@ppc.localdomain>
Hi Wang,
On 4/15/22 12:57, Wang Cheng wrote:
> Hi Pavel, thx for your review.
>
> Sorry, this patch is just confined to fixing uninit-values with
> modifying the original code as less as possible. It sounds good to
> refactor r8712_usbctrl_vendorreq() with better API.
>
I understand your idea, but this will just hide the real problem until
syzbot hit it in different place. So, I believe, it's better to fix the
root case instead of hiding local cases.
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-04-16 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 14:12 Wang Cheng
2022-04-14 15:42 ` Dan Carpenter
2022-04-14 15:49 ` Dan Carpenter
2022-04-15 9:47 ` Wang Cheng
2022-04-15 9:57 ` Dan Carpenter
2022-04-15 10:51 ` Wang Cheng
2022-05-06 3:07 ` Wang Cheng
2022-04-15 10:02 ` Dan Carpenter
2022-04-14 20:12 ` Pavel Skripkin
2022-04-15 9:57 ` Wang Cheng
2022-04-16 10:57 ` Pavel Skripkin [this message]
2022-04-18 4:00 ` Wang Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d9181be-0a02-0623-7741-1d4352d62610@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=wanngchenng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®