From: Jon Hunter <jonathanh@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] regulator: core: Don't use regulators as supplies until the parent is bound
Date: Wed, 11 Jan 2017 16:57:18 +0000 [thread overview]
Message-ID: <5d9b2cf5-55ef-f389-3381-da101bda7db5@nvidia.com> (raw)
In-Reply-To: <20170110165717.7dfxoyajc5p2h5mr@sirena.org.uk>
On 10/01/17 16:57, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Jan 10, 2017 at 11:01:09AM +0000, Jon Hunter wrote:
>
>> +++ b/drivers/regulator/core.c
>> @@ -1553,6 +1553,11 @@ static int regulator_resolve_supply(struct regulator_dev *rdev)
>> }
>> }
>>
>> + if (r->dev.parent && !device_is_bound(r->dev.parent)) {
>> + put_device(&r->dev);
>> + return -EPROBE_DEFER;
>> + }
>> +
>
> I realised earlier that this will trigger when the supply and the
> consumer are part of the same PMIC which will cause issues as that's a
> fairly common setup and won't be resolved by deferring. Can you please
> modify this to only defer if the parent is not the same as the parent of
> the regulator we're currently resolving? Sorry, should've thought of
> this yesterday.
OK, no problem. Will send out an update shortly.
Cheers
Jon
--
nvpublic
prev parent reply other threads:[~2017-01-11 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 11:01 Jon Hunter
2017-01-10 16:57 ` Mark Brown
2017-01-11 16:57 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d9b2cf5-55ef-f389-3381-da101bda7db5@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®