mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michal Januszewski" <michalj@gmail.com>
To: "Krzysztof Helt" <krzysztof.h1@poczta.fm>
Cc: linux-kernel@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] fbdev: don't allow to set a video mode via vga= if FB doesn't support it
Date: Mon, 22 Sep 2008 22:34:14 +0200	[thread overview]
Message-ID: <5d9b736f0809221334i773a500eu5ff61884729a4367@mail.gmail.com> (raw)
In-Reply-To: <20080922214747.c8bc57eb.krzysztof.h1@poczta.fm>

On Mon, Sep 22, 2008 at 21:47, Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:

> This one could be simpler:
>
>                /* It's a supported text mode */
>                is_graphic = 0;
>  +#if FB_SUPPORTS_BOOT_VESA
>        } else if ((vminfo.mode_attr & 0x99) == 0x99) {
>                /* It's a graphics mode with linear frame buffer */
>                is_graphic = 1;
>                vesa_mode |= 0x4000; /* Request linear frame buffer */
>  +#endif
>        } else {
>                return -1;      /* Invalid mode */
>        }

Agreed.

I'll wait at least one more day for any additional comments and repost
a fixed version.

Thanks for doing the code review.
-- 
Michal Januszewski, Gentoo Linux Developer
http://people.gentoo.org/spock

      parent reply	other threads:[~2008-09-22 20:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-21 21:02 Michal Januszewski
2008-09-22 19:47 ` Krzysztof Helt
2008-09-22 20:00   ` [Linux-fbdev-devel] " Bruno Prémont
2008-09-22 20:28     ` Andrew Morton
2008-09-22 20:32     ` Michal Januszewski
2008-09-22 20:54       ` Andrew Morton
2008-09-22 20:34   ` Michal Januszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d9b736f0809221334i773a500eu5ff61884729a4367@mail.gmail.com \
    --to=michalj@gmail.com \
    --cc=krzysztof.h1@poczta.fm \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®