From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756419AbdEROe5 (ORCPT ); Thu, 18 May 2017 10:34:57 -0400 Received: from mout.web.de ([212.227.15.3]:53099 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755035AbdEROew (ORCPT ); Thu, 18 May 2017 10:34:52 -0400 Subject: Re: spidev: Adjust five checks for null pointers To: Mark Brown Cc: linux-spi@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org References: <20170518112846.tcirhguyps3kk3ra@sirena.org.uk> From: SF Markus Elfring Message-ID: <5d9f71d4-2f0d-7083-fd28-fb505841b502@users.sourceforge.net> Date: Thu, 18 May 2017 16:34:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170518112846.tcirhguyps3kk3ra@sirena.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:dVi+sTEKHUCXkVVkXC0WzNhEXOvTrbOObwBgzkq0ok9EY5GSz+7 xsnRkkDcRjsBD93tuv72YTJi+fvPMlLecyIwwd+gkhMEd1pjdbz1XlwLVVTX8Rw+XyKcv6F wFccZpo+M2Ose67p8qVlgMvsXSVd8bOxqtnekVAFbcgYawc/LpYW0y9vKsT+KYpDUjnRbQJ D6lhJbpjrGRcZnR3eGNXA== X-UI-Out-Filterresults: notjunk:1;V01:K0:GV6DkVESYiY=:WGhT5cMkJvyPwkAd2k7sWk 6Npx6omsiqGHW4nR3B3g0JvjTGBSX9UG4StE3D8sRXwNx0cdCuX9VmQKyXTqqI4UemUZyLcfe ZBiyvvaItf1DFuOStAqJmAGwMgxHIIFrX0pZRAp4M0vmlsw9DFykG4itiJGdBQDQmGrTNnprR /597QgICHeKsVvBZBW1D1t1ySLGAq3sE579R6uUbSpajCuK3MieT8dp4n+E2jae1mzV0hQ9Rt 1tdt5ePbUqyoO3l1IoWk3WLCoeiZABk9/m4pIU446kEvi2WBM0JSdSJwCaKmv2kjbGKdA00IC zdB8xKIUZjcX8ivCk/SjeGMIFlOmSW/LDfvrDH/nYZYOLXqIQ+UHLWIKDRYoQR6BMmZUgluqc Q8mdNdU51ak77XD4gVr6DyJKugscbVYBdz1s9nk/+Ui863v6Bhz6osfL/m4nPsScZmlnsMPDr O+lhf2vOeKFBdLXNenYOoMzP0apY0BeaOyfC6QhS2x2NzVyfr+zUg1f/csP3LUxcoB7UoAH6g 3vgVSv5e3H5Q9SmvO1HfGg3dbkXajPkXQQuuuS7I2YUVVZndE9Jul5KhT2jAOjJxg84ZU2Zwg QJRek6NuxCyqd8H+/zt+93gm0LoWN3yuE5cMlv/E14QA0gdcVdMMTxA2IYg064PDzI+O8/NNz mYM2hsV60+3r04STw3NSApqbLnIJVLYTIswmEf7kd98wHi1ZkSNxPJr8QAoHDk8trNqnyv89W V5A3Xy3etuevd56YtsAz6sGmFMsxw0VhHlBlynhHi6C/iKt/rgMLbnA9r+G2rvdlCSw8aLUst Ce2tETH Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit > > Please fix however you're sending things out to avoid this noise. The Git software generated such extra information because my commit message contained a few special characters. >> The script “checkpatch.pl” pointed information out like the following. >> >> Comparison to NULL could be written !… >> >> Thus fix the affected source code places. > > This changelog does not describe any purpose in making this change, > we could equally well say the exact opposite. Why should we do this? How do you think about to reduce the usage of the preprocessor symbol “NULL”? Can it help if the source code is a little bit shorter after the proposed adjustment? Regards, Markus