From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: James Ogletree <james.ogletree@cirrus.com>, dmitry.torokhov@gmail.com
Cc: Fred Treven <fred.treven@cirrus.com>,
Ben Bright <ben.bright@cirrus.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Markus Schneider-Pargmann <msp@baylibre.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
ChiYuan Huang <cy_huang@richtek.com>,
Jacky Bai <ping.bai@nxp.com>, Arnd Bergmann <arnd@arndb.de>,
Jeff LaBundy <jeff@labundy.com>,
Eddie James <eajames@linux.ibm.com>,
Randy Dunlap <rdunlap@infradead.org>,
Jean Delvare <jdelvare@suse.de>, Joel Stanley <joel@jms.id.au>,
Peng Fan <peng.fan@nxp.com>,
patches@cirrus.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Input: cs40l50 - Initial support for Cirrus Logic CS40L50
Date: Wed, 9 Aug 2023 16:32:07 +0200 [thread overview]
Message-ID: <5d9ff125-e633-9522-187a-cc61f82caec0@linaro.org> (raw)
In-Reply-To: <20230809135313.731706-3-james.ogletree@cirrus.com>
On 09/08/2023 15:53, James Ogletree wrote:
> Introduce support for Cirrus Logic Device CS40L50: a
> haptics driver with waveform memory DSP and closed-loop
> algorithms.
> +static const struct of_device_id cs40l50_of_match[] = {
> + { .compatible = "cirrus,cs40l50" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, cs40l50_of_match);
> +
> +static int cs40l50_i2c_probe(struct i2c_client *client)
> +{
> + struct device *dev = &client->dev;
> + struct cs40l50_private *cs40l50;
> +
> + cs40l50 = devm_kzalloc(dev, sizeof(struct cs40l50_private), GFP_KERNEL);
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-08-09 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 13:53 [PATCH v2 0/2] Add support for CS40L50 James Ogletree
2023-08-09 13:53 ` [PATCH v2 1/2] dt-bindings: input: cirrus,cs40l50: Support " James Ogletree
2023-08-09 14:31 ` Krzysztof Kozlowski
2023-08-09 13:53 ` [PATCH v2 2/2] Input: cs40l50 - Initial support for Cirrus Logic CS40L50 James Ogletree
2023-08-09 14:32 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d9ff125-e633-9522-187a-cc61f82caec0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=ben.bright@cirrus.com \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=fred.treven@cirrus.com \
--cc=james.ogletree@cirrus.com \
--cc=jdelvare@suse.de \
--cc=jeff@labundy.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=patches@cirrus.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®